[v10,0/2] Add XYUV format support

Message

Stanislav Lisovskiy Sept. 7, 2018, 8:45 a.m. UTC

Introduced new XYUV scan-in format for framebuffer and
added support for it to i915(SkyLake+).

Stanislav Lisovskiy (2):
  drm: Introduce new DRM_FORMAT_XYUV
  drm/i915: Adding YUV444 packed format support for skl+

 drivers/gpu/drm/drm_fourcc.c         |  1 +
 drivers/gpu/drm/i915/i915_reg.h      |  2 +-
 drivers/gpu/drm/i915/intel_display.c | 15 +++++++++++++++
 drivers/gpu/drm/i915/intel_sprite.c  |  2 ++
 include/uapi/drm/drm_fourcc.h        |  1 +
 5 files changed, 20 insertions(+), 1 deletion(-)

Comments

Stanislav Lisovskiy Sept. 14, 2018, 1:36 p.m. UTC | #1

On Fri, 2018-09-07 at 11:45 +0300, Stanislav Lisovskiy wrote:
> Introduced new XYUV scan-in format for framebuffer and
> added support for it to i915(SkyLake+).
> 
> Stanislav Lisovskiy (2):
>   drm: Introduce new DRM_FORMAT_XYUV
>   drm/i915: Adding YUV444 packed format support for skl+
> 
>  drivers/gpu/drm/drm_fourcc.c         |  1 +
>  drivers/gpu/drm/i915/i915_reg.h      |  2 +-
>  drivers/gpu/drm/i915/intel_display.c | 15 +++++++++++++++
>  drivers/gpu/drm/i915/intel_sprite.c  |  2 ++
>  include/uapi/drm/drm_fourcc.h        |  1 +
>  5 files changed, 20 insertions(+), 1 deletion(-)
> 

Ping. There is an IGT patch which got Reviewed-by Ville.
This one left in order to get XYUV support.

Ville Syrjala Sept. 14, 2018, 1:47 p.m. UTC | #2

On Fri, Sep 14, 2018 at 01:36:32PM +0000, Lisovskiy, Stanislav wrote:
> On Fri, 2018-09-07 at 11:45 +0300, Stanislav Lisovskiy wrote:
> > Introduced new XYUV scan-in format for framebuffer and
> > added support for it to i915(SkyLake+).
> > 
> > Stanislav Lisovskiy (2):
> >   drm: Introduce new DRM_FORMAT_XYUV
> >   drm/i915: Adding YUV444 packed format support for skl+
> > 
> >  drivers/gpu/drm/drm_fourcc.c         |  1 +
> >  drivers/gpu/drm/i915/i915_reg.h      |  2 +-
> >  drivers/gpu/drm/i915/intel_display.c | 15 +++++++++++++++
> >  drivers/gpu/drm/i915/intel_sprite.c  |  2 ++
> >  include/uapi/drm/drm_fourcc.h        |  1 +
> >  5 files changed, 20 insertions(+), 1 deletion(-)
> > 
> 
> Ping. There is an IGT patch which got Reviewed-by Ville.
> This one left in order to get XYUV support. 

Did we figure out userspace for this?

Was the conflict solved with the other guy (forgot who it is)
trying to add the same format with a different name?

Stanislav Lisovskiy Sept. 14, 2018, 2:30 p.m. UTC | #3

On Fri, 2018-09-14 at 16:47 +0300, Ville Syrjälä wrote:
> On Fri, Sep 14, 2018 at 01:36:32PM +0000, Lisovskiy, Stanislav wrote:
> > On Fri, 2018-09-07 at 11:45 +0300, Stanislav Lisovskiy wrote:
> > > Introduced new XYUV scan-in format for framebuffer and
> > > added support for it to i915(SkyLake+).
> > > 
> > > Stanislav Lisovskiy (2):
> > >   drm: Introduce new DRM_FORMAT_XYUV
> > >   drm/i915: Adding YUV444 packed format support for skl+
> > > 
> > >  drivers/gpu/drm/drm_fourcc.c         |  1 +
> > >  drivers/gpu/drm/i915/i915_reg.h      |  2 +-
> > >  drivers/gpu/drm/i915/intel_display.c | 15 +++++++++++++++
> > >  drivers/gpu/drm/i915/intel_sprite.c  |  2 ++
> > >  include/uapi/drm/drm_fourcc.h        |  1 +
> > >  5 files changed, 20 insertions(+), 1 deletion(-)
> > > 
> > 
> > Ping. There is an IGT patch which got Reviewed-by Ville.
> > This one left in order to get XYUV support. 
> 
> Did we figure out userspace for this?
> 
> Was the conflict solved with the other guy (forgot who it is)
> trying to add the same format with a different name?

Currently for userspace we have VLC(checked with Juha-Pekka) and
also IGT test case.

I think those guys were from ARM and they were adding also support for
XYUV. The only difference was that they called XYUV, like XYUV8888
something. 
Our patches were otherwise identical regarding drm_fourcc.c part, I
don't see their stuff merged, but I guess it really shouldn't matter,
who does this first. i915 specific part doesn't conflict with their
stuff. To be honest, I forgot the guy's name neither could find his
email in my mailbox. 
So hopefully somebody shows up here.

>

Saarinen, Jani Sept. 14, 2018, 2:34 p.m. UTC | #4

Hi, 

> -----Original Message-----
> From: Intel-gfx [mailto:[e-mail]] On Behalf
> Of Lisovskiy, Stanislav
> Sent: perjantai 14. syyskuuta 2018 17.31
> To: [e-mail]
> Cc: [e-mail]; Syrjala, Ville <[e-mail]>;
> Heikkila, Juha-pekka <[e-mail]>; dri-
> [e-mail]; Peres, Martin <[e-mail]>
> Subject: Re: [Intel-gfx] [PATCH v10 0/2] Add XYUV format support
> 
> On Fri, 2018-09-14 at 16:47 +0300, Ville Syrjälä wrote:
> > On Fri, Sep 14, 2018 at 01:36:32PM +0000, Lisovskiy, Stanislav wrote:
> > > On Fri, 2018-09-07 at 11:45 +0300, Stanislav Lisovskiy wrote:
> > > > Introduced new XYUV scan-in format for framebuffer and added
> > > > support for it to i915(SkyLake+).
> > > >
> > > > Stanislav Lisovskiy (2):
> > > >   drm: Introduce new DRM_FORMAT_XYUV
> > > >   drm/i915: Adding YUV444 packed format support for skl+
> > > >
> > > >  drivers/gpu/drm/drm_fourcc.c         |  1 +
> > > >  drivers/gpu/drm/i915/i915_reg.h      |  2 +-
> > > >  drivers/gpu/drm/i915/intel_display.c | 15 +++++++++++++++
> > > > drivers/gpu/drm/i915/intel_sprite.c  |  2 ++
> > > >  include/uapi/drm/drm_fourcc.h        |  1 +
> > > >  5 files changed, 20 insertions(+), 1 deletion(-)
> > > >
> > >
> > > Ping. There is an IGT patch which got Reviewed-by Ville.
> > > This one left in order to get XYUV support.
> >
> > Did we figure out userspace for this?
> >
> > Was the conflict solved with the other guy (forgot who it is) trying
> > to add the same format with a different name?
> 
> Currently for userspace we have VLC(checked with Juha-Pekka) and also IGT
> test case.
> 
> I think those guys were from ARM and they were adding also support for
> XYUV. The only difference was that they called XYUV, like XYUV8888
> something.
> Our patches were otherwise identical regarding drm_fourcc.c part, I don't
> see their stuff merged, but I guess it really shouldn't matter, who does this
> first. i915 specific part doesn't conflict with their stuff. To be honest, I forgot
> the guy's name neither could find his email in my mailbox.
> So hopefully somebody shows up here.
Stan:
Alexandru-Cosmin Gheorghe <[e-mail]> ? 

> 
> >
> --
> Best Regards,
> 
> Lisovskiy Stanislav
> _______________________________________________
> Intel-gfx mailing list
> [e-mail]
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Stanislav Lisovskiy Sept. 14, 2018, 2:49 p.m. UTC | #5

On Fri, 2018-09-14 at 15:34 +0100, Saarinen, Jani wrote:
> Hi, 
> 
> > -----Original Message-----
> > From: Intel-gfx [mailto:[e-mail]] On
> > Behalf
> > Of Lisovskiy, Stanislav
> > Sent: perjantai 14. syyskuuta 2018 17.31
> > To: [e-mail]
> > Cc: [e-mail]; Syrjala, Ville <ville.syrjala@
> > intel.com>;
> > Heikkila, Juha-pekka <[e-mail]>; dri-
> > [e-mail]; Peres, Martin <[e-mail]>
> > Subject: Re: [Intel-gfx] [PATCH v10 0/2] Add XYUV format support
> > 
> > On Fri, 2018-09-14 at 16:47 +0300, Ville Syrjälä wrote:
> > > On Fri, Sep 14, 2018 at 01:36:32PM +0000, Lisovskiy, Stanislav
> > > wrote:
> > > > On Fri, 2018-09-07 at 11:45 +0300, Stanislav Lisovskiy wrote:
> > > > > Introduced new XYUV scan-in format for framebuffer and added
> > > > > support for it to i915(SkyLake+).
> > > > > 
> > > > > Stanislav Lisovskiy (2):
> > > > >   drm: Introduce new DRM_FORMAT_XYUV
> > > > >   drm/i915: Adding YUV444 packed format support for skl+
> > > > > 
> > > > >  drivers/gpu/drm/drm_fourcc.c         |  1 +
> > > > >  drivers/gpu/drm/i915/i915_reg.h      |  2 +-
> > > > >  drivers/gpu/drm/i915/intel_display.c | 15 +++++++++++++++
> > > > > drivers/gpu/drm/i915/intel_sprite.c  |  2 ++
> > > > >  include/uapi/drm/drm_fourcc.h        |  1 +
> > > > >  5 files changed, 20 insertions(+), 1 deletion(-)
> > > > > 
> > > > 
> > > > Ping. There is an IGT patch which got Reviewed-by Ville.
> > > > This one left in order to get XYUV support.
> > > 
> > > Did we figure out userspace for this?
> > > 
> > > Was the conflict solved with the other guy (forgot who it is)
> > > trying
> > > to add the same format with a different name?
> > 
> > Currently for userspace we have VLC(checked with Juha-Pekka) and
> > also IGT
> > test case.
> > 
> > I think those guys were from ARM and they were adding also support
> > for
> > XYUV. The only difference was that they called XYUV, like XYUV8888
> > something.
> > Our patches were otherwise identical regarding drm_fourcc.c part, I
> > don't
> > see their stuff merged, but I guess it really shouldn't matter, who
> > does this
> > first. i915 specific part doesn't conflict with their stuff. To be
> > honest, I forgot
> > the guy's name neither could find his email in my mailbox.
> > So hopefully somebody shows up here.
> 
> Stan:
> Alexandru-Cosmin Gheorghe <[e-mail]> ? 
> 

Exactly, found now. Thanks for the hint! 

> > 
> > > 
> > 
> > --
> > Best Regards,
> > 
> > Lisovskiy Stanislav
> > _______________________________________________
> > Intel-gfx mailing list
> > [e-mail]
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Alexandru-Cosmin Gheorghe Sept. 14, 2018, 2:59 p.m. UTC | #6

On Fri, Sep 14, 2018 at 02:49:09PM +0000, Lisovskiy, Stanislav wrote:
> On Fri, 2018-09-14 at 15:34 +0100, Saarinen, Jani wrote:
> > Hi, 
> > 
> > > -----Original Message-----
> > > From: Intel-gfx [mailto:[e-mail]] On
> > > Behalf
> > > Of Lisovskiy, Stanislav
> > > Sent: perjantai 14. syyskuuta 2018 17.31
> > > To: [e-mail]
> > > Cc: [e-mail]; Syrjala, Ville <ville.syrjala@
> > > intel.com>;
> > > Heikkila, Juha-pekka <[e-mail]>; dri-
> > > [e-mail]; Peres, Martin <[e-mail]>
> > > Subject: Re: [Intel-gfx] [PATCH v10 0/2] Add XYUV format support
> > > 
> > > On Fri, 2018-09-14 at 16:47 +0300, Ville Syrjälä wrote:
> > > > On Fri, Sep 14, 2018 at 01:36:32PM +0000, Lisovskiy, Stanislav
> > > > wrote:
> > > > > On Fri, 2018-09-07 at 11:45 +0300, Stanislav Lisovskiy wrote:
> > > > > > Introduced new XYUV scan-in format for framebuffer and added
> > > > > > support for it to i915(SkyLake+).
> > > > > > 
> > > > > > Stanislav Lisovskiy (2):
> > > > > >   drm: Introduce new DRM_FORMAT_XYUV
> > > > > >   drm/i915: Adding YUV444 packed format support for skl+
> > > > > > 
> > > > > >  drivers/gpu/drm/drm_fourcc.c         |  1 +
> > > > > >  drivers/gpu/drm/i915/i915_reg.h      |  2 +-
> > > > > >  drivers/gpu/drm/i915/intel_display.c | 15 +++++++++++++++
> > > > > > drivers/gpu/drm/i915/intel_sprite.c  |  2 ++
> > > > > >  include/uapi/drm/drm_fourcc.h        |  1 +
> > > > > >  5 files changed, 20 insertions(+), 1 deletion(-)
> > > > > > 
> > > > > 
> > > > > Ping. There is an IGT patch which got Reviewed-by Ville.
> > > > > This one left in order to get XYUV support.
> > > > 
> > > > Did we figure out userspace for this?
> > > > 
> > > > Was the conflict solved with the other guy (forgot who it is)
> > > > trying
> > > > to add the same format with a different name?
> > > 
> > > Currently for userspace we have VLC(checked with Juha-Pekka) and
> > > also IGT
> > > test case.
> > > 
> > > I think those guys were from ARM and they were adding also support
> > > for
> > > XYUV. The only difference was that they called XYUV, like XYUV8888
> > > something.
> > > Our patches were otherwise identical regarding drm_fourcc.c part, I
> > > don't
> > > see their stuff merged, but I guess it really shouldn't matter, who
> > > does this
> > > first. i915 specific part doesn't conflict with their stuff. To be
> > > honest, I forgot
> > > the guy's name neither could find his email in my mailbox.
> > > So hopefully somebody shows up here.
> > 
> > Stan:
> > Alexandru-Cosmin Gheorghe <[e-mail]> ? 
> > 
> 
> Exactly, found now. Thanks for the hint! 

Yes, that's me.
Not a real conflict here, as long as your patches are ready to be
merged feel free to do it and I will just rebase my series on top of
that.


> 
> > > 
> > > > 
> > > 
> > > --
> > > Best Regards,
> > > 
> > > Lisovskiy Stanislav
> > > _______________________________________________
> > > Intel-gfx mailing list
> > > [e-mail]
> > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> -- 
> Best Regards,
> 
> Lisovskiy Stanislav
> _______________________________________________
> dri-devel mailing list
> [e-mail]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

Juha-Pekka Heikkila Sept. 14, 2018, 5:05 p.m. UTC | #7

Lisovskiy, Stanislav kirjoitti 14.9.2018 klo 17.30:
> On Fri, 2018-09-14 at 16:47 +0300, Ville Syrjälä wrote:
>> On Fri, Sep 14, 2018 at 01:36:32PM +0000, Lisovskiy, Stanislav wrote:
>>> On Fri, 2018-09-07 at 11:45 +0300, Stanislav Lisovskiy wrote:
>>>> Introduced new XYUV scan-in format for framebuffer and
>>>> added support for it to i915(SkyLake+).
>>>>
>>>> Stanislav Lisovskiy (2):
>>>>    drm: Introduce new DRM_FORMAT_XYUV
>>>>    drm/i915: Adding YUV444 packed format support for skl+
>>>>
>>>>   drivers/gpu/drm/drm_fourcc.c         |  1 +
>>>>   drivers/gpu/drm/i915/i915_reg.h      |  2 +-
>>>>   drivers/gpu/drm/i915/intel_display.c | 15 +++++++++++++++
>>>>   drivers/gpu/drm/i915/intel_sprite.c  |  2 ++
>>>>   include/uapi/drm/drm_fourcc.h        |  1 +
>>>>   5 files changed, 20 insertions(+), 1 deletion(-)
>>>>
>>>
>>> Ping. There is an IGT patch which got Reviewed-by Ville.
>>> This one left in order to get XYUV support.
>>
>> Did we figure out userspace for this?
>>
>> Was the conflict solved with the other guy (forgot who it is)
>> trying to add the same format with a different name?
> 
> Currently for userspace we have VLC(checked with Juha-Pekka) and
> also IGT test case.

Hei, no. VLC was *not* showing the mode correctly back then when we 
tested. VLC kms plugin is able to initialize the mode and it's all 
stable but VLC didn't have correct video converter to reach matching 
xYUV output. You remember Stan we tried to increase the recursion for 
decoding in case it would help? VLC doesn't have codec which produce 
correct output, one of those xxx -> YUV plug-ins in VLC should be 
patched before VLC can be considered as userspace for this mode.

/Juha-Pekka

> 
> I think those guys were from ARM and they were adding also support for
> XYUV. The only difference was that they called XYUV, like XYUV8888
> something.
> Our patches were otherwise identical regarding drm_fourcc.c part, I
> don't see their stuff merged, but I guess it really shouldn't matter,
> who does this first. i915 specific part doesn't conflict with their
> stuff. To be honest, I forgot the guy's name neither could find his
> email in my mailbox.
> So hopefully somebody shows up here.
> 
>>

Stanislav Lisovskiy Sept. 17, 2018, 8:25 a.m. UTC | #8

On Fri, 2018-09-14 at 20:05 +0300, Juha-Pekka Heikkilä wrote:
> 
> Lisovskiy, Stanislav kirjoitti 14.9.2018 klo 17.30:
> > On Fri, 2018-09-14 at 16:47 +0300, Ville Syrjälä wrote:
> > > On Fri, Sep 14, 2018 at 01:36:32PM +0000, Lisovskiy, Stanislav
> > > wrote:
> > > > On Fri, 2018-09-07 at 11:45 +0300, Stanislav Lisovskiy wrote:
> > > > > Introduced new XYUV scan-in format for framebuffer and
> > > > > added support for it to i915(SkyLake+).
> > > > > 
> > > > > Stanislav Lisovskiy (2):
> > > > >    drm: Introduce new DRM_FORMAT_XYUV
> > > > >    drm/i915: Adding YUV444 packed format support for skl+
> > > > > 
> > > > >   drivers/gpu/drm/drm_fourcc.c         |  1 +
> > > > >   drivers/gpu/drm/i915/i915_reg.h      |  2 +-
> > > > >   drivers/gpu/drm/i915/intel_display.c | 15 +++++++++++++++
> > > > >   drivers/gpu/drm/i915/intel_sprite.c  |  2 ++
> > > > >   include/uapi/drm/drm_fourcc.h        |  1 +
> > > > >   5 files changed, 20 insertions(+), 1 deletion(-)
> > > > > 
> > > > 
> > > > Ping. There is an IGT patch which got Reviewed-by Ville.
> > > > This one left in order to get XYUV support.
> > > 
> > > Did we figure out userspace for this?
> > > 
> > > Was the conflict solved with the other guy (forgot who it is)
> > > trying to add the same format with a different name?
> > 
> > Currently for userspace we have VLC(checked with Juha-Pekka) and
> > also IGT test case.
> 
> Hei, no. VLC was *not* showing the mode correctly back then when we 
> tested. VLC kms plugin is able to initialize the mode and it's all 
> stable but VLC didn't have correct video converter to reach matching 
> xYUV output. You remember Stan we tried to increase the recursion
> for 
> decoding in case it would help? VLC doesn't have codec which produce 
> correct output, one of those xxx -> YUV plug-ins in VLC should be 
> patched before VLC can be considered as userspace for this mode.

Ok, I remember we managed to make it work somehow and saw some picture,
so for some reason I thought it is working already. What is our plan
then? Should we try to improve VLC codecs/plugins or may be I should
then work with some other user space case?

> 
> /Juha-Pekka
> 
> > 
> > I think those guys were from ARM and they were adding also support
> > for
> > XYUV. The only difference was that they called XYUV, like XYUV8888
> > something.
> > Our patches were otherwise identical regarding drm_fourcc.c part, I
> > don't see their stuff merged, but I guess it really shouldn't
> > matter,
> > who does this first. i915 specific part doesn't conflict with their
> > stuff. To be honest, I forgot the guy's name neither could find his
> > email in my mailbox.
> > So hopefully somebody shows up here.
> > 
> > >

Stanislav Lisovskiy Sept. 17, 2018, 8:27 a.m. UTC | #9

On Fri, 2018-09-14 at 14:59 +0000, Alexandru-Cosmin Gheorghe wrote:
> On Fri, Sep 14, 2018 at 02:49:09PM +0000, Lisovskiy, Stanislav wrote:
> > On Fri, 2018-09-14 at 15:34 +0100, Saarinen, Jani wrote:
> > > Hi, 
> > > 
> > > > -----Original Message-----
> > > > From: Intel-gfx [mailto:[e-mail]
> > > > ] On
> > > > Behalf
> > > > Of Lisovskiy, Stanislav
> > > > Sent: perjantai 14. syyskuuta 2018 17.31
> > > > To: [e-mail]
> > > > Cc: [e-mail]; Syrjala, Ville
> > > > <ville.syrjala@
> > > > intel.com>;
> > > > Heikkila, Juha-pekka <[e-mail]>; dri-
> > > > [e-mail]; Peres, Martin <martin.peres@intel.
> > > > com>
> > > > Subject: Re: [Intel-gfx] [PATCH v10 0/2] Add XYUV format
> > > > support
> > > > 
> > > > On Fri, 2018-09-14 at 16:47 +0300, Ville Syrjälä wrote:
> > > > > On Fri, Sep 14, 2018 at 01:36:32PM +0000, Lisovskiy,
> > > > > Stanislav
> > > > > wrote:
> > > > > > On Fri, 2018-09-07 at 11:45 +0300, Stanislav Lisovskiy
> > > > > > wrote:
> > > > > > > Introduced new XYUV scan-in format for framebuffer and
> > > > > > > added
> > > > > > > support for it to i915(SkyLake+).
> > > > > > > 
> > > > > > > Stanislav Lisovskiy (2):
> > > > > > >   drm: Introduce new DRM_FORMAT_XYUV
> > > > > > >   drm/i915: Adding YUV444 packed format support for skl+
> > > > > > > 
> > > > > > >  drivers/gpu/drm/drm_fourcc.c         |  1 +
> > > > > > >  drivers/gpu/drm/i915/i915_reg.h      |  2 +-
> > > > > > >  drivers/gpu/drm/i915/intel_display.c | 15
> > > > > > > +++++++++++++++
> > > > > > > drivers/gpu/drm/i915/intel_sprite.c  |  2 ++
> > > > > > >  include/uapi/drm/drm_fourcc.h        |  1 +
> > > > > > >  5 files changed, 20 insertions(+), 1 deletion(-)
> > > > > > > 
> > > > > > 
> > > > > > Ping. There is an IGT patch which got Reviewed-by Ville.
> > > > > > This one left in order to get XYUV support.
> > > > > 
> > > > > Did we figure out userspace for this?
> > > > > 
> > > > > Was the conflict solved with the other guy (forgot who it is)
> > > > > trying
> > > > > to add the same format with a different name?
> > > > 
> > > > Currently for userspace we have VLC(checked with Juha-Pekka)
> > > > and
> > > > also IGT
> > > > test case.
> > > > 
> > > > I think those guys were from ARM and they were adding also
> > > > support
> > > > for
> > > > XYUV. The only difference was that they called XYUV, like
> > > > XYUV8888
> > > > something.
> > > > Our patches were otherwise identical regarding drm_fourcc.c
> > > > part, I
> > > > don't
> > > > see their stuff merged, but I guess it really shouldn't matter,
> > > > who
> > > > does this
> > > > first. i915 specific part doesn't conflict with their stuff. To
> > > > be
> > > > honest, I forgot
> > > > the guy's name neither could find his email in my mailbox.
> > > > So hopefully somebody shows up here.
> > > 
> > > Stan:
> > > Alexandru-Cosmin Gheorghe <[e-mail]> ? 
> > > 
> > 
> > Exactly, found now. Thanks for the hint! 
> 
> Yes, that's me.
> Not a real conflict here, as long as your patches are ready to be
> merged feel free to do it and I will just rebase my series on top of
> that.

I can change DRM_FORMAT_XYUV naming to DRM_FORMAT_XYUV8888 also, so
that my patch series then is compatible with yours.

> 
> 
> > 
> > > > 
> > > > > 
> > > > 
> > > > --
> > > > Best Regards,
> > > > 
> > > > Lisovskiy Stanislav
> > > > _______________________________________________
> > > > Intel-gfx mailing list
> > > > [e-mail]
> > > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> > 
> > -- 
> > Best Regards,
> > 
> > Lisovskiy Stanislav
> > _______________________________________________
> > dri-devel mailing list
> > [e-mail]
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 
>

Alexandru-Cosmin Gheorghe Sept. 17, 2018, 8:49 a.m. UTC | #10

Hi,

On Mon, Sep 17, 2018 at 08:27:18AM +0000, Lisovskiy, Stanislav wrote:
> On Fri, 2018-09-14 at 14:59 +0000, Alexandru-Cosmin Gheorghe wrote:
> > On Fri, Sep 14, 2018 at 02:49:09PM +0000, Lisovskiy, Stanislav wrote:
> > > On Fri, 2018-09-14 at 15:34 +0100, Saarinen, Jani wrote:
> > > > Hi, 
> > > > 
> > > > > -----Original Message-----
> > > > > From: Intel-gfx [mailto:[e-mail]
> > > > > ] On
> > > > > Behalf
> > > > > Of Lisovskiy, Stanislav
> > > > > Sent: perjantai 14. syyskuuta 2018 17.31
> > > > > To: [e-mail]
> > > > > Cc: [e-mail]; Syrjala, Ville
> > > > > <ville.syrjala@
> > > > > intel.com>;
> > > > > Heikkila, Juha-pekka <[e-mail]>; dri-
> > > > > [e-mail]; Peres, Martin <martin.peres@intel.
> > > > > com>
> > > > > Subject: Re: [Intel-gfx] [PATCH v10 0/2] Add XYUV format
> > > > > support
> > > > > 
> > > > > On Fri, 2018-09-14 at 16:47 +0300, Ville Syrjälä wrote:
> > > > > > On Fri, Sep 14, 2018 at 01:36:32PM +0000, Lisovskiy,
> > > > > > Stanislav
> > > > > > wrote:
> > > > > > > On Fri, 2018-09-07 at 11:45 +0300, Stanislav Lisovskiy
> > > > > > > wrote:
> > > > > > > > Introduced new XYUV scan-in format for framebuffer and
> > > > > > > > added
> > > > > > > > support for it to i915(SkyLake+).
> > > > > > > > 
> > > > > > > > Stanislav Lisovskiy (2):
> > > > > > > >   drm: Introduce new DRM_FORMAT_XYUV
> > > > > > > >   drm/i915: Adding YUV444 packed format support for skl+
> > > > > > > > 
> > > > > > > >  drivers/gpu/drm/drm_fourcc.c         |  1 +
> > > > > > > >  drivers/gpu/drm/i915/i915_reg.h      |  2 +-
> > > > > > > >  drivers/gpu/drm/i915/intel_display.c | 15
> > > > > > > > +++++++++++++++
> > > > > > > > drivers/gpu/drm/i915/intel_sprite.c  |  2 ++
> > > > > > > >  include/uapi/drm/drm_fourcc.h        |  1 +
> > > > > > > >  5 files changed, 20 insertions(+), 1 deletion(-)
> > > > > > > > 
> > > > > > > 
> > > > > > > Ping. There is an IGT patch which got Reviewed-by Ville.
> > > > > > > This one left in order to get XYUV support.
> > > > > > 
> > > > > > Did we figure out userspace for this?
> > > > > > 
> > > > > > Was the conflict solved with the other guy (forgot who it is)
> > > > > > trying
> > > > > > to add the same format with a different name?
> > > > > 
> > > > > Currently for userspace we have VLC(checked with Juha-Pekka)
> > > > > and
> > > > > also IGT
> > > > > test case.
> > > > > 
> > > > > I think those guys were from ARM and they were adding also
> > > > > support
> > > > > for
> > > > > XYUV. The only difference was that they called XYUV, like
> > > > > XYUV8888
> > > > > something.
> > > > > Our patches were otherwise identical regarding drm_fourcc.c
> > > > > part, I
> > > > > don't
> > > > > see their stuff merged, but I guess it really shouldn't matter,
> > > > > who
> > > > > does this
> > > > > first. i915 specific part doesn't conflict with their stuff. To
> > > > > be
> > > > > honest, I forgot
> > > > > the guy's name neither could find his email in my mailbox.
> > > > > So hopefully somebody shows up here.
> > > > 
> > > > Stan:
> > > > Alexandru-Cosmin Gheorghe <[e-mail]> ? 
> > > > 
> > > 
> > > Exactly, found now. Thanks for the hint! 
> > 
> > Yes, that's me.
> > Not a real conflict here, as long as your patches are ready to be
> > merged feel free to do it and I will just rebase my series on top of
> > that.
> 
> I can change DRM_FORMAT_XYUV naming to DRM_FORMAT_XYUV8888 also, so
> that my patch series then is compatible with yours.

That would be nice.
Thank you.

> 
> > 
> > 
> > > 
> > > > > 
> > > > > > 
> > > > > 
> > > > > --
> > > > > Best Regards,
> > > > > 
> > > > > Lisovskiy Stanislav
> > > > > _______________________________________________
> > > > > Intel-gfx mailing list
> > > > > [e-mail]
> > > > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> > > 
> > > -- 
> > > Best Regards,
> > > 
> > > Lisovskiy Stanislav
> > > _______________________________________________
> > > dri-devel mailing list
> > > [e-mail]
> > > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> > 
> > 
> -- 
> Best Regards,
> 
> Lisovskiy Stanislav

Juha-Pekka Heikkila Sept. 17, 2018, 8:51 a.m. UTC | #11

On 17.09.2018 11:25, Lisovskiy, Stanislav wrote:
> On Fri, 2018-09-14 at 20:05 +0300, Juha-Pekka Heikkilä wrote:
>>
>> Lisovskiy, Stanislav kirjoitti 14.9.2018 klo 17.30:
>>> On Fri, 2018-09-14 at 16:47 +0300, Ville Syrjälä wrote:
>>>> On Fri, Sep 14, 2018 at 01:36:32PM +0000, Lisovskiy, Stanislav
>>>> wrote:
>>>>> On Fri, 2018-09-07 at 11:45 +0300, Stanislav Lisovskiy wrote:
>>>>>> Introduced new XYUV scan-in format for framebuffer and
>>>>>> added support for it to i915(SkyLake+).
>>>>>>
>>>>>> Stanislav Lisovskiy (2):
>>>>>>     drm: Introduce new DRM_FORMAT_XYUV
>>>>>>     drm/i915: Adding YUV444 packed format support for skl+
>>>>>>
>>>>>>    drivers/gpu/drm/drm_fourcc.c         |  1 +
>>>>>>    drivers/gpu/drm/i915/i915_reg.h      |  2 +-
>>>>>>    drivers/gpu/drm/i915/intel_display.c | 15 +++++++++++++++
>>>>>>    drivers/gpu/drm/i915/intel_sprite.c  |  2 ++
>>>>>>    include/uapi/drm/drm_fourcc.h        |  1 +
>>>>>>    5 files changed, 20 insertions(+), 1 deletion(-)
>>>>>>
>>>>>
>>>>> Ping. There is an IGT patch which got Reviewed-by Ville.
>>>>> This one left in order to get XYUV support.
>>>>
>>>> Did we figure out userspace for this?
>>>>
>>>> Was the conflict solved with the other guy (forgot who it is)
>>>> trying to add the same format with a different name?
>>>
>>> Currently for userspace we have VLC(checked with Juha-Pekka) and
>>> also IGT test case.
>>
>> Hei, no. VLC was *not* showing the mode correctly back then when we
>> tested. VLC kms plugin is able to initialize the mode and it's all
>> stable but VLC didn't have correct video converter to reach matching
>> xYUV output. You remember Stan we tried to increase the recursion
>> for
>> decoding in case it would help? VLC doesn't have codec which produce
>> correct output, one of those xxx -> YUV plug-ins in VLC should be
>> patched before VLC can be considered as userspace for this mode.
> 
> Ok, I remember we managed to make it work somehow and saw some picture,
> so for some reason I thought it is working already. What is our plan
> then? Should we try to improve VLC codecs/plugins or may be I should
> then work with some other user space case?
> 

For VLC there are codecs which know about xYUV format but they seem to 
use it for input, I figure nobody so far needed it for output. If want 
to use VLC as userspace demo one of those codecs need to be patched up 
for outputting xYUV. As they already support many other YUV formats I 
wouldn't expect needed change to be significant on code level as KMS 
support is already in VLC.

>>
>> /Juha-Pekka
>>
>>>
>>> I think those guys were from ARM and they were adding also support
>>> for
>>> XYUV. The only difference was that they called XYUV, like XYUV8888
>>> something.
>>> Our patches were otherwise identical regarding drm_fourcc.c part, I
>>> don't see their stuff merged, but I guess it really shouldn't
>>> matter,
>>> who does this first. i915 specific part doesn't conflict with their
>>> stuff. To be honest, I forgot the guy's name neither could find his
>>> email in my mailbox.
>>> So hopefully somebody shows up here.
>>>
>>>>