| Message ID | 20180914224849.27173-2-lolivei@synopsys.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | platform: dwc: Add of DesignWare MIPI CSI-2 Host | expand |
Hi Luis,
I love your patch! Yet something to improve:
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.19-rc3 next-20180913]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Luis-Oliveira/media-platform-Add-DesignWare-MIPI-CSI2-Host-placeholder/20180915-163514
base: git://linuxtv.org/media_tree.git master
config: i386-randconfig-s2-201836-CONFIG_DEBUG_INFO_REDUCED (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
Note: the linux-review/Luis-Oliveira/media-platform-Add-DesignWare-MIPI-CSI2-Host-placeholder/20180915-163514 HEAD 2381c016179252d3b126e055b21edaef9ae5e1e2 builds fine.
It only hurts bisectibility.
All errors (new ones prefixed by >>):
>> scripts/Makefile.build:45: drivers/media/platform/dwc/Makefile: No such file or directory
>> make[5]: *** No rule to make target 'drivers/media/platform/dwc/Makefile'.
make[5]: Failed to remake makefile 'drivers/media/platform/dwc/Makefile'.
vim +45 scripts/Makefile.build
0c53c8e6 Sam Ravnborg 2007-10-14 41
2a691470 Sam Ravnborg 2005-07-25 42 # The filename Kbuild has precedence over Makefile
db8c1a7b Sam Ravnborg 2005-07-27 43 kbuild-dir := $(if $(filter /%,$(src)),$(src),$(srctree)/$(src))
0c53c8e6 Sam Ravnborg 2007-10-14 44 kbuild-file := $(if $(wildcard $(kbuild-dir)/Kbuild),$(kbuild-dir)/Kbuild,$(kbuild-dir)/Makefile)
0c53c8e6 Sam Ravnborg 2007-10-14 @45 include $(kbuild-file)
^1da177e Linus Torvalds 2005-04-16 46
:::::: The code at line 45 was first introduced by commit
:::::: 0c53c8e6eb456cde30f2305421c605713856abc8 kbuild: check for wrong use of CFLAGS
:::::: TO: Sam Ravnborg <sam@neptun.(none)>
:::::: CC: Sam Ravnborg <sam@neptun.(none)>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Hi Luis,
I love your patch! Yet something to improve:
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.19-rc3 next-20180913]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Luis-Oliveira/media-platform-Add-DesignWare-MIPI-CSI2-Host-placeholder/20180915-163514
base: git://linuxtv.org/media_tree.git master
config: i386-randconfig-s3-201836 (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
Note: the linux-review/Luis-Oliveira/media-platform-Add-DesignWare-MIPI-CSI2-Host-placeholder/20180915-163514 HEAD 2381c016179252d3b126e055b21edaef9ae5e1e2 builds fine.
It only hurts bisectibility.
All errors (new ones prefixed by >>):
>> scripts/Makefile.modbuiltin:26: drivers/media/platform/dwc/Makefile: No such file or directory
make[5]: *** No rule to make target 'drivers/media/platform/dwc/Makefile'.
make[5]: Failed to remake makefile 'drivers/media/platform/dwc/Makefile'.
vim +26 scripts/Makefile.modbuiltin
607b30fc Michal Marek 2010-06-10 22
bc081dd6 Michal Marek 2009-12-07 23 # The filename Kbuild has precedence over Makefile
bc081dd6 Michal Marek 2009-12-07 24 kbuild-dir := $(if $(filter /%,$(src)),$(src),$(srctree)/$(src))
bc081dd6 Michal Marek 2009-12-07 25 kbuild-file := $(if $(wildcard $(kbuild-dir)/Kbuild),$(kbuild-dir)/Kbuild,$(kbuild-dir)/Makefile)
bc081dd6 Michal Marek 2009-12-07 @26 include $(kbuild-file)
bc081dd6 Michal Marek 2009-12-07 27
:::::: The code at line 26 was first introduced by commit
:::::: bc081dd6e9f622c73334dc465359168543ccaabf kbuild: generate modules.builtin
:::::: TO: Michal Marek <mmarek@suse.cz>
:::::: CC: Michal Marek <mmarek@suse.cz>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig index f627587..f627a27 100644 --- a/drivers/media/platform/Kconfig +++ b/drivers/media/platform/Kconfig @@ -137,6 +137,7 @@ source "drivers/media/platform/am437x/Kconfig" source "drivers/media/platform/xilinx/Kconfig" source "drivers/media/platform/rcar-vin/Kconfig" source "drivers/media/platform/atmel/Kconfig" +source "drivers/media/platform/dwc/Kconfig" config VIDEO_TI_CAL tristate "TI CAL (Camera Adaptation Layer) driver" diff --git a/drivers/media/platform/Makefile b/drivers/media/platform/Makefile index 6ab6200..def2f33 100644 --- a/drivers/media/platform/Makefile +++ b/drivers/media/platform/Makefile @@ -98,3 +98,6 @@ obj-$(CONFIG_VIDEO_QCOM_VENUS) += qcom/venus/ obj-y += meson/ obj-y += cros-ec-cec/ + +obj-y += dwc/ + diff --git a/drivers/media/platform/dwc/Kconfig b/drivers/media/platform/dwc/Kconfig new file mode 100644 index 0000000..6b1e985 --- /dev/null +++ b/drivers/media/platform/dwc/Kconfig @@ -0,0 +1,19 @@ +# +# Synopsys DWC Platform drivers +# Most drivers here are currently for MIPI CSI-2 and MIPI DPHY support + +config DWC_MIPI_CSI2_HOST + bool "Synopsys Designware CSI-2 Host Controller and DPHY-RX support" + select VIDEO_DEV + select VIDEO_V4L2 + select VIDEO_V4L2_SUBDEV_API + select VIDEOBUF2_VMALLOC + select VIDEOBUF2_DMA_CONTIG + select GENERIC_PHY + select VIDEO_OV5647 + help + This selects the CSI-2 host controller support. + If you have a controller with this interface, say Y + + If unsure, say N. +
This patch has the intention of make the patchseries more clear by creating a dwc folder and a Kconfig variable that sets dependencies. Signed-off-by: Luis Oliveira <lolivei@synopsys.com> --- drivers/media/platform/Kconfig | 1 + drivers/media/platform/Makefile | 3 +++ drivers/media/platform/dwc/Kconfig | 19 +++++++++++++++++++ 3 files changed, 23 insertions(+) create mode 100644 drivers/media/platform/dwc/Kconfig