diff mbox series

[2/6] qla2xxx_nvmet: Added Makefile and Kconfig changes

Message ID 20180914212811.11463-3-himanshu.madhani@cavium.com (mailing list archive)
State Changes Requested
Headers show
Series qla2xxx: Add FC-NVMe Target support | expand

Commit Message

Madhani, Himanshu Sept. 14, 2018, 9:28 p.m. UTC 
From: Anil Gurumurthy <anil.gurumurthy@cavium.com>

This patch updates kconfig and make file to include
compilation of new NVMe Target files

Signed-off-by: Anil Gurumurthy <anil.gurumurthy@cavium.com>
Signed-off-by: Giridhar Malavali <giridhar.malavali@cavium.com>
Signed-off-by: Himanshu Madhani <himanshu.madhani@cavium.com>
---
 drivers/scsi/qla2xxx/Kconfig  | 1 +
 drivers/scsi/qla2xxx/Makefile | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

Comments

Bart Van Assche Sept. 16, 2018, 4:53 a.m. UTC | #1 
On 09/14/18 14:28, Himanshu Madhani wrote:
> diff --git a/drivers/scsi/qla2xxx/Kconfig b/drivers/scsi/qla2xxx/Kconfig
> index 036cc3f217b1..f1539d8b68ef 100644
> --- a/drivers/scsi/qla2xxx/Kconfig
> +++ b/drivers/scsi/qla2xxx/Kconfig
> @@ -3,6 +3,7 @@ config SCSI_QLA_FC
>   	depends on PCI && SCSI
>   	depends on SCSI_FC_ATTRS
>   	depends on NVME_FC || !NVME_FC
> +	depends on NVME_TARGET_FC || !NVME_TARGET_FC

Why has this line been added?

Please also consider to fold this patch into the first patch. I don't 
think it makes sense that patches 1/6 and 2/6 are separate.

Bart.
Madhani, Himanshu Sept. 17, 2018, 7:07 p.m. UTC | #2 
> On Sep 15, 2018, at 9:53 PM, Bart Van Assche <bvanassche@acm.org> wrote:
> 
> External Email
> 
> On 09/14/18 14:28, Himanshu Madhani wrote:
>> diff --git a/drivers/scsi/qla2xxx/Kconfig b/drivers/scsi/qla2xxx/Kconfig
>> index 036cc3f217b1..f1539d8b68ef 100644
>> --- a/drivers/scsi/qla2xxx/Kconfig
>> +++ b/drivers/scsi/qla2xxx/Kconfig
>> @@ -3,6 +3,7 @@ config SCSI_QLA_FC
>>      depends on PCI && SCSI
>>      depends on SCSI_FC_ATTRS
>>      depends on NVME_FC || !NVME_FC
>> +     depends on NVME_TARGET_FC || !NVME_TARGET_FC
> 
> Why has this line been added?
> 

We’ve added this to indicate NVMe Target support with the driver. 
anything that I am missing? 

> Please also consider to fold this patch into the first patch. I don't
> think it makes sense that patches 1/6 and 2/6 are separate.
> 

Sure

> Bart.

Thanks,
- Himanshu
Bart Van Assche Sept. 17, 2018, 8:03 p.m. UTC | #3 
On 9/17/18 12:07 PM, Madhani, Himanshu wrote:
> 
>> On Sep 15, 2018, at 9:53 PM, Bart Van Assche <bvanassche@acm.org> wrote:
>>
>> External Email
>>
>> On 09/14/18 14:28, Himanshu Madhani wrote:
>>> diff --git a/drivers/scsi/qla2xxx/Kconfig b/drivers/scsi/qla2xxx/Kconfig
>>> index 036cc3f217b1..f1539d8b68ef 100644
>>> --- a/drivers/scsi/qla2xxx/Kconfig
>>> +++ b/drivers/scsi/qla2xxx/Kconfig
>>> @@ -3,6 +3,7 @@ config SCSI_QLA_FC
>>>       depends on PCI && SCSI
>>>       depends on SCSI_FC_ATTRS
>>>       depends on NVME_FC || !NVME_FC
>>> +     depends on NVME_TARGET_FC || !NVME_TARGET_FC
>>
>> Why has this line been added?
>>
> 
> We’ve added this to indicate NVMe Target support with the driver.
> anything that I am missing?

Hello Himanshu,

Does the qla2xxx driver build with CONFIG_NVME_TARGET_FC=y, 
CONFIG_NVME_TARGET_FC=m and CONFIG_NVME_TARGET_FC=n? If so, why do you 
think that the line "depends on NVME_TARGET_FC || !NVME_TARGET_FC" is 
necessary?

Thanks,

Bart.
Madhani, Himanshu Sept. 17, 2018, 10:22 p.m. UTC | #4 
> On Sep 17, 2018, at 1:03 PM, Bart Van Assche <bvanassche@acm.org> wrote:
> 
> External Email
> 
> On 9/17/18 12:07 PM, Madhani, Himanshu wrote:
>> 
>>> On Sep 15, 2018, at 9:53 PM, Bart Van Assche <bvanassche@acm.org> wrote:
>>> 
>>> External Email
>>> 
>>> On 09/14/18 14:28, Himanshu Madhani wrote:
>>>> diff --git a/drivers/scsi/qla2xxx/Kconfig b/drivers/scsi/qla2xxx/Kconfig
>>>> index 036cc3f217b1..f1539d8b68ef 100644
>>>> --- a/drivers/scsi/qla2xxx/Kconfig
>>>> +++ b/drivers/scsi/qla2xxx/Kconfig
>>>> @@ -3,6 +3,7 @@ config SCSI_QLA_FC
>>>>      depends on PCI && SCSI
>>>>      depends on SCSI_FC_ATTRS
>>>>      depends on NVME_FC || !NVME_FC
>>>> +     depends on NVME_TARGET_FC || !NVME_TARGET_FC
>>> 
>>> Why has this line been added?
>>> 
>> 
>> We’ve added this to indicate NVMe Target support with the driver.
>> anything that I am missing?
> 
> Hello Himanshu,
> 
> Does the qla2xxx driver build with CONFIG_NVME_TARGET_FC=y,
> CONFIG_NVME_TARGET_FC=m and CONFIG_NVME_TARGET_FC=n? If so, why do you
> think that the line "depends on NVME_TARGET_FC || !NVME_TARGET_FC" is
> necessary?
> 

Okay. we’ll revisit this and post update. Thanks.

> Thanks,
> 
> Bart.

Thanks,
- Himanshu
diff mbox series

Patch

diff --git a/drivers/scsi/qla2xxx/Kconfig b/drivers/scsi/qla2xxx/Kconfig
index 036cc3f217b1..f1539d8b68ef 100644
--- a/drivers/scsi/qla2xxx/Kconfig
+++ b/drivers/scsi/qla2xxx/Kconfig
@@ -3,6 +3,7 @@  config SCSI_QLA_FC
 	depends on PCI && SCSI
 	depends on SCSI_FC_ATTRS
 	depends on NVME_FC || !NVME_FC
+	depends on NVME_TARGET_FC || !NVME_TARGET_FC
 	select FW_LOADER
 	select BTREE
 	---help---
diff --git a/drivers/scsi/qla2xxx/Makefile b/drivers/scsi/qla2xxx/Makefile
index 17d5bc1cc56b..ec924733c10e 100644
--- a/drivers/scsi/qla2xxx/Makefile
+++ b/drivers/scsi/qla2xxx/Makefile
@@ -1,7 +1,8 @@ 
 # SPDX-License-Identifier: GPL-2.0
 qla2xxx-y := qla_os.o qla_init.o qla_mbx.o qla_iocb.o qla_isr.o qla_gs.o \
 		qla_dbg.o qla_sup.o qla_attr.o qla_mid.o qla_dfs.o qla_bsg.o \
-		qla_nx.o qla_mr.o qla_nx2.o qla_target.o qla_tmpl.o qla_nvme.o
+		qla_nx.o qla_mr.o qla_nx2.o qla_target.o qla_tmpl.o qla_nvme.o \
+		qla_nvmet.o
 
 obj-$(CONFIG_SCSI_QLA_FC) += qla2xxx.o
 obj-$(CONFIG_TCM_QLA2XXX) += tcm_qla2xxx.o