| Message ID | 1537247208-33632-1-git-send-email-zhongjiang@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Andy Gross |
| Headers | show |
| Series | ASoC: qcom: Fix a uninitialized warning. | expand |
On Tue, Sep 18, 2018 at 01:06:48PM +0800, zhong jiang wrote: > Fix the following compile warning: > > drivers/soc/qcom/cmd-db.c:194:38: warning: ent.addr may be used uninitialized in this function [-Wmaybe-uninitialized] > return ret < 0 ? 0 : le32_to_cpu(ent.addr); > > drivers/soc/qcom/cmd-db.c:247:38: warning: ent.len may be used uninitialized in this function [-Wmaybe-uninitialized] > return ret < 0 ? 0 : le16_to_cpu(ent.len); > > drivers/soc/qcom/cmd-db.c:269:24: warning: ent.addr may be used uninitialized in this function [-Wmaybe-uninitialized] > addr = le32_to_cpu(ent.addr); > > Signed-off-by: zhong jiang <zhongjiang@huawei.com> > --- > drivers/soc/qcom/cmd-db.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) This is kind of an odd subject for the patch. It should be something like drivers: qcom: cmd-db: XXXXXXXXXXXXX ASOC is sound related. Regards, Andy
On 2018/9/19 1:17, Andy Gross wrote: > On Tue, Sep 18, 2018 at 01:06:48PM +0800, zhong jiang wrote: >> Fix the following compile warning: >> >> drivers/soc/qcom/cmd-db.c:194:38: warning: 'ent.addr' may be used uninitialized in this function [-Wmaybe-uninitialized] >> return ret < 0 ? 0 : le32_to_cpu(ent.addr); >> >> drivers/soc/qcom/cmd-db.c:247:38: warning: 'ent.len' may be used uninitialized in this function [-Wmaybe-uninitialized] >> return ret < 0 ? 0 : le16_to_cpu(ent.len); >> >> drivers/soc/qcom/cmd-db.c:269:24: warning: 'ent.addr' may be used uninitialized in this function [-Wmaybe-uninitialized] >> addr = le32_to_cpu(ent.addr); >> >> Signed-off-by: zhong jiang <zhongjiang@huawei.com> >> --- >> drivers/soc/qcom/cmd-db.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) > This is kind of an odd subject for the patch. It should be something like > drivers: qcom: cmd-db: XXXXXXXXXXXXX > > ASOC is sound related. Thank you for your reply and review. I will update the subject and repost. Sincerely, zhong jiang > > Regards, > > Andy > >
diff --git a/drivers/soc/qcom/cmd-db.c b/drivers/soc/qcom/cmd-db.c index a6f6462..280877f 100644 --- a/drivers/soc/qcom/cmd-db.c +++ b/drivers/soc/qcom/cmd-db.c @@ -186,7 +186,7 @@ static int cmd_db_get_header(const char *id, struct entry_header *eh, u32 cmd_db_read_addr(const char *id) { int ret; - struct entry_header ent; + struct entry_header ent = {0}; struct rsc_hdr rsc_hdr; ret = cmd_db_get_header(id, &ent, &rsc_hdr); @@ -239,7 +239,7 @@ int cmd_db_read_aux_data(const char *id, u8 *data, size_t len) size_t cmd_db_read_aux_data_len(const char *id) { int ret; - struct entry_header ent; + struct entry_header ent = {0}; struct rsc_hdr rsc_hdr; ret = cmd_db_get_header(id, &ent, &rsc_hdr); @@ -258,7 +258,7 @@ size_t cmd_db_read_aux_data_len(const char *id) enum cmd_db_hw_type cmd_db_read_slave_id(const char *id) { int ret; - struct entry_header ent; + struct entry_header ent = {0}; struct rsc_hdr rsc_hdr; u32 addr;
Fix the following compile warning: drivers/soc/qcom/cmd-db.c:194:38: warning: ent.addr may be used uninitialized in this function [-Wmaybe-uninitialized] return ret < 0 ? 0 : le32_to_cpu(ent.addr); drivers/soc/qcom/cmd-db.c:247:38: warning: ent.len may be used uninitialized in this function [-Wmaybe-uninitialized] return ret < 0 ? 0 : le16_to_cpu(ent.len); drivers/soc/qcom/cmd-db.c:269:24: warning: ent.addr may be used uninitialized in this function [-Wmaybe-uninitialized] addr = le32_to_cpu(ent.addr); Signed-off-by: zhong jiang <zhongjiang@huawei.com> --- drivers/soc/qcom/cmd-db.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)