| Message ID | 1537314192-26892-6-git-send-email-vgarodia@codeaurora.org (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | Andy Gross |
| Headers | show |
| Series | Venus updates - PIL | expand |
On Wed, Sep 19, 2018 at 8:44 AM Vikash Garodia <vgarodia@codeaurora.org> wrote: > > Add devicetree binding documentation for firmware loader for video > hardware running on qualcomm chip. > > Signed-off-by: Vikash Garodia <vgarodia@codeaurora.org> > --- > Documentation/devicetree/bindings/media/qcom,venus.txt | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/media/qcom,venus.txt b/Documentation/devicetree/bindings/media/qcom,venus.txt > index 00d0d1b..7e04586 100644 > --- a/Documentation/devicetree/bindings/media/qcom,venus.txt > +++ b/Documentation/devicetree/bindings/media/qcom,venus.txt > @@ -53,7 +53,7 @@ > > * Subnodes > The Venus video-codec node must contain two subnodes representing > -video-decoder and video-encoder. > +video-decoder and video-encoder, and one optional firmware subnode. I think I mentioned this in my previous review, but it would be nice to explain in which circumstances the firmware node is optional. I.e. it should not be specified if TrustZone is used. > > Every of video-encoder or video-decoder subnode should have: > > @@ -79,6 +79,13 @@ Every of video-encoder or video-decoder subnode should have: > power domain which is responsible for collapsing > and restoring power to the subcore. > > +The firmware subnode must have: > + > +- iommus: > + Usage: required > + Value type: <prop-encoded-array> > + Definition: A list of phandle and IOMMU specifier pairs. > + > * An Example > video-codec@1d00000 { > compatible = "qcom,msm8916-venus"; > @@ -105,4 +112,8 @@ Every of video-encoder or video-decoder subnode should have: > clock-names = "core"; > power-domains = <&mmcc VENUS_CORE1_GDSC>; > }; > + > + video-firmware { > + iommus = <&apps_iommu 0x10b2 0x0>; > + }; > }; > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >
On Wed, Sep 19, 2018 at 05:13:12AM +0530, Vikash Garodia wrote: > Add devicetree binding documentation for firmware loader for video > hardware running on qualcomm chip. > > Signed-off-by: Vikash Garodia <vgarodia@codeaurora.org> > --- > Documentation/devicetree/bindings/media/qcom,venus.txt | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) Something change in this? If not, then please add acks/reviewed-bys when posting new versions. Rob
Hi Rob, On 2018-09-25 20:54, Rob Herring wrote: > On Wed, Sep 19, 2018 at 05:13:12AM +0530, Vikash Garodia wrote: >> Add devicetree binding documentation for firmware loader for video >> hardware running on qualcomm chip. >> >> Signed-off-by: Vikash Garodia <vgarodia@codeaurora.org> >> --- >> Documentation/devicetree/bindings/media/qcom,venus.txt | 13 >> ++++++++++++- >> 1 file changed, 12 insertions(+), 1 deletion(-) > > Something change in this? If not, then please add acks/reviewed-bys > when > posting new versions. Same as the one reviewed by you earlier. Will add your review-by signature.
diff --git a/Documentation/devicetree/bindings/media/qcom,venus.txt b/Documentation/devicetree/bindings/media/qcom,venus.txt index 00d0d1b..7e04586 100644 --- a/Documentation/devicetree/bindings/media/qcom,venus.txt +++ b/Documentation/devicetree/bindings/media/qcom,venus.txt @@ -53,7 +53,7 @@ * Subnodes The Venus video-codec node must contain two subnodes representing -video-decoder and video-encoder. +video-decoder and video-encoder, and one optional firmware subnode. Every of video-encoder or video-decoder subnode should have: @@ -79,6 +79,13 @@ Every of video-encoder or video-decoder subnode should have: power domain which is responsible for collapsing and restoring power to the subcore. +The firmware subnode must have: + +- iommus: + Usage: required + Value type: <prop-encoded-array> + Definition: A list of phandle and IOMMU specifier pairs. + * An Example video-codec@1d00000 { compatible = "qcom,msm8916-venus"; @@ -105,4 +112,8 @@ Every of video-encoder or video-decoder subnode should have: clock-names = "core"; power-domains = <&mmcc VENUS_CORE1_GDSC>; }; + + video-firmware { + iommus = <&apps_iommu 0x10b2 0x0>; + }; };
Add devicetree binding documentation for firmware loader for video hardware running on qualcomm chip. Signed-off-by: Vikash Garodia <vgarodia@codeaurora.org> --- Documentation/devicetree/bindings/media/qcom,venus.txt | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-)