| Message ID | 20180920161423.13990-2-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | i2c: core: introduce master_xfer_irqless | expand |
On 2018-09-20 18:14, Wolfram Sang wrote: > The usefulness of this debug output is questionable. It covers only > direct i2c_transfer calls and no SMBUS calls, neither direct nor > emulated ones. And the latter one is largely used in the kernel, so a > lot of stuff is missed. Also, we have a proper tracing mechanism for all > these kinds of transfers in place for years now. Remove this old one. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> This old one fires before locking and even if locking fails for the atomic/irq case. You might want to mention that in the commit message? But I certainly agree with the usefulness statement... Acked-by: Peter Rosin <peda@axentia.se> > --- > drivers/i2c/i2c-core-base.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c > index 9ee9a15e7134..c2b352c46fae 100644 > --- a/drivers/i2c/i2c-core-base.c > +++ b/drivers/i2c/i2c-core-base.c > @@ -1940,16 +1940,6 @@ int i2c_transfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num) > */ > > if (adap->algo->master_xfer) { > -#ifdef DEBUG > - for (ret = 0; ret < num; ret++) { > - dev_dbg(&adap->dev, > - "master_xfer[%d] %c, addr=0x%02x, len=%d%s\n", > - ret, (msgs[ret].flags & I2C_M_RD) ? 'R' : 'W', > - msgs[ret].addr, msgs[ret].len, > - (msgs[ret].flags & I2C_M_RECV_LEN) ? "+" : ""); > - } > -#endif > - > if (in_atomic() || irqs_disabled()) { > ret = i2c_trylock_bus(adap, I2C_LOCK_SEGMENT); > if (!ret) >
On Thu, Sep 20, 2018 at 06:14:20PM +0200, Wolfram Sang wrote: > The usefulness of this debug output is questionable. It covers only > direct i2c_transfer calls and no SMBUS calls, neither direct nor > emulated ones. And the latter one is largely used in the kernel, so a > lot of stuff is missed. Also, we have a proper tracing mechanism for all > these kinds of transfers in place for years now. Remove this old one. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> I think we can have this clean up already. Applied to for-next (with updated commit message), thanks!
diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c index 9ee9a15e7134..c2b352c46fae 100644 --- a/drivers/i2c/i2c-core-base.c +++ b/drivers/i2c/i2c-core-base.c @@ -1940,16 +1940,6 @@ int i2c_transfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num) */ if (adap->algo->master_xfer) { -#ifdef DEBUG - for (ret = 0; ret < num; ret++) { - dev_dbg(&adap->dev, - "master_xfer[%d] %c, addr=0x%02x, len=%d%s\n", - ret, (msgs[ret].flags & I2C_M_RD) ? 'R' : 'W', - msgs[ret].addr, msgs[ret].len, - (msgs[ret].flags & I2C_M_RECV_LEN) ? "+" : ""); - } -#endif - if (in_atomic() || irqs_disabled()) { ret = i2c_trylock_bus(adap, I2C_LOCK_SEGMENT); if (!ret)
The usefulness of this debug output is questionable. It covers only direct i2c_transfer calls and no SMBUS calls, neither direct nor emulated ones. And the latter one is largely used in the kernel, so a lot of stuff is missed. Also, we have a proper tracing mechanism for all these kinds of transfers in place for years now. Remove this old one. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- drivers/i2c/i2c-core-base.c | 10 ---------- 1 file changed, 10 deletions(-)