| Message ID | 20180920155834.8470-3-eric.engestrom@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [libdrm,1/3] intel: add missing drm_public exports | expand |
On 2018-09-20 5:58 p.m., Eric Engestrom wrote: > Fixes: 9f45264815eff6ebeba3 "radeon: annotate public functions" > Cc: Lucas De Marchi <lucas.demarchi@intel.com> > Cc: Mark Janes <mark.a.janes@intel.com> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108006 > Signed-off-by: Eric Engestrom <eric.engestrom@intel.com> > --- > radeon/radeon_bo.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/radeon/radeon_bo.c b/radeon/radeon_bo.c > index cd06c26ee152d68f893d..91929532d5bf6e0daca8 100644 > --- a/radeon/radeon_bo.c > +++ b/radeon/radeon_bo.c > @@ -67,13 +67,13 @@ drm_public struct radeon_bo *radeon_bo_unref(struct radeon_bo *bo) > return boi->bom->funcs->bo_unref(boi); > } > > -int radeon_bo_map(struct radeon_bo *bo, int write) > +drm_public int radeon_bo_map(struct radeon_bo *bo, int write) > { > struct radeon_bo_int *boi = (struct radeon_bo_int *)bo; > return boi->bom->funcs->bo_map(boi, write); > } > > -int radeon_bo_unmap(struct radeon_bo *bo) > +drm_public int radeon_bo_unmap(struct radeon_bo *bo) > { > struct radeon_bo_int *boi = (struct radeon_bo_int *)bo; > return boi->bom->funcs->bo_unmap(boi); > Reviewed-by: Michel Dänzer <michel.daenzer@amd.com> Tested-by: Michel Dänzer <michel.daenzer@amd.com> Thanks Eric!
On Thursday, 2018-09-20 18:09:41 +0200, Michel Dänzer wrote: > On 2018-09-20 5:58 p.m., Eric Engestrom wrote: > > Fixes: 9f45264815eff6ebeba3 "radeon: annotate public functions" > > Cc: Lucas De Marchi <lucas.demarchi@intel.com> > > Cc: Mark Janes <mark.a.janes@intel.com> > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108006 > > Signed-off-by: Eric Engestrom <eric.engestrom@intel.com> > > --- > > radeon/radeon_bo.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/radeon/radeon_bo.c b/radeon/radeon_bo.c > > index cd06c26ee152d68f893d..91929532d5bf6e0daca8 100644 > > --- a/radeon/radeon_bo.c > > +++ b/radeon/radeon_bo.c > > @@ -67,13 +67,13 @@ drm_public struct radeon_bo *radeon_bo_unref(struct radeon_bo *bo) > > return boi->bom->funcs->bo_unref(boi); > > } > > > > -int radeon_bo_map(struct radeon_bo *bo, int write) > > +drm_public int radeon_bo_map(struct radeon_bo *bo, int write) > > { > > struct radeon_bo_int *boi = (struct radeon_bo_int *)bo; > > return boi->bom->funcs->bo_map(boi, write); > > } > > > > -int radeon_bo_unmap(struct radeon_bo *bo) > > +drm_public int radeon_bo_unmap(struct radeon_bo *bo) > > { > > struct radeon_bo_int *boi = (struct radeon_bo_int *)bo; > > return boi->bom->funcs->bo_unmap(boi); > > > > Reviewed-by: Michel Dänzer <michel.daenzer@amd.com> > Tested-by: Michel Dänzer <michel.daenzer@amd.com> Thanks! radeon_cs_space_check was also missing, but my grep didn't catch it because radeon_cs_space_check_with_bo matched my weak grep skills... I added drm_public to it too, can I still apply your tags, or do you want a v2? ----8<---- diff --git a/radeon/radeon_cs_space.c b/radeon/radeon_cs_space.c index 08093300827e287f3c0d..039b0414af30c1967fb7 100644 --- a/radeon/radeon_cs_space.c +++ b/radeon/radeon_cs_space.c @@ -227,7 +227,7 @@ radeon_cs_space_check_with_bo(struct radeon_cs *cs, struct radeon_bo *bo, return ret; } -int radeon_cs_space_check(struct radeon_cs *cs) +drm_public int radeon_cs_space_check(struct radeon_cs *cs) { struct radeon_cs_int *csi = (struct radeon_cs_int *)cs; return radeon_cs_check_space_internal(csi, NULL); ---->8---- > > Thanks Eric! > > > -- > Earthling Michel Dänzer | http://www.amd.com > Libre software enthusiast | Mesa and X developer
On Thursday, 2018-09-20 18:21:41 +0100, Eric Engestrom wrote: > On Thursday, 2018-09-20 18:09:41 +0200, Michel Dänzer wrote: > > On 2018-09-20 5:58 p.m., Eric Engestrom wrote: > > > Fixes: 9f45264815eff6ebeba3 "radeon: annotate public functions" > > > Cc: Lucas De Marchi <lucas.demarchi@intel.com> > > > Cc: Mark Janes <mark.a.janes@intel.com> > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108006 > > > Signed-off-by: Eric Engestrom <eric.engestrom@intel.com> > > > --- > > > radeon/radeon_bo.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/radeon/radeon_bo.c b/radeon/radeon_bo.c > > > index cd06c26ee152d68f893d..91929532d5bf6e0daca8 100644 > > > --- a/radeon/radeon_bo.c > > > +++ b/radeon/radeon_bo.c > > > @@ -67,13 +67,13 @@ drm_public struct radeon_bo *radeon_bo_unref(struct radeon_bo *bo) > > > return boi->bom->funcs->bo_unref(boi); > > > } > > > > > > -int radeon_bo_map(struct radeon_bo *bo, int write) > > > +drm_public int radeon_bo_map(struct radeon_bo *bo, int write) > > > { > > > struct radeon_bo_int *boi = (struct radeon_bo_int *)bo; > > > return boi->bom->funcs->bo_map(boi, write); > > > } > > > > > > -int radeon_bo_unmap(struct radeon_bo *bo) > > > +drm_public int radeon_bo_unmap(struct radeon_bo *bo) > > > { > > > struct radeon_bo_int *boi = (struct radeon_bo_int *)bo; > > > return boi->bom->funcs->bo_unmap(boi); > > > > > > > Reviewed-by: Michel Dänzer <michel.daenzer@amd.com> > > Tested-by: Michel Dänzer <michel.daenzer@amd.com> > > Thanks! > > radeon_cs_space_check was also missing, but my grep didn't catch it > because radeon_cs_space_check_with_bo matched my weak grep skills... > > I added drm_public to it too, can I still apply your tags, or do you > want a v2? I ended up pushing it with your r-b and t-b, because I'm going home and would rather not have left it like that too long :) Thanks again! > > ----8<---- > diff --git a/radeon/radeon_cs_space.c b/radeon/radeon_cs_space.c > index 08093300827e287f3c0d..039b0414af30c1967fb7 100644 > --- a/radeon/radeon_cs_space.c > +++ b/radeon/radeon_cs_space.c > @@ -227,7 +227,7 @@ radeon_cs_space_check_with_bo(struct radeon_cs *cs, struct radeon_bo *bo, > return ret; > } > > -int radeon_cs_space_check(struct radeon_cs *cs) > +drm_public int radeon_cs_space_check(struct radeon_cs *cs) > { > struct radeon_cs_int *csi = (struct radeon_cs_int *)cs; > return radeon_cs_check_space_internal(csi, NULL); > ---->8---- > > > > > Thanks Eric! > > > > > > -- > > Earthling Michel Dänzer | http://www.amd.com > > Libre software enthusiast | Mesa and X developer
On 2018-09-20 8:31 p.m., Eric Engestrom wrote: > On Thursday, 2018-09-20 18:21:41 +0100, Eric Engestrom wrote: >> On Thursday, 2018-09-20 18:09:41 +0200, Michel Dänzer wrote: >>> On 2018-09-20 5:58 p.m., Eric Engestrom wrote: >>>> Fixes: 9f45264815eff6ebeba3 "radeon: annotate public functions" >>>> Cc: Lucas De Marchi <lucas.demarchi@intel.com> >>>> Cc: Mark Janes <mark.a.janes@intel.com> >>>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108006 >>>> Signed-off-by: Eric Engestrom <eric.engestrom@intel.com> >>>> --- >>>> radeon/radeon_bo.c | 4 ++-- >>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/radeon/radeon_bo.c b/radeon/radeon_bo.c >>>> index cd06c26ee152d68f893d..91929532d5bf6e0daca8 100644 >>>> --- a/radeon/radeon_bo.c >>>> +++ b/radeon/radeon_bo.c >>>> @@ -67,13 +67,13 @@ drm_public struct radeon_bo *radeon_bo_unref(struct radeon_bo *bo) >>>> return boi->bom->funcs->bo_unref(boi); >>>> } >>>> >>>> -int radeon_bo_map(struct radeon_bo *bo, int write) >>>> +drm_public int radeon_bo_map(struct radeon_bo *bo, int write) >>>> { >>>> struct radeon_bo_int *boi = (struct radeon_bo_int *)bo; >>>> return boi->bom->funcs->bo_map(boi, write); >>>> } >>>> >>>> -int radeon_bo_unmap(struct radeon_bo *bo) >>>> +drm_public int radeon_bo_unmap(struct radeon_bo *bo) >>>> { >>>> struct radeon_bo_int *boi = (struct radeon_bo_int *)bo; >>>> return boi->bom->funcs->bo_unmap(boi); >>>> >>> >>> Reviewed-by: Michel Dänzer <michel.daenzer@amd.com> >>> Tested-by: Michel Dänzer <michel.daenzer@amd.com> >> >> Thanks! >> >> radeon_cs_space_check was also missing, but my grep didn't catch it >> because radeon_cs_space_check_with_bo matched my weak grep skills... >> >> I added drm_public to it too, can I still apply your tags, or do you >> want a v2? > > I ended up pushing it with your r-b and t-b, because I'm going home and > would rather not have left it like that too long :) Good catch and good call, thanks again.
diff --git a/radeon/radeon_bo.c b/radeon/radeon_bo.c index cd06c26ee152d68f893d..91929532d5bf6e0daca8 100644 --- a/radeon/radeon_bo.c +++ b/radeon/radeon_bo.c @@ -67,13 +67,13 @@ drm_public struct radeon_bo *radeon_bo_unref(struct radeon_bo *bo) return boi->bom->funcs->bo_unref(boi); } -int radeon_bo_map(struct radeon_bo *bo, int write) +drm_public int radeon_bo_map(struct radeon_bo *bo, int write) { struct radeon_bo_int *boi = (struct radeon_bo_int *)bo; return boi->bom->funcs->bo_map(boi, write); } -int radeon_bo_unmap(struct radeon_bo *bo) +drm_public int radeon_bo_unmap(struct radeon_bo *bo) { struct radeon_bo_int *boi = (struct radeon_bo_int *)bo; return boi->bom->funcs->bo_unmap(boi);
Fixes: 9f45264815eff6ebeba3 "radeon: annotate public functions" Cc: Lucas De Marchi <lucas.demarchi@intel.com> Cc: Mark Janes <mark.a.janes@intel.com> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108006 Signed-off-by: Eric Engestrom <eric.engestrom@intel.com> --- radeon/radeon_bo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)