| Message ID | 20180926115525.24500-1-tzimmermann@suse.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [RESEND] drm/shmobile: Replace drm_dev_unref with drm_dev_put | expand |
Hi Thomas, Thank you for the patch, On 26/09/18 12:55, Thomas Zimmermann wrote: > This patch unifies the naming of DRM functions for reference counting > of struct drm_device. The resulting code is more aligned with the rest > of the Linux kernel interfaces. > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > Reviewed-by: Simon Horman <horms+renesas@verge.net.au> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > --- > drivers/gpu/drm/shmobile/shmob_drm_drv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/shmobile/shmob_drm_drv.c b/drivers/gpu/drm/shmobile/shmob_drm_drv.c > index 6ececad6f845..8554102a6ead 100644 > --- a/drivers/gpu/drm/shmobile/shmob_drm_drv.c > +++ b/drivers/gpu/drm/shmobile/shmob_drm_drv.c > @@ -194,7 +194,7 @@ static int shmob_drm_remove(struct platform_device *pdev) > drm_kms_helper_poll_fini(ddev); > drm_mode_config_cleanup(ddev); > drm_irq_uninstall(ddev); > - drm_dev_unref(ddev); > + drm_dev_put(ddev); > > return 0; > } > @@ -290,7 +290,7 @@ static int shmob_drm_probe(struct platform_device *pdev) > drm_kms_helper_poll_fini(ddev); > drm_mode_config_cleanup(ddev); > err_free_drm_dev: > - drm_dev_unref(ddev); > + drm_dev_put(ddev); > > return ret; > } > -- > 2.19.0 >
Hi, thanks for reviewing the patch and the one for rcar-du. Please also add them to your tree. Best regards Thomas Am 26.09.18 um 14:14 schrieb Kieran Bingham: > Hi Thomas, > > Thank you for the patch, > > On 26/09/18 12:55, Thomas Zimmermann wrote: >> This patch unifies the naming of DRM functions for reference counting >> of struct drm_device. The resulting code is more aligned with the rest >> of the Linux kernel interfaces. >> >> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> >> Reviewed-by: Simon Horman <horms+renesas@verge.net.au> > > Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > >> --- >> drivers/gpu/drm/shmobile/shmob_drm_drv.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/shmobile/shmob_drm_drv.c b/drivers/gpu/drm/shmobile/shmob_drm_drv.c >> index 6ececad6f845..8554102a6ead 100644 >> --- a/drivers/gpu/drm/shmobile/shmob_drm_drv.c >> +++ b/drivers/gpu/drm/shmobile/shmob_drm_drv.c >> @@ -194,7 +194,7 @@ static int shmob_drm_remove(struct platform_device *pdev) >> drm_kms_helper_poll_fini(ddev); >> drm_mode_config_cleanup(ddev); >> drm_irq_uninstall(ddev); >> - drm_dev_unref(ddev); >> + drm_dev_put(ddev); >> >> return 0; >> } >> @@ -290,7 +290,7 @@ static int shmob_drm_probe(struct platform_device *pdev) >> drm_kms_helper_poll_fini(ddev); >> drm_mode_config_cleanup(ddev); >> err_free_drm_dev: >> - drm_dev_unref(ddev); >> + drm_dev_put(ddev); >> >> return ret; >> } >> -- >> 2.19.0 >> > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel >
Hi Thomas, On Wednesday, 26 September 2018 15:26:38 EEST Thomas Zimmermann wrote: > Hi, > > thanks for reviewing the patch and the one for rcar-du. Please also add > them to your tree. I took both patches in my tree. Thank you. > Am 26.09.18 um 14:14 schrieb Kieran Bingham: > > On 26/09/18 12:55, Thomas Zimmermann wrote: > >> This patch unifies the naming of DRM functions for reference counting > >> of struct drm_device. The resulting code is more aligned with the rest > >> of the Linux kernel interfaces. > >> > >> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > >> Reviewed-by: Simon Horman <horms+renesas@verge.net.au> > > > > Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > > > >> --- > >> > >> drivers/gpu/drm/shmobile/shmob_drm_drv.c | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/drivers/gpu/drm/shmobile/shmob_drm_drv.c > >> b/drivers/gpu/drm/shmobile/shmob_drm_drv.c index > >> 6ececad6f845..8554102a6ead 100644 > >> --- a/drivers/gpu/drm/shmobile/shmob_drm_drv.c > >> +++ b/drivers/gpu/drm/shmobile/shmob_drm_drv.c > >> @@ -194,7 +194,7 @@ static int shmob_drm_remove(struct platform_device > >> *pdev) > >> drm_kms_helper_poll_fini(ddev); > >> drm_mode_config_cleanup(ddev); > >> drm_irq_uninstall(ddev); > >> - drm_dev_unref(ddev); > >> + drm_dev_put(ddev); > >> > >> return 0; > >> } > >> > >> @@ -290,7 +290,7 @@ static int shmob_drm_probe(struct platform_device > >> *pdev) > >> drm_kms_helper_poll_fini(ddev); > >> drm_mode_config_cleanup(ddev); > >> > >> err_free_drm_dev: > >> - drm_dev_unref(ddev); > >> + drm_dev_put(ddev); > >> return ret; > >> } > >>
diff --git a/drivers/gpu/drm/shmobile/shmob_drm_drv.c b/drivers/gpu/drm/shmobile/shmob_drm_drv.c index 6ececad6f845..8554102a6ead 100644 --- a/drivers/gpu/drm/shmobile/shmob_drm_drv.c +++ b/drivers/gpu/drm/shmobile/shmob_drm_drv.c @@ -194,7 +194,7 @@ static int shmob_drm_remove(struct platform_device *pdev) drm_kms_helper_poll_fini(ddev); drm_mode_config_cleanup(ddev); drm_irq_uninstall(ddev); - drm_dev_unref(ddev); + drm_dev_put(ddev); return 0; } @@ -290,7 +290,7 @@ static int shmob_drm_probe(struct platform_device *pdev) drm_kms_helper_poll_fini(ddev); drm_mode_config_cleanup(ddev); err_free_drm_dev: - drm_dev_unref(ddev); + drm_dev_put(ddev); return ret; }