| Message ID | 20180926214006.28486-1-niklas.soderlund+renesas@ragnatech.se (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | rcar-vin: fix redeclaration of symbol | expand |
Hi Niklas, On Wed, Sep 26, 2018 at 11:40:06PM +0200, Niklas Söderlund wrote: > When adding support for parallel subdev for Gen3 it was missed that the > symbol 'i' in rvin_group_link_notify() was already declare, remove the > dupe as it's only used as a loop variable this have no functional > change. This fixes warning: > > rcar-core.c:117:52: originally declared here > rcar-core.c:173:30: warning: symbol 'i' shadows an earlier one > > Fixes: 1284605dc821cebd ("media: rcar-vin: Handle parallel subdev in link_notify") > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Acked-by: Jacopo Mondi <jacopo+renesas@jmondi.org> Thanks j > --- > drivers/media/platform/rcar-vin/rcar-core.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/media/platform/rcar-vin/rcar-core.c b/drivers/media/platform/rcar-vin/rcar-core.c > index 5dd16af3625c333b..01e418c2d4c6792e 100644 > --- a/drivers/media/platform/rcar-vin/rcar-core.c > +++ b/drivers/media/platform/rcar-vin/rcar-core.c > @@ -170,7 +170,6 @@ static int rvin_group_link_notify(struct media_link *link, u32 flags, > > if (csi_id == -ENODEV) { > struct v4l2_subdev *sd; > - unsigned int i; > > /* > * Make sure the source entity subdevice is registered as > -- > 2.19.0 >
diff --git a/drivers/media/platform/rcar-vin/rcar-core.c b/drivers/media/platform/rcar-vin/rcar-core.c index 5dd16af3625c333b..01e418c2d4c6792e 100644 --- a/drivers/media/platform/rcar-vin/rcar-core.c +++ b/drivers/media/platform/rcar-vin/rcar-core.c @@ -170,7 +170,6 @@ static int rvin_group_link_notify(struct media_link *link, u32 flags, if (csi_id == -ENODEV) { struct v4l2_subdev *sd; - unsigned int i; /* * Make sure the source entity subdevice is registered as
When adding support for parallel subdev for Gen3 it was missed that the symbol 'i' in rvin_group_link_notify() was already declare, remove the dupe as it's only used as a loop variable this have no functional change. This fixes warning: rcar-core.c:117:52: originally declared here rcar-core.c:173:30: warning: symbol 'i' shadows an earlier one Fixes: 1284605dc821cebd ("media: rcar-vin: Handle parallel subdev in link_notify") Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> --- drivers/media/platform/rcar-vin/rcar-core.c | 1 - 1 file changed, 1 deletion(-)