| Message ID | 1538818996-11772-1-git-send-email-govinds@codeaurora.org (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Andy Gross |
| Headers | show |
| Series | firmware: qcom: scm: Add qcs404 soc compatible | expand |
On Sat 06 Oct 02:43 PDT 2018, Govind Singh wrote: > Add compatible string for QCS404. Don't populate > driver data as QCS404 does not need clocks for scm calls. > > Signed-off-by: Govind Singh <govinds@codeaurora.org> Hi Govind, Please use compatible = "qcom,scm-qcs404", "qcom,scm"; and the driver will match the latter. This way we don't need to update the driver with every platform, but if we in the future realize that qcs404 did need some special treatment we can go back and add the specific compatible. Regards, Bjorn > --- > drivers/firmware/qcom_scm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c > index 5ef146a..dda0908 100644 > --- a/drivers/firmware/qcom_scm.c > +++ b/drivers/firmware/qcom_scm.c > @@ -623,6 +623,7 @@ static void qcom_scm_shutdown(struct platform_device *pdev) > SCM_HAS_BUS_CLK) > }, > { .compatible = "qcom,scm-msm8996" }, > + { .compatible = "qcom,scm-qcs404" }, > { .compatible = "qcom,scm" }, > {} > }; > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >
diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c index 5ef146a..dda0908 100644 --- a/drivers/firmware/qcom_scm.c +++ b/drivers/firmware/qcom_scm.c @@ -623,6 +623,7 @@ static void qcom_scm_shutdown(struct platform_device *pdev) SCM_HAS_BUS_CLK) }, { .compatible = "qcom,scm-msm8996" }, + { .compatible = "qcom,scm-qcs404" }, { .compatible = "qcom,scm" }, {} };
Add compatible string for QCS404. Don't populate driver data as QCS404 does not need clocks for scm calls. Signed-off-by: Govind Singh <govinds@codeaurora.org> --- drivers/firmware/qcom_scm.c | 1 + 1 file changed, 1 insertion(+)