Message ID | 0102016657e7d068-16e15ab5-335e-4a2a-8bbb-bf2242514ad2-000000@eu-west-1.amazonses.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | ref-filter: reduce memory leaks | expand |
Olga Telezhnaya <olyatelezhnaya@gmail.com> writes: > Use ref_array_clear() to release memory instead of UNLEAK macros. > > Signed-off-by: Olga Telezhnaia <olyatelezhnaya@gmail.com> > --- > builtin/ls-remote.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) OK, this is immediately before the command exits, and we have a way to clear and release the resource, so it is obvious we should use it. Good. > > diff --git a/builtin/ls-remote.c b/builtin/ls-remote.c > index 1a25df7ee15b4..6a0cdec30d2d7 100644 > --- a/builtin/ls-remote.c > +++ b/builtin/ls-remote.c > @@ -151,6 +151,6 @@ int cmd_ls_remote(int argc, const char **argv, const char *prefix) > } > > UNLEAK(sorting); > - UNLEAK(ref_array); > + ref_array_clear(&ref_array); > return status; > } > > -- > https://github.com/git/git/pull/538
diff --git a/builtin/ls-remote.c b/builtin/ls-remote.c index 1a25df7ee15b4..6a0cdec30d2d7 100644 --- a/builtin/ls-remote.c +++ b/builtin/ls-remote.c @@ -151,6 +151,6 @@ int cmd_ls_remote(int argc, const char **argv, const char *prefix) } UNLEAK(sorting); - UNLEAK(ref_array); + ref_array_clear(&ref_array); return status; }
Use ref_array_clear() to release memory instead of UNLEAK macros. Signed-off-by: Olga Telezhnaia <olyatelezhnaya@gmail.com> --- builtin/ls-remote.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- https://github.com/git/git/pull/538