mbox series

[0/7] Neaten logging uses

Message ID cover.1537183087.git.joe@perches.com (mailing list archive)
Headers show
Series Neaten logging uses | expand

Message

Joe Perches Sept. 17, 2018, 3:01 p.m. UTC
Several defects exist in the logging uses

o Missing KERN_<LEVEL>
o Unnecessary KERN_<LEVEL> uses with panic
o Mismatched MPT3SAS_FMT and %s: with name and __func__

Correct these defects and perhaps add some clarity to the logging.

Joe Perches (7):
  mpt3sas: Add ioc_<level> logging macros
  mpt3sas: Convert uses of pr_<level> with MPT3SAS_FMT to ioc_<level>
  mpt3sas: Convert mlsleading uses of pr_<level> with MPT3SAS_FMT
  mpt3sas: Convert logging uses with MPT3SAS_FMT and reply_q_name to %s:
  mpt3sas: Remove KERN_WARNING from panic uses
  mpt3sas: Convert logging uses with MPT3SAS_FMT without logging levels
  mpt3sas: Remove unused macro MPT3SAS_FMT

 drivers/scsi/mpt3sas/mpt3sas_base.c         | 1116 +++++++++-----------
 drivers/scsi/mpt3sas/mpt3sas_base.h         |    9 +-
 drivers/scsi/mpt3sas/mpt3sas_config.c       |   89 +-
 drivers/scsi/mpt3sas/mpt3sas_ctl.c          |  493 ++++-----
 drivers/scsi/mpt3sas/mpt3sas_scsih.c        | 1487 ++++++++++++---------------
 drivers/scsi/mpt3sas/mpt3sas_transport.c    |  337 +++---
 drivers/scsi/mpt3sas/mpt3sas_trigger_diag.c |  101 +-
 drivers/scsi/mpt3sas/mpt3sas_warpdrive.c    |   70 +-
 8 files changed, 1618 insertions(+), 2084 deletions(-)

Comments

Joe Perches Oct. 1, 2018, 11:46 p.m. UTC | #1
On Mon, 2018-09-17 at 08:01 -0700, Joe Perches wrote:
> Several defects exist in the logging uses
> 
> o Missing KERN_<LEVEL>
> o Unnecessary KERN_<LEVEL> uses with panic
> o Mismatched MPT3SAS_FMT and %s: with name and __func__
> 
> Correct these defects and perhaps add some clarity to the logging.

Submitted 2 weeks ago now without comment.

ping...

> Joe Perches (7):
>   mpt3sas: Add ioc_<level> logging macros
>   mpt3sas: Convert uses of pr_<level> with MPT3SAS_FMT to ioc_<level>
>   mpt3sas: Convert mlsleading uses of pr_<level> with MPT3SAS_FMT
>   mpt3sas: Convert logging uses with MPT3SAS_FMT and reply_q_name to %s:
>   mpt3sas: Remove KERN_WARNING from panic uses
>   mpt3sas: Convert logging uses with MPT3SAS_FMT without logging levels
>   mpt3sas: Remove unused macro MPT3SAS_FMT
> 
>  drivers/scsi/mpt3sas/mpt3sas_base.c         | 1116 +++++++++-----------
>  drivers/scsi/mpt3sas/mpt3sas_base.h         |    9 +-
>  drivers/scsi/mpt3sas/mpt3sas_config.c       |   89 +-
>  drivers/scsi/mpt3sas/mpt3sas_ctl.c          |  493 ++++-----
>  drivers/scsi/mpt3sas/mpt3sas_scsih.c        | 1487 ++++++++++++---------------
>  drivers/scsi/mpt3sas/mpt3sas_transport.c    |  337 +++---
>  drivers/scsi/mpt3sas/mpt3sas_trigger_diag.c |  101 +-
>  drivers/scsi/mpt3sas/mpt3sas_warpdrive.c    |   70 +-
>  8 files changed, 1618 insertions(+), 2084 deletions(-)
>
Martin K. Petersen Oct. 11, 2018, 1:54 a.m. UTC | #2
Joe,

> Several defects exist in the logging uses
>
> o Missing KERN_<LEVEL>
> o Unnecessary KERN_<LEVEL> uses with panic
> o Mismatched MPT3SAS_FMT and %s: with name and __func__
>
> Correct these defects and perhaps add some clarity to the logging.

Applied to 4.20/scsi-queue, thanks!
Joe Perches Oct. 11, 2018, 3:37 p.m. UTC | #3
On Wed, 2018-10-10 at 21:54 -0400, Martin K. Petersen wrote:
> Joe,
> 
> > Several defects exist in the logging uses
> > 
> > o Missing KERN_<LEVEL>
> > o Unnecessary KERN_<LEVEL> uses with panic
> > o Mismatched MPT3SAS_FMT and %s: with name and __func__
> > 
> > Correct these defects and perhaps add some clarity to the logging.
> 
> Applied to 4.20/scsi-queue, thanks!

Is this branch also applied to Stephen Rothwell's -next?
Martin K. Petersen Oct. 11, 2018, 11:25 p.m. UTC | #4
Joe,

>> Applied to 4.20/scsi-queue, thanks!
>
> Is this branch also applied to Stephen Rothwell's -next?

Yes.
Joe Perches Oct. 12, 2018, 12:01 a.m. UTC | #5
On Thu, 2018-10-11 at 19:25 -0400, Martin K. Petersen wrote:
> Joe,
> 
> > > Applied to 4.20/scsi-queue, thanks!
> > 
> > Is this branch also applied to Stephen Rothwell's -next?
> 
> Yes.

Via what tree?  It doesn't seem directly pulled.
Martin K. Petersen Oct. 12, 2018, 12:41 a.m. UTC | #6
Joe,

> Via what tree?  It doesn't seem directly pulled.

Stephen pulls both my for-next and my fixes branches.