| Message ID | 96781d46e41fa6ffc04b88527a25d73f5a59eda8.1311936524.git.viresh.kumar@st.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Jul 29, 2011 at 04:19:17PM +0530, Viresh Kumar wrote: > Amba devices have interface clocks attached as adev->pclk. This is the only > clock associated with DMAC and it can be disabled when DMAC is not in use. This > patch adds support to enable/disable this clk as and when channels are requested > and freed. Also it disables this clock at the end of probe. It may make better sense to convert this to runtime PM. I suspect that there's core support which the amba/bus.c can do to help in that respect (eg, managing the apb pclk itself) so that we don't have to add the same code to every primecell driver.
diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c index 53d722e..f1a25cf 100644 --- a/drivers/dma/amba-pl08x.c +++ b/drivers/dma/amba-pl08x.c @@ -881,11 +881,19 @@ static void pl08x_free_txd_list(struct pl08x_driver_data *pl08x, */ static int pl08x_alloc_chan_resources(struct dma_chan *chan) { + struct pl08x_dma_chan *plchan = to_pl08x_chan(chan); + struct pl08x_driver_data *pl08x = plchan->host; + + amba_pclk_enable(pl08x->adev); return 0; } static void pl08x_free_chan_resources(struct dma_chan *chan) { + struct pl08x_dma_chan *plchan = to_pl08x_chan(chan); + struct pl08x_driver_data *pl08x = plchan->host; + + amba_pclk_disable(pl08x->adev); } /* @@ -1993,6 +2001,8 @@ static int pl08x_probe(struct amba_device *adev, const struct amba_id *id) dev_info(&pl08x->adev->dev, "DMA: PL%03x rev%u at 0x%08llx irq %d\n", amba_part(adev), amba_rev(adev), (unsigned long long)adev->res.start, adev->irq[0]); + + amba_pclk_disable(adev); return 0; out_no_slave_reg:
Amba devices have interface clocks attached as adev->pclk. This is the only clock associated with DMAC and it can be disabled when DMAC is not in use. This patch adds support to enable/disable this clk as and when channels are requested and freed. Also it disables this clock at the end of probe. Signed-off-by: Viresh Kumar <viresh.kumar@st.com> --- drivers/dma/amba-pl08x.c | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-)