| Message ID | 20181013151707.32210-6-hch@lst.de (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/8] cpufreq: tegra186: don't pass GFP_DMA32 to dma_alloc_coherent | expand |
On Sat, 13 Oct 2018 17:17:04 +0200, Christoph Hellwig wrote: > > The DMA API does its own zone decisions based on the coherent_dma_mask. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Takashi Iwai <tiwai@suse.de> thanks, Takashi > --- > sound/soc/intel/common/sst-firmware.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/intel/common/sst-firmware.c b/sound/soc/intel/common/sst-firmware.c > index 11041aedea31..1e067504b604 100644 > --- a/sound/soc/intel/common/sst-firmware.c > +++ b/sound/soc/intel/common/sst-firmware.c > @@ -355,7 +355,7 @@ struct sst_fw *sst_fw_new(struct sst_dsp *dsp, > > /* allocate DMA buffer to store FW data */ > sst_fw->dma_buf = dma_alloc_coherent(dsp->dma_dev, sst_fw->size, > - &sst_fw->dmable_fw_paddr, GFP_DMA | GFP_KERNEL); > + &sst_fw->dmable_fw_paddr, GFP_KERNEL); > if (!sst_fw->dma_buf) { > dev_err(dsp->dev, "error: DMA alloc failed\n"); > kfree(sst_fw); > -- > 2.19.1 > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel >
[ Dropping other MLs ] On Sat, 13 Oct 2018 18:20:35 +0200, Takashi Iwai wrote: > > On Sat, 13 Oct 2018 17:17:04 +0200, > Christoph Hellwig wrote: > > > > The DMA API does its own zone decisions based on the coherent_dma_mask. > > > > Signed-off-by: Christoph Hellwig <hch@lst.de> > > Reviewed-by: Takashi Iwai <tiwai@suse.de> Mark, let me know whether you'd take this via your tree or may I take via mine (with a minor correction of the subject line). FWIW, the driver sets the 31bit (!) DMA mask, and that's the likely reason of GFP_DMA passed there in the original code. thanks, Takashi > > > thanks, > > Takashi > > > --- > > sound/soc/intel/common/sst-firmware.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/sound/soc/intel/common/sst-firmware.c b/sound/soc/intel/common/sst-firmware.c > > index 11041aedea31..1e067504b604 100644 > > --- a/sound/soc/intel/common/sst-firmware.c > > +++ b/sound/soc/intel/common/sst-firmware.c > > @@ -355,7 +355,7 @@ struct sst_fw *sst_fw_new(struct sst_dsp *dsp, > > > > /* allocate DMA buffer to store FW data */ > > sst_fw->dma_buf = dma_alloc_coherent(dsp->dma_dev, sst_fw->size, > > - &sst_fw->dmable_fw_paddr, GFP_DMA | GFP_KERNEL); > > + &sst_fw->dmable_fw_paddr, GFP_KERNEL); > > if (!sst_fw->dma_buf) { > > dev_err(dsp->dev, "error: DMA alloc failed\n"); > > kfree(sst_fw); > > -- > > 2.19.1 > > > > _______________________________________________ > > Alsa-devel mailing list > > Alsa-devel@alsa-project.org > > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel > > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel >
On Sun, Oct 14, 2018 at 09:46:44AM +0200, Takashi Iwai wrote: > Takashi Iwai wrote: > > Christoph Hellwig wrote: > > > The DMA API does its own zone decisions based on the coherent_dma_mask. > > > Signed-off-by: Christoph Hellwig <hch@lst.de> > > Reviewed-by: Takashi Iwai <tiwai@suse.de> > Mark, let me know whether you'd take this via your tree or may I take > via mine (with a minor correction of the subject line). I don't have the patch... in fact, having found it in list archives I see there's also a SPI patch I'll have to go hunting for so I guess I'll apply this one when I find that :( Christoph, please CC maintainers. > FWIW, the driver sets the 31bit (!) DMA mask, and that's the likely > reason of GFP_DMA passed there in the original code. Likely, yes.
On Mon, Oct 15, 2018 at 10:58:58AM +0100, Mark Brown wrote: > On Sun, Oct 14, 2018 at 09:46:44AM +0200, Takashi Iwai wrote: > > Takashi Iwai wrote: > > > Christoph Hellwig wrote: > > > > > The DMA API does its own zone decisions based on the coherent_dma_mask. > > > > > Signed-off-by: Christoph Hellwig <hch@lst.de> > > > > Reviewed-by: Takashi Iwai <tiwai@suse.de> > > > Mark, let me know whether you'd take this via your tree or may I take > > via mine (with a minor correction of the subject line). > > I don't have the patch... in fact, having found it in list archives I > see there's also a SPI patch I'll have to go hunting for so I guess I'll > apply this one when I find that :( Christoph, please CC maintainers. I tend to only add the list as there just are way too many maintainers for this sorts of series, and maintainers should read their list anyway.
On Wed, Oct 17, 2018 at 09:19:00AM +0200, Christoph Hellwig wrote: > On Mon, Oct 15, 2018 at 10:58:58AM +0100, Mark Brown wrote: > > I don't have the patch... in fact, having found it in list archives I > > see there's also a SPI patch I'll have to go hunting for so I guess I'll > > apply this one when I find that :( Christoph, please CC maintainers. > I tend to only add the list as there just are way too many maintainers > for this sorts of series, and maintainers should read their list anyway. For several of my subsystems that list is lkml, good luck reliably getting anything noticed by a specific person by simply posting there! Even with ASoC alsa-devel is also used by the general ALSA stuff so there's a lot of noise, especially for things without the ASoC prefix. I do trawl the lists but it's at best going to be delayed, especially during busier periods. The usual thing for things like this is to send individual patches to specific maintainers (git send-email does the right thing with Cc: in the commit body).
diff --git a/sound/soc/intel/common/sst-firmware.c b/sound/soc/intel/common/sst-firmware.c index 11041aedea31..1e067504b604 100644 --- a/sound/soc/intel/common/sst-firmware.c +++ b/sound/soc/intel/common/sst-firmware.c @@ -355,7 +355,7 @@ struct sst_fw *sst_fw_new(struct sst_dsp *dsp, /* allocate DMA buffer to store FW data */ sst_fw->dma_buf = dma_alloc_coherent(dsp->dma_dev, sst_fw->size, - &sst_fw->dmable_fw_paddr, GFP_DMA | GFP_KERNEL); + &sst_fw->dmable_fw_paddr, GFP_KERNEL); if (!sst_fw->dma_buf) { dev_err(dsp->dev, "error: DMA alloc failed\n"); kfree(sst_fw);
The DMA API does its own zone decisions based on the coherent_dma_mask. Signed-off-by: Christoph Hellwig <hch@lst.de> --- sound/soc/intel/common/sst-firmware.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)