| Message ID | 20181017170554.18841-3-bigeasy@linutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Let sparse check for shadowed variables | expand |
On Wed, Oct 17, 2018 at 07:05:53PM +0200, Sebastian Andrzej Siewior wrote: > Commit 5de97c9f6d85f ("x86/mce: Factor out and deprecate the /dev/mcelog > driver") moved the old interface into one file including mce_helper > definition as static and "extern". > > Cc: Tony Luck <tony.luck@intel.com> > Cc: Borislav Petkov <bp@suse.de> > Cc: linux-edac <linux-edac@vger.kernel.org> > Cc: x86@kernel.org > Fixes: 5de97c9f6d85f ("x86/mce: Factor out and deprecate the /dev/mcelog driver") I'm not sure about the Fixes: tag - it'll trigger a flood of backporting for no reason AFAICT.
On Wed, 17 Oct 2018, Borislav Petkov wrote: > On Wed, Oct 17, 2018 at 07:05:53PM +0200, Sebastian Andrzej Siewior wrote: > > Commit 5de97c9f6d85f ("x86/mce: Factor out and deprecate the /dev/mcelog > > driver") moved the old interface into one file including mce_helper > > definition as static and "extern". > > > > Cc: Tony Luck <tony.luck@intel.com> > > Cc: Borislav Petkov <bp@suse.de> > > Cc: linux-edac <linux-edac@vger.kernel.org> > > Cc: x86@kernel.org > > Fixes: 5de97c9f6d85f ("x86/mce: Factor out and deprecate the /dev/mcelog driver") > > I'm not sure about the Fixes: tag - it'll trigger a flood of backporting > for no reason AFAICT. Not when there is no Cc: stable. If the stable folks pick up stuff nevertheless, shrug. The fixes tag is interesting even for stuff which does not go into stable because you can extract it properly and look at relations between original commit and fix. Thanks, tglx
diff --git a/arch/x86/kernel/cpu/mcheck/dev-mcelog.c b/arch/x86/kernel/cpu/mcheck/dev-mcelog.c index 97685a0c31751..27f394ac983f6 100644 --- a/arch/x86/kernel/cpu/mcheck/dev-mcelog.c +++ b/arch/x86/kernel/cpu/mcheck/dev-mcelog.c @@ -38,9 +38,6 @@ static struct mce_log_buffer mcelog = { static DECLARE_WAIT_QUEUE_HEAD(mce_chrdev_wait); -/* User mode helper program triggered by machine check event */ -extern char mce_helper[128]; - static int dev_mce_log(struct notifier_block *nb, unsigned long val, void *data) {
Commit 5de97c9f6d85f ("x86/mce: Factor out and deprecate the /dev/mcelog driver") moved the old interface into one file including mce_helper definition as static and "extern". Cc: Tony Luck <tony.luck@intel.com> Cc: Borislav Petkov <bp@suse.de> Cc: linux-edac <linux-edac@vger.kernel.org> Cc: x86@kernel.org Fixes: 5de97c9f6d85f ("x86/mce: Factor out and deprecate the /dev/mcelog driver") Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> --- arch/x86/kernel/cpu/mcheck/dev-mcelog.c | 3 --- 1 file changed, 3 deletions(-)