| Message ID | 20181023083356.17579-1-xiaoning.wang@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM: dts: fix imx7d boot spi dma setup error | expand |
On Tue, Oct 23, 2018 at 08:36:17AM +0000, Clark Wang wrote: > Add dmas and dma-names for ecspi1~4 to fix kernel boot error: > "spi_imx 30840000.ecspi: dma setup error -19, use pio". Actually this should not be an error and the message is supposed to say: Unable to setup DMA, falling back to PIO So IMHO this should be downgraded from dev_err to dev_info and reworded. Maybe even try DMA-setup on devices where it is known to fail and don't emit a message on -ENODEV at all. Best regards Uwe
diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi index aa8df7d93b2e..043e39124c43 100644 --- a/arch/arm/boot/dts/imx7s.dtsi +++ b/arch/arm/boot/dts/imx7s.dtsi @@ -651,6 +651,8 @@ clocks = <&clks IMX7D_ECSPI4_ROOT_CLK>, <&clks IMX7D_ECSPI4_ROOT_CLK>; clock-names = "ipg", "per"; + dmas = <&sdma 6 7 1>, <&sdma 7 7 2>; + dma-names = "rx", "tx"; status = "disabled"; }; @@ -732,6 +734,8 @@ clocks = <&clks IMX7D_ECSPI1_ROOT_CLK>, <&clks IMX7D_ECSPI1_ROOT_CLK>; clock-names = "ipg", "per"; + dmas = <&sdma 0 7 1>, <&sdma 1 7 2>; + dma-names = "rx", "tx"; status = "disabled"; }; @@ -744,6 +748,8 @@ clocks = <&clks IMX7D_ECSPI2_ROOT_CLK>, <&clks IMX7D_ECSPI2_ROOT_CLK>; clock-names = "ipg", "per"; + dmas = <&sdma 2 7 1>, <&sdma 3 7 2>; + dma-names = "rx", "tx"; status = "disabled"; }; @@ -756,6 +762,8 @@ clocks = <&clks IMX7D_ECSPI3_ROOT_CLK>, <&clks IMX7D_ECSPI3_ROOT_CLK>; clock-names = "ipg", "per"; + dmas = <&sdma 4 7 1>, <&sdma 5 7 2>; + dma-names = "rx", "tx"; status = "disabled"; };
Add dmas and dma-names for ecspi1~4 to fix kernel boot error: "spi_imx 30840000.ecspi: dma setup error -19, use pio". Signed-off-by: Xiaoning Wang <xiaoning.wang@nxp.com> --- arch/arm/boot/dts/imx7s.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+)