| Message ID | 20181025011116.12360-1-andre.guedes@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Introduce AVTP Audio Format (AAF) plugin | expand |
Dne 25.10.2018 v 03:11 Andre Guedes napsal(a): > Hi all, > > This new version addresses the feedback from v1 and fixes a bug on capture > mode. Code-wise, the changes are very trivial, no major diffs. Below follows > the highlights: > > * Standard headers like linux/if_ether.h are now checked by configure script. > * The 'static' modifier was added to array variables in aaf_hw_constraint(). > * aaf_close() callback was simplified. > * aaf_rx_pdu() was modified so it doesn't return an error in case the number > of bytes read by recv() is different from aaf->pdu_size. This is an > expected situation and it means the received AVTPDU doesn't belong to the > AAF stream the plugin is interested in so it should simply drop that > AVTPDU. This fixes a bug when running multiple streams (with different > AVPTU sizes) concurrently. > > Additionally, this new version improves the instructions in doc/aaf.txt in > order to make it easier to test the plugin. Anyone should be able to test it > just by copying and pasting the instructions. Thanks for your code. I did a quick review and a compilation test and it seems fine to include this improved code to alsa-plugins. I committed your changes. Our repos are on github now, too : https://github.com/alsa-project Jaroslav
On Thu, 25 Oct 2018 08:41:15 +0200, Jaroslav Kysela wrote: > > Our repos are on github now, too : https://github.com/alsa-project I've seen your recent actions, and wondered whether this is a permanent move or a testing. Will you keep hosting the same git repos on git.alsa-project.org? thanks, Takashi
Dne 25.10.2018 v 08:51 Takashi Iwai napsal(a): > On Thu, 25 Oct 2018 08:41:15 +0200, > Jaroslav Kysela wrote: >> >> Our repos are on github now, too : https://github.com/alsa-project > > I've seen your recent actions, and wondered whether this is a > permanent move or a testing. Will you keep hosting the same git repos > on git.alsa-project.org? I will do a proper github announce later today. And, it's one of the question for the discussion. For me, it would be probably better to do a mirror (and allow the push requests only to one primary repository - github?). Jaroslav
On Thu, 25 Oct 2018 09:36:54 +0200, Jaroslav Kysela wrote: > > Dne 25.10.2018 v 08:51 Takashi Iwai napsal(a): > > On Thu, 25 Oct 2018 08:41:15 +0200, > > Jaroslav Kysela wrote: > >> > >> Our repos are on github now, too : https://github.com/alsa-project > > > > I've seen your recent actions, and wondered whether this is a > > permanent move or a testing. Will you keep hosting the same git repos > > on git.alsa-project.org? > > I will do a proper github announce later today. And, it's one of the > question for the discussion. For me, it would be probably better to do a > mirror (and allow the push requests only to one primary repository - > github?). I don't mind either way, but limiting the push to only the primary repo makes sense. IMO, a bigger question is whether we allow github PR (supposing moving to github as the primary repo). Usually the changes are submitted to alsa-devel ML for review, so far. But with github PR, it may be missing, and may be bad for the workflow of people including me. I'm not sure whether hooking up the PR notification to ML would work. thanks, Takashi
Hi all, This new version addresses the feedback from v1 and fixes a bug on capture mode. Code-wise, the changes are very trivial, no major diffs. Below follows the highlights: * Standard headers like linux/if_ether.h are now checked by configure script. * The 'static' modifier was added to array variables in aaf_hw_constraint(). * aaf_close() callback was simplified. * aaf_rx_pdu() was modified so it doesn't return an error in case the number of bytes read by recv() is different from aaf->pdu_size. This is an expected situation and it means the received AVTPDU doesn't belong to the AAF stream the plugin is interested in so it should simply drop that AVTPDU. This fixes a bug when running multiple streams (with different AVPTU sizes) concurrently. Additionally, this new version improves the instructions in doc/aaf.txt in order to make it easier to test the plugin. Anyone should be able to test it just by copying and pasting the instructions. To recap what has been discussed about the plugin so far, check the comments in RFC and PATCH series archive [1-3]. All versions of this series can be also found in my alsa-plugins tree in github [4]. Regards, Andre [1] http://mailman.alsa-project.org/pipermail/alsa-devel/2018-August/139494.html [2] http://mailman.alsa-project.org/pipermail/alsa-devel/2018-September/140290.html [3] http://mailman.alsa-project.org/pipermail/alsa-devel/2018-October/140667.html [4] https://github.com/aguedes/alsa-plugins Andre Guedes (7): aaf: Introduce plugin skeleton aaf: Load configuration parameters aaf: Implement Playback mode support aaf: Prepare for Capture mode support aaf: Implement Capture mode support aaf: Implement dump() ioplug callback aaf: Add support for direct read/write transfers Makefile.am | 3 + aaf/Makefile.am | 9 + aaf/pcm_aaf.c | 1200 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ configure.ac | 11 + doc/aaf.txt | 157 ++++++++ 5 files changed, 1380 insertions(+) create mode 100644 aaf/Makefile.am create mode 100644 aaf/pcm_aaf.c create mode 100644 doc/aaf.txt