[RFC,v4,63/71] riscv: convert to cpu_has_work_with_iothread_lock

Commit Message

Emilio Cota Oct. 25, 2018, 2:46 p.m. UTC

Soon we will call cpu_has_work without the BQL.

Cc: Michael Clark <[e-mail]>
Cc: Palmer Dabbelt <[e-mail]>
Cc: Sagar Karandikar <[e-mail]>
Cc: Bastian Koppelmann <[e-mail]>
Reviewed-by: Palmer Dabbelt <[e-mail]>
Signed-off-by: Emilio G. Cota <[e-mail]>
---
 target/riscv/cpu.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Richard Henderson Oct. 26, 2018, 3:54 p.m. UTC | #1

On 10/25/18 3:46 PM, Emilio G. Cota wrote:
> Soon we will call cpu_has_work without the BQL.
> 
> Cc: Michael Clark <[e-mail]>
> Cc: Palmer Dabbelt <[e-mail]>
> Cc: Sagar Karandikar <[e-mail]>
> Cc: Bastian Koppelmann <[e-mail]>
> Reviewed-by: Palmer Dabbelt <[e-mail]>
> Signed-off-by: Emilio G. Cota <[e-mail]>
> ---
>  target/riscv/cpu.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

Reviewed-by: Richard Henderson <[e-mail]>

r~

Patch

diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
index d630e8fd6c..758fbaba29 100644
--- a/target/riscv/cpu.c
+++ b/target/riscv/cpu.c
@@ -249,6 +249,9 @@  static bool riscv_cpu_has_work(CPUState *cs)
 #ifndef CONFIG_USER_ONLY
     RISCVCPU *cpu = RISCV_CPU(cs);
     CPURISCVState *env = &cpu->env;
+
+    g_assert(qemu_mutex_iothread_locked());
+
     /*
      * Definition of the WFI instruction requires it to ignore the privilege
      * mode and delegation registers, but respect individual enables
@@ -335,7 +338,7 @@  static void riscv_cpu_class_init(ObjectClass *c, void *data)
     cc->reset = riscv_cpu_reset;
 
     cc->class_by_name = riscv_cpu_class_by_name;
-    cc->has_work = riscv_cpu_has_work;
+    cc->has_work_with_iothread_lock = riscv_cpu_has_work;
     cc->do_interrupt = riscv_cpu_do_interrupt;
     cc->cpu_exec_interrupt = riscv_cpu_exec_interrupt;
     cc->dump_state = riscv_cpu_dump_state;