| Message ID | 20181029200311.16947-1-semen.protsenko@linaro.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [v2] codafs: Fix build using bare-metal toolchain | expand |
Hi Greg, On Mon, Oct 29, 2018 at 10:03 PM, Sam Protsenko <semen.protsenko@linaro.org> wrote: > The kernel is self-contained project and can be built with bare-metal > toolchain. But bare-metal toolchain doesn't define __linux__. Because of > this u_quad_t type is not defined when using bare-metal toolchain and > codafs build fails. This patch fixes it by defining u_quad_t type > unconditionally. > > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> > --- Can you please pull this one, if this applicable? I sent it a while ago, but I guess it got lost in mailing list. It might be also applicable to stable branch (as it fixes allmodconfig build for ARM with bare-metal toolchain). Thanks! > include/linux/coda.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/include/linux/coda.h b/include/linux/coda.h > index d30209b9cef8..0ca0c83fdb1c 100644 > --- a/include/linux/coda.h > +++ b/include/linux/coda.h > @@ -58,8 +58,7 @@ Mellon the rights to redistribute these changes without encumbrance. > #ifndef _CODA_HEADER_ > #define _CODA_HEADER_ > > -#if defined(__linux__) > typedef unsigned long long u_quad_t; > -#endif > + > #include <uapi/linux/coda.h> > #endif > -- > 2.19.1 >
Cc: Arnd, I guess it might be useful for kernel-ci activity as well. On Mon, Oct 29, 2018 at 10:05 PM Sam Protsenko <semen.protsenko@linaro.org> wrote: > > Hi Greg, > > On Mon, Oct 29, 2018 at 10:03 PM, Sam Protsenko > <semen.protsenko@linaro.org> wrote: > > The kernel is self-contained project and can be built with bare-metal > > toolchain. But bare-metal toolchain doesn't define __linux__. Because of > > this u_quad_t type is not defined when using bare-metal toolchain and > > codafs build fails. This patch fixes it by defining u_quad_t type > > unconditionally. > > > > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> > > --- > > Can you please pull this one, if this applicable? I sent it a while > ago, but I guess it got lost in mailing list. It might be also > applicable to stable branch (as it fixes allmodconfig build for ARM > with bare-metal toolchain). > > Thanks! > > > include/linux/coda.h | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/include/linux/coda.h b/include/linux/coda.h > > index d30209b9cef8..0ca0c83fdb1c 100644 > > --- a/include/linux/coda.h > > +++ b/include/linux/coda.h > > @@ -58,8 +58,7 @@ Mellon the rights to redistribute these changes without encumbrance. > > #ifndef _CODA_HEADER_ > > #define _CODA_HEADER_ > > > > -#if defined(__linux__) > > typedef unsigned long long u_quad_t; > > -#endif > > + > > #include <uapi/linux/coda.h> > > #endif > > -- > > 2.19.1 > >
On Mon, Oct 29, 2018 at 10:05:49PM +0200, Sam Protsenko wrote: > Hi Greg, > > On Mon, Oct 29, 2018 at 10:03 PM, Sam Protsenko > <semen.protsenko@linaro.org> wrote: > > The kernel is self-contained project and can be built with bare-metal > > toolchain. But bare-metal toolchain doesn't define __linux__. Because of > > this u_quad_t type is not defined when using bare-metal toolchain and > > codafs build fails. This patch fixes it by defining u_quad_t type > > unconditionally. > > > > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> > > --- > > Can you please pull this one, if this applicable? I sent it a while > ago, but I guess it got lost in mailing list. It might be also > applicable to stable branch (as it fixes allmodconfig build for ARM > with bare-metal toolchain). Why are you asking me? I'm not the maintainer of this file :( confused, greg k-h
On Tue, Oct 30, 2018 at 8:34 AM, Greg KH <gregkh@linuxfoundation.org> wrote: > On Mon, Oct 29, 2018 at 10:05:49PM +0200, Sam Protsenko wrote: >> Hi Greg, >> >> On Mon, Oct 29, 2018 at 10:03 PM, Sam Protsenko >> <semen.protsenko@linaro.org> wrote: >> > The kernel is self-contained project and can be built with bare-metal >> > toolchain. But bare-metal toolchain doesn't define __linux__. Because of >> > this u_quad_t type is not defined when using bare-metal toolchain and >> > codafs build fails. This patch fixes it by defining u_quad_t type >> > unconditionally. >> > >> > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> >> > --- >> >> Can you please pull this one, if this applicable? I sent it a while >> ago, but I guess it got lost in mailing list. It might be also >> applicable to stable branch (as it fixes allmodconfig build for ARM >> with bare-metal toolchain). > > Why are you asking me? I'm not the maintainer of this file :( > > confused, > Sorry to bother you. I just thought you might be interested in this one, as it fixes build for "allmodconfig" configuration, hence it can be related to stable branch. Also, maintainers didn't respond to that patch, so I'm kinda dead in the water. Anyway, will try to ping maintainers one more time. > greg k-h
On Tue, Oct 30, 2018 at 02:01:04PM +0200, Sam Protsenko wrote: > On Tue, Oct 30, 2018 at 8:34 AM, Greg KH <gregkh@linuxfoundation.org> wrote: > > On Mon, Oct 29, 2018 at 10:05:49PM +0200, Sam Protsenko wrote: > >> Hi Greg, > >> > >> On Mon, Oct 29, 2018 at 10:03 PM, Sam Protsenko > >> <semen.protsenko@linaro.org> wrote: > >> > The kernel is self-contained project and can be built with bare-metal > >> > toolchain. But bare-metal toolchain doesn't define __linux__. Because of > >> > this u_quad_t type is not defined when using bare-metal toolchain and > >> > codafs build fails. This patch fixes it by defining u_quad_t type > >> > unconditionally. > >> > > >> > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> > >> > --- > >> > >> Can you please pull this one, if this applicable? I sent it a while > >> ago, but I guess it got lost in mailing list. It might be also > >> applicable to stable branch (as it fixes allmodconfig build for ARM > >> with bare-metal toolchain). > > > > Why are you asking me? I'm not the maintainer of this file :( > > > > confused, > > > > Sorry to bother you. I just thought you might be interested in this > one, as it fixes build for "allmodconfig" configuration, hence it can > be related to stable branch. Also, maintainers didn't respond to that > patch, so I'm kinda dead in the water. > > Anyway, will try to ping maintainers one more time. I thought I had responded, I didn't see a reason why one would want to compile non-userspace kernel headers outside of the context of the kernel and if you do have to do that why not just add -D__linux__. However, I can also see the point that anything not in uapi/ pretty much by definition will be compiled with __linux__ defined so it actually doesn't make a discernable difference to just drop the ifdef and I'm fine with a patch like this. These trivial patches typically get picked up through kernel janitors, or maybe an akpm linux-next patch queue. In fact, I'm not even sure if there is a designated person I would be passing updates to, I've sent patches to akpm, viro, hellwig, linus, and gregkh at various times. Jan
On Tue, Oct 30, 2018 at 3:04 PM, Jan Harkes <jaharkes@cs.cmu.edu> wrote: > On Tue, Oct 30, 2018 at 02:01:04PM +0200, Sam Protsenko wrote: >> On Tue, Oct 30, 2018 at 8:34 AM, Greg KH <gregkh@linuxfoundation.org> wrote: >> > On Mon, Oct 29, 2018 at 10:05:49PM +0200, Sam Protsenko wrote: >> >> Hi Greg, >> >> >> >> On Mon, Oct 29, 2018 at 10:03 PM, Sam Protsenko >> >> <semen.protsenko@linaro.org> wrote: >> >> > The kernel is self-contained project and can be built with bare-metal >> >> > toolchain. But bare-metal toolchain doesn't define __linux__. Because of >> >> > this u_quad_t type is not defined when using bare-metal toolchain and >> >> > codafs build fails. This patch fixes it by defining u_quad_t type >> >> > unconditionally. >> >> > >> >> > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> >> >> > --- >> >> >> >> Can you please pull this one, if this applicable? I sent it a while >> >> ago, but I guess it got lost in mailing list. It might be also >> >> applicable to stable branch (as it fixes allmodconfig build for ARM >> >> with bare-metal toolchain). >> > >> > Why are you asking me? I'm not the maintainer of this file :( >> > >> > confused, >> > >> >> Sorry to bother you. I just thought you might be interested in this >> one, as it fixes build for "allmodconfig" configuration, hence it can >> be related to stable branch. Also, maintainers didn't respond to that >> patch, so I'm kinda dead in the water. >> >> Anyway, will try to ping maintainers one more time. > > I thought I had responded, I didn't see a reason why one would want to > compile non-userspace kernel headers outside of the context of the > kernel and if you do have to do that why not just add -D__linux__. > > However, I can also see the point that anything not in uapi/ pretty much > by definition will be compiled with __linux__ defined so it actually > doesn't make a discernable difference to just drop the ifdef and I'm > fine with a patch like this. > > These trivial patches typically get picked up through kernel janitors, > or maybe an akpm linux-next patch queue. In fact, I'm not even sure if > there is a designated person I would be passing updates to, I've sent > patches to akpm, viro, hellwig, linus, and gregkh at various times. > > Jan Hi Jan, Thank you for the reply. Good point, I will try to re-send this one to Andrew Morton and kernel-janitors. P.S. We need this patch for fixing LKFT/ci-loops build. Thanks!
On Tue, Oct 30, 2018 at 8:33 PM Sam Protsenko <semen.protsenko@linaro.org> wrote: > On Tue, Oct 30, 2018 at 3:04 PM, Jan Harkes <jaharkes@cs.cmu.edu> wrote: > > I thought I had responded I don't see your response either previously or now (currently only via Sam's reply), perhaps you have an issue with mail delivery?
On Tue, Oct 30, 2018 at 3:04 PM Jan Harkes <jaharkes@cs.cmu.edu> wrote: > > On Tue, Oct 30, 2018 at 02:01:04PM +0200, Sam Protsenko wrote: > > On Tue, Oct 30, 2018 at 8:34 AM, Greg KH <gregkh@linuxfoundation.org> wrote: > > > On Mon, Oct 29, 2018 at 10:05:49PM +0200, Sam Protsenko wrote: > > >> Hi Greg, > > >> > > >> On Mon, Oct 29, 2018 at 10:03 PM, Sam Protsenko > > >> <semen.protsenko@linaro.org> wrote: > > >> > The kernel is self-contained project and can be built with bare-metal > > >> > toolchain. But bare-metal toolchain doesn't define __linux__. Because of > > >> > this u_quad_t type is not defined when using bare-metal toolchain and > > >> > codafs build fails. This patch fixes it by defining u_quad_t type > > >> > unconditionally. > > >> > > > >> > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> > > >> > --- > > >> > > >> Can you please pull this one, if this applicable? I sent it a while > > >> ago, but I guess it got lost in mailing list. It might be also > > >> applicable to stable branch (as it fixes allmodconfig build for ARM > > >> with bare-metal toolchain). > > > > > > Why are you asking me? I'm not the maintainer of this file :( > > > > > > confused, > > > > > > > Sorry to bother you. I just thought you might be interested in this > > one, as it fixes build for "allmodconfig" configuration, hence it can > > be related to stable branch. Also, maintainers didn't respond to that > > patch, so I'm kinda dead in the water. > > > > Anyway, will try to ping maintainers one more time. > > I thought I had responded, Oh, this one also was in Spam. > I didn't see a reason why one would want to > compile non-userspace kernel headers outside of the context of the > kernel and if you do have to do that why not just add -D__linux__. > > However, I can also see the point that anything not in uapi/ pretty much > by definition will be compiled with __linux__ defined so it actually > doesn't make a discernable difference to just drop the ifdef and I'm > fine with a patch like this. > > These trivial patches typically get picked up through kernel janitors, > or maybe an akpm linux-next patch queue. In fact, I'm not even sure if > there is a designated person I would be passing updates to, I've sent > patches to akpm, viro, hellwig, linus, and gregkh at various times. % scripts/get_maintainer.pl -f include/linux/coda.h Jan Harkes <jaharkes@cs.cmu.edu> (maintainer:CODA FILE SYSTEM) coda@cs.cmu.edu (maintainer:CODA FILE SYSTEM) codalist@coda.cs.cmu.edu (open list:CODA FILE SYSTEM) linux-kernel@vger.kernel.org (open list) Aren't you a maintainer?
Andy, btw, I'm observing some strange mail thread behavior here. I'm pretty sure you responded to Jan, but he's not in the recipient list in your last mail. If you check Jan's mail (the one you responded to), you can notice new "reply-to" field (or "Mail-Followup-To:", in raw mail). When you respond to his mail, you respond to that list. But Jan is not in that list. That may be the cause of confusion we're seeing here. Anyway, mail settings aside, I'm glad this patch has found its way to upstream. Thanks everyone. On Fri, Nov 23, 2018 at 10:07 PM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > On Tue, Oct 30, 2018 at 3:04 PM Jan Harkes <jaharkes@cs.cmu.edu> wrote: > > > > On Tue, Oct 30, 2018 at 02:01:04PM +0200, Sam Protsenko wrote: > > > On Tue, Oct 30, 2018 at 8:34 AM, Greg KH <gregkh@linuxfoundation.org> wrote: > > > > On Mon, Oct 29, 2018 at 10:05:49PM +0200, Sam Protsenko wrote: > > > >> Hi Greg, > > > >> > > > >> On Mon, Oct 29, 2018 at 10:03 PM, Sam Protsenko > > > >> <semen.protsenko@linaro.org> wrote: > > > >> > The kernel is self-contained project and can be built with bare-metal > > > >> > toolchain. But bare-metal toolchain doesn't define __linux__. Because of > > > >> > this u_quad_t type is not defined when using bare-metal toolchain and > > > >> > codafs build fails. This patch fixes it by defining u_quad_t type > > > >> > unconditionally. > > > >> > > > > >> > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> > > > >> > --- > > > >> > > > >> Can you please pull this one, if this applicable? I sent it a while > > > >> ago, but I guess it got lost in mailing list. It might be also > > > >> applicable to stable branch (as it fixes allmodconfig build for ARM > > > >> with bare-metal toolchain). > > > > > > > > Why are you asking me? I'm not the maintainer of this file :( > > > > > > > > confused, > > > > > > > > > > Sorry to bother you. I just thought you might be interested in this > > > one, as it fixes build for "allmodconfig" configuration, hence it can > > > be related to stable branch. Also, maintainers didn't respond to that > > > patch, so I'm kinda dead in the water. > > > > > > Anyway, will try to ping maintainers one more time. > > > > I thought I had responded, > > Oh, this one also was in Spam. > > > I didn't see a reason why one would want to > > compile non-userspace kernel headers outside of the context of the > > kernel and if you do have to do that why not just add -D__linux__. > > > > However, I can also see the point that anything not in uapi/ pretty much > > by definition will be compiled with __linux__ defined so it actually > > doesn't make a discernable difference to just drop the ifdef and I'm > > fine with a patch like this. > > > > These trivial patches typically get picked up through kernel janitors, > > or maybe an akpm linux-next patch queue. In fact, I'm not even sure if > > there is a designated person I would be passing updates to, I've sent > > patches to akpm, viro, hellwig, linus, and gregkh at various times. > > % scripts/get_maintainer.pl -f include/linux/coda.h > Jan Harkes <jaharkes@cs.cmu.edu> (maintainer:CODA FILE SYSTEM) > coda@cs.cmu.edu (maintainer:CODA FILE SYSTEM) > codalist@coda.cs.cmu.edu (open list:CODA FILE SYSTEM) > linux-kernel@vger.kernel.org (open list) > > Aren't you a maintainer? > > -- > With Best Regards, > Andy Shevchenko
diff --git a/include/linux/coda.h b/include/linux/coda.h index d30209b9cef8..0ca0c83fdb1c 100644 --- a/include/linux/coda.h +++ b/include/linux/coda.h @@ -58,8 +58,7 @@ Mellon the rights to redistribute these changes without encumbrance. #ifndef _CODA_HEADER_ #define _CODA_HEADER_ -#if defined(__linux__) typedef unsigned long long u_quad_t; -#endif + #include <uapi/linux/coda.h> #endif
The kernel is self-contained project and can be built with bare-metal toolchain. But bare-metal toolchain doesn't define __linux__. Because of this u_quad_t type is not defined when using bare-metal toolchain and codafs build fails. This patch fixes it by defining u_quad_t type unconditionally. Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> --- include/linux/coda.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)