diff mbox series

tests: add varargs printf format tests

Message ID 20181030095757.14489-1-ben.dooks@codethink.co.uk (mailing list archive)
State Superseded, archived
Headers show
Series tests: add varargs printf format tests | expand

Commit Message

Ben Dooks Oct. 30, 2018, 9:57 a.m. UTC 
Add some tests for the new printf format checking code.
Note, these do not all pass yet.

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
 validation/varargs-format-addrspace1.c | 57 ++++++++++++++++++++++++++
 validation/varargs-format-bad.c        | 14 ++++++-
 validation/varargs-format-prefix.c     | 18 ++++++++
 validation/varargs-type-checking.c     | 19 +++++++++
 4 files changed, 106 insertions(+), 2 deletions(-)
 create mode 100644 validation/varargs-format-addrspace1.c
 create mode 100644 validation/varargs-format-prefix.c
 create mode 100644 validation/varargs-type-checking.c

Comments

Luc Van Oostenryck Oct. 30, 2018, 12:06 p.m. UTC | #1 
On Tue, Oct 30, 2018 at 09:57:57AM +0000, Ben Dooks wrote:
> Add some tests for the new printf format checking code.

Good. Thank you.

> Note, these do not all pass yet.

You can use the 'tag' 'check-known-to-fail' to indicate
the files that don't pass yet.

Kind regards,
-- Luc
diff mbox series

Patch

diff --git a/validation/varargs-format-addrspace1.c b/validation/varargs-format-addrspace1.c
new file mode 100644
index 0000000..55da817
--- /dev/null
+++ b/validation/varargs-format-addrspace1.c
@@ -0,0 +1,57 @@ 
+
+extern int variadic(char *msg, ...) __attribute__((format (printf, 1, 2)));
+extern int variadic2(char *msg, int , ...) __attribute__((format (printf, 1, 3)));
+extern int variadic3(int, char *msg,  ...) __attribute__((format (printf, 2, 3)));
+
+static void test(void) {
+	void __attribute__((noderef, address_space(1))) *a;
+	void *b;
+
+	variadic("%s\n", a);
+	variadic("%s\n", b);
+	variadic("%s %s\n", b, a);
+	variadic2("%s %s\n", 1, b, a);
+	variadic3(1, "%s %s\n", b, a);
+	variadic3(1, "%s %p\n", b, a);
+}
+
+static char __msg[] = "%s %p";
+
+static void test2(void) {
+	void __attribute__((noderef, address_space(1))) *a;
+	void *b;
+	int (*ptr)(char *msg, ...) __attribute__((format (printf, 1, 2))) = variadic;
+	int (*ptr2)(char *msg, ...) __attribute__((format (printf, 1, 2)));
+
+	variadic(__msg, a, b);
+	ptr("hello %s %s", a, b);
+	ptr2("hello %s %s", a, b);
+}
+
+/*
+ * check-name: variadic formatting test with addres-space to %s
+ *
+ * check-error-start
+varargs-format-addrspace1.c:10:26: warning: incorrect type in argument 2 (different address spaces)
+varargs-format-addrspace1.c:10:26:    expected string
+varargs-format-addrspace1.c:10:26:    got void [noderef] <asn:1>*a
+varargs-format-addrspace1.c:12:32: warning: incorrect type in argument 3 (different address spaces)
+varargs-format-addrspace1.c:12:32:    expected string
+varargs-format-addrspace1.c:12:32:    got void [noderef] <asn:1>*a
+varargs-format-addrspace1.c:13:36: warning: incorrect type in argument 4 (different address spaces)
+varargs-format-addrspace1.c:13:36:    expected string
+varargs-format-addrspace1.c:13:36:    got void [noderef] <asn:1>*a
+varargs-format-addrspace1.c:14:36: warning: incorrect type in argument 4 (different address spaces)
+varargs-format-addrspace1.c:14:36:    expected string
+varargs-format-addrspace1.c:14:36:    got void [noderef] <asn:1>*a
+varargs-format-addrspace1.c:15:36: warning: incorrect type in argument 4 (different address spaces)
+varargs-format-addrspace1.c:15:36:    expected void [noderef] *
+varargs-format-addrspace1.c:15:36:    got void [noderef] <asn:1>*a
+varargs-format-addrspace1.c:26:25: warning: incorrect type in argument 2 (different address spaces)
+varargs-format-addrspace1.c:26:25:    expected string
+varargs-format-addrspace1.c:26:25:    got void [noderef] <asn:1>*a
+varargs-format-addrspace1.c:27:25: warning: incorrect type in argument 2 (different address spaces)
+varargs-format-addrspace1.c:27:25:    expected string
+varargs-format-addrspace1.c:27:25:    got void [noderef] <asn:1>*a
+ * check-error-end
+ */
diff --git a/validation/varargs-format-bad.c b/validation/varargs-format-bad.c
index a8b9cdb..2b96aba 100644
--- a/validation/varargs-format-bad.c
+++ b/validation/varargs-format-bad.c
@@ -1,9 +1,19 @@ 
 
 extern int variadic(char *msg, ...) __attribute__((format (printf, 0, 0)));
 extern int variadic2(char *msg, int , ...) __attribute__((format (printf, 2, 2)));
-extern int variadic3(char *msg, int , ...) __attribute__((format (printf, 2, 3)));
+extern int variadic3(char *msg, int , ...) __attribute__((format (printf, 2, 1)));
 
 static void test(void) {
-	variadic3("test", 1);
 }
 
+/*
+ * check-name: variadic formatting test with bad formatting parameters
+ *
+ * check-error-start
+varargs-format-bad.c:2:72: warning: bad format positions
+varargs-format-bad.c:3:79: warning: bad format positions
+varargs-format-bad.c:4:79: warning: format cannot be after va_args
+* check-error-end
+ */
+
+
diff --git a/validation/varargs-format-prefix.c b/validation/varargs-format-prefix.c
new file mode 100644
index 0000000..a91d1ba
--- /dev/null
+++ b/validation/varargs-format-prefix.c
@@ -0,0 +1,18 @@ 
+
+extern int __attribute__((format (printf, 1, 2))) variadic(char *msg, ...);
+
+static int test(void) {
+	void __attribute__((noderef, address_space(1))) *a;
+
+	variadic("%s\n", a);
+}
+
+/*
+ * check-name: variadic formatting test prefix based __attribute__
+ *
+ * check-error-start
+varargs-format-prefix.c:7:26: warning: incorrect type in argument 2 (different address spaces)
+varargs-format-prefix.c:7:26:    expected string
+varargs-format-prefix.c:7:26:    got void [noderef] <asn:1>*a
+ * check-error-end
+ */
diff --git a/validation/varargs-type-checking.c b/validation/varargs-type-checking.c
new file mode 100644
index 0000000..1e289b2
--- /dev/null
+++ b/validation/varargs-type-checking.c
@@ -0,0 +1,19 @@ 
+
+extern void pf(char *msg, ...) __attribute__((format (printf, 1, 2)));
+
+static void test(void) {
+	pf("%u %lu %llu\n", 1, 1UL, 1ULL);
+	pf("%d %ld %lld\n", 1, 1L, 1LL);
+	pf("%d %lx %llx\n", 1, 1L, 1LL);
+	pf("%d %ld %lld\n", 1, 1L, 1L);
+}
+
+/*
+ * check-name: variadic formatting test type checking
+ *
+ * check-error-start
+validation/varargs-type-checking.c:8:36: warning: incorrect type in argument 4 (different base types)
+validation/varargs-type-checking.c:8:36:    expected long long
+validation/varargs-type-checking.c:8:36:    got long
+ * check-error-end
+ */