| Message ID | 20181021200032.1833-6-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | pinctrl: simplify getting .driver_data | expand |
On 21/10/2018 22:00:31+0200, Wolfram Sang wrote: > We should get 'driver_data' from 'struct device' directly. Going via > platform_device is an unneeded step back and forth. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com> > --- > > Build tested only. buildbot is happy. > > drivers/pinctrl/pinctrl-at91-pio4.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/pinctrl/pinctrl-at91-pio4.c b/drivers/pinctrl/pinctrl-at91-pio4.c > index 5a850491a5cb..4ee135d7b883 100644 > --- a/drivers/pinctrl/pinctrl-at91-pio4.c > +++ b/drivers/pinctrl/pinctrl-at91-pio4.c > @@ -868,8 +868,7 @@ static struct pinctrl_desc atmel_pinctrl_desc = { > > static int __maybe_unused atmel_pctrl_suspend(struct device *dev) > { > - struct platform_device *pdev = to_platform_device(dev); > - struct atmel_pioctrl *atmel_pioctrl = platform_get_drvdata(pdev); > + struct atmel_pioctrl *atmel_pioctrl = dev_get_drvdata(dev); > int i, j; > > /* > @@ -897,8 +896,7 @@ static int __maybe_unused atmel_pctrl_suspend(struct device *dev) > > static int __maybe_unused atmel_pctrl_resume(struct device *dev) > { > - struct platform_device *pdev = to_platform_device(dev); > - struct atmel_pioctrl *atmel_pioctrl = platform_get_drvdata(pdev); > + struct atmel_pioctrl *atmel_pioctrl = dev_get_drvdata(dev); > int i, j; > > for (i = 0; i < atmel_pioctrl->nbanks; i++) { > -- > 2.19.0 >
On Sun, Oct 21, 2018 at 10:00:31PM +0200, Wolfram Sang wrote: > We should get 'driver_data' from 'struct device' directly. Going via > platform_device is an unneeded step back and forth. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com> Thanks > --- > > Build tested only. buildbot is happy. > > drivers/pinctrl/pinctrl-at91-pio4.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/pinctrl/pinctrl-at91-pio4.c b/drivers/pinctrl/pinctrl-at91-pio4.c > index 5a850491a5cb..4ee135d7b883 100644 > --- a/drivers/pinctrl/pinctrl-at91-pio4.c > +++ b/drivers/pinctrl/pinctrl-at91-pio4.c > @@ -868,8 +868,7 @@ static struct pinctrl_desc atmel_pinctrl_desc = { > > static int __maybe_unused atmel_pctrl_suspend(struct device *dev) > { > - struct platform_device *pdev = to_platform_device(dev); > - struct atmel_pioctrl *atmel_pioctrl = platform_get_drvdata(pdev); > + struct atmel_pioctrl *atmel_pioctrl = dev_get_drvdata(dev); > int i, j; > > /* > @@ -897,8 +896,7 @@ static int __maybe_unused atmel_pctrl_suspend(struct device *dev) > > static int __maybe_unused atmel_pctrl_resume(struct device *dev) > { > - struct platform_device *pdev = to_platform_device(dev); > - struct atmel_pioctrl *atmel_pioctrl = platform_get_drvdata(pdev); > + struct atmel_pioctrl *atmel_pioctrl = dev_get_drvdata(dev); > int i, j; > > for (i = 0; i < atmel_pioctrl->nbanks; i++) { > -- > 2.19.0 >
On Sun, Oct 21, 2018 at 10:00 PM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > We should get 'driver_data' from 'struct device' directly. Going via > platform_device is an unneeded step back and forth. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Patch applied with the acks. Yours, Linus Walleij
diff --git a/drivers/pinctrl/pinctrl-at91-pio4.c b/drivers/pinctrl/pinctrl-at91-pio4.c index 5a850491a5cb..4ee135d7b883 100644 --- a/drivers/pinctrl/pinctrl-at91-pio4.c +++ b/drivers/pinctrl/pinctrl-at91-pio4.c @@ -868,8 +868,7 @@ static struct pinctrl_desc atmel_pinctrl_desc = { static int __maybe_unused atmel_pctrl_suspend(struct device *dev) { - struct platform_device *pdev = to_platform_device(dev); - struct atmel_pioctrl *atmel_pioctrl = platform_get_drvdata(pdev); + struct atmel_pioctrl *atmel_pioctrl = dev_get_drvdata(dev); int i, j; /* @@ -897,8 +896,7 @@ static int __maybe_unused atmel_pctrl_suspend(struct device *dev) static int __maybe_unused atmel_pctrl_resume(struct device *dev) { - struct platform_device *pdev = to_platform_device(dev); - struct atmel_pioctrl *atmel_pioctrl = platform_get_drvdata(pdev); + struct atmel_pioctrl *atmel_pioctrl = dev_get_drvdata(dev); int i, j; for (i = 0; i < atmel_pioctrl->nbanks; i++) {
We should get 'driver_data' from 'struct device' directly. Going via platform_device is an unneeded step back and forth. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- Build tested only. buildbot is happy. drivers/pinctrl/pinctrl-at91-pio4.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)