| Message ID | 20181031230043.1302-1-niklas.soderlund@ragnatech.se (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mmc: tmio: delete wait in tuning process | expand |
On Thu, Nov 01, 2018 at 12:00:43AM +0100, Niklas Söderlund wrote: > From: Masaharu Hayakawa <masaharu.hayakawa.ry@renesas.com> > > The manual does not contain information that a wait is needed in the > tuning process, this might be a leftover from early development. > Removing the wait don't have any effect on operation so delete the wait > to shorten the initialization time. > > Signed-off-by: Masaharu Hayakawa <masaharu.hayakawa.ry@renesas.com> > Signed-off-by: Takeshi Saito <takeshi.saito.xv@renesas.com> > [Niklas: fixup commit message] > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
On Thu, Nov 01, 2018 at 12:00:43AM +0100, Niklas Söderlund wrote: > From: Masaharu Hayakawa <masaharu.hayakawa.ry@renesas.com> > > The manual does not contain information that a wait is needed in the > tuning process, this might be a leftover from early development. > Removing the wait don't have any effect on operation so delete the wait > to shorten the initialization time. > > Signed-off-by: Masaharu Hayakawa <masaharu.hayakawa.ry@renesas.com> > Signed-off-by: Takeshi Saito <takeshi.saito.xv@renesas.com> > [Niklas: fixup commit message] > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
On Thu, Nov 01, 2018 at 12:00:43AM +0100, Niklas Söderlund wrote: > From: Masaharu Hayakawa <masaharu.hayakawa.ry@renesas.com> > > The manual does not contain information that a wait is needed in the > tuning process, this might be a leftover from early development. > Removing the wait don't have any effect on operation so delete the wait > to shorten the initialization time. > > Signed-off-by: Masaharu Hayakawa <masaharu.hayakawa.ry@renesas.com> > Signed-off-by: Takeshi Saito <takeshi.saito.xv@renesas.com> > [Niklas: fixup commit message] > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
On 1 November 2018 at 00:00, Niklas Söderlund <niklas.soderlund@ragnatech.se> wrote: > From: Masaharu Hayakawa <masaharu.hayakawa.ry@renesas.com> > > The manual does not contain information that a wait is needed in the > tuning process, this might be a leftover from early development. > Removing the wait don't have any effect on operation so delete the wait > to shorten the initialization time. > > Signed-off-by: Masaharu Hayakawa <masaharu.hayakawa.ry@renesas.com> > Signed-off-by: Takeshi Saito <takeshi.saito.xv@renesas.com> > [Niklas: fixup commit message] > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/tmio_mmc_core.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/mmc/host/tmio_mmc_core.c b/drivers/mmc/host/tmio_mmc_core.c > index 8d64f6196f33e882..a8f917f744fb9f63 100644 > --- a/drivers/mmc/host/tmio_mmc_core.c > +++ b/drivers/mmc/host/tmio_mmc_core.c > @@ -734,8 +734,6 @@ static int tmio_mmc_execute_tuning(struct mmc_host *mmc, u32 opcode) > ret = mmc_send_tuning(mmc, opcode, NULL); > if (ret == 0) > set_bit(i, host->taps); > - > - usleep_range(1000, 1200); > } > > ret = host->select_tuning(host); > -- > 2.19.1 >
diff --git a/drivers/mmc/host/tmio_mmc_core.c b/drivers/mmc/host/tmio_mmc_core.c index 8d64f6196f33e882..a8f917f744fb9f63 100644 --- a/drivers/mmc/host/tmio_mmc_core.c +++ b/drivers/mmc/host/tmio_mmc_core.c @@ -734,8 +734,6 @@ static int tmio_mmc_execute_tuning(struct mmc_host *mmc, u32 opcode) ret = mmc_send_tuning(mmc, opcode, NULL); if (ret == 0) set_bit(i, host->taps); - - usleep_range(1000, 1200); } ret = host->select_tuning(host);