| Message ID | 20181103100900.30313-2-jagan@amarulasolutions.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | drm/sun4i: Allwinner MIPI-DSI Burst mode support | expand |
Hi, Jagan, On 11/3/18 1:08 PM, Jagan Teki wrote: > Loop N1 instruction delay for burst mode lcd panel are > computed as per BSP code. > > Reference code is available in BSP > (in drivers/video/sunxi/disp2/disp/de/lowlevel_sun50iw1/de_dsi.c) > dsi_dev[sel]->dsi_inst_loop_num.bits.loop_n1= > (panel->lcd_ht-panel->lcd_x)*(150)/(panel->lcd_dclk_freq*8) - 50; > => (((mode->htotal - mode->hdisplay) * 150) / ((mode->clock / 1000) * 8)) - 50; > > So use the similar computation for loop N1 delay. > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > --- > drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > index 86430efd9054..da152c21ec62 100644 > --- a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > +++ b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > @@ -394,7 +394,14 @@ static void sun6i_dsi_setup_burst(struct sun6i_dsi *dsi, > static void sun6i_dsi_setup_inst_loop(struct sun6i_dsi *dsi, > struct drm_display_mode *mode) > { > - u16 delay = 50 - 1; > + struct mipi_dsi_device *device = dsi->device; > + u16 delay; > + > + if (device->mode_flags == MIPI_DSI_MODE_VIDEO_BURST) > + delay = (((mode->htotal - mode->hdisplay) * 150) / > + ((mode->clock / 1000) * 8)) - 50; > + else > + delay = 50 - 1; > > regmap_write(dsi->regs, SUN6I_DSI_INST_LOOP_NUM_REG(0), > SUN6I_DSI_INST_LOOP_NUM_N0(50 - 1) | is this patch series comes in addition to the previous MIPI DSI series or in its stead? Thanks
On Sat, Nov 3, 2018 at 8:53 PM Sergey Suloev <ssuloev@orpaltech.com> wrote: > > Hi, Jagan, > > On 11/3/18 1:08 PM, Jagan Teki wrote: > > Loop N1 instruction delay for burst mode lcd panel are > > computed as per BSP code. > > > > Reference code is available in BSP > > (in drivers/video/sunxi/disp2/disp/de/lowlevel_sun50iw1/de_dsi.c) > > dsi_dev[sel]->dsi_inst_loop_num.bits.loop_n1= > > (panel->lcd_ht-panel->lcd_x)*(150)/(panel->lcd_dclk_freq*8) - 50; > > => (((mode->htotal - mode->hdisplay) * 150) / ((mode->clock / 1000) * 8)) - 50; > > > > So use the similar computation for loop N1 delay. > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > > --- > > drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 9 ++++++++- > > 1 file changed, 8 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > > index 86430efd9054..da152c21ec62 100644 > > --- a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > > +++ b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > > @@ -394,7 +394,14 @@ static void sun6i_dsi_setup_burst(struct sun6i_dsi *dsi, > > static void sun6i_dsi_setup_inst_loop(struct sun6i_dsi *dsi, > > struct drm_display_mode *mode) > > { > > - u16 delay = 50 - 1; > > + struct mipi_dsi_device *device = dsi->device; > > + u16 delay; > > + > > + if (device->mode_flags == MIPI_DSI_MODE_VIDEO_BURST) > > + delay = (((mode->htotal - mode->hdisplay) * 150) / > > + ((mode->clock / 1000) * 8)) - 50; > > + else > > + delay = 50 - 1; > > > > regmap_write(dsi->regs, SUN6I_DSI_INST_LOOP_NUM_REG(0), > > SUN6I_DSI_INST_LOOP_NUM_N0(50 - 1) | > > > is this patch series comes in addition to the previous MIPI DSI series > or in its stead? Yes, all changes were added on top of previous MIPI DSI series(ie what I mentioned in cover-letter) since it require clock patches from previous version.
On Sat, Nov 03, 2018 at 03:38:51PM +0530, Jagan Teki wrote: > Loop N1 instruction delay for burst mode lcd panel are > computed as per BSP code. > > Reference code is available in BSP > (in drivers/video/sunxi/disp2/disp/de/lowlevel_sun50iw1/de_dsi.c) > dsi_dev[sel]->dsi_inst_loop_num.bits.loop_n1= > (panel->lcd_ht-panel->lcd_x)*(150)/(panel->lcd_dclk_freq*8) - 50; > => (((mode->htotal - mode->hdisplay) * 150) / ((mode->clock / 1000) * 8)) - 50; > > So use the similar computation for loop N1 delay. > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > --- > drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > index 86430efd9054..da152c21ec62 100644 > --- a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > +++ b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > @@ -394,7 +394,14 @@ static void sun6i_dsi_setup_burst(struct sun6i_dsi *dsi, > static void sun6i_dsi_setup_inst_loop(struct sun6i_dsi *dsi, > struct drm_display_mode *mode) > { > - u16 delay = 50 - 1; > + struct mipi_dsi_device *device = dsi->device; > + u16 delay; > + > + if (device->mode_flags == MIPI_DSI_MODE_VIDEO_BURST) This looks fishy, as mode_flags is supposedly bitfield. I guess you actually want mode_flags & MIPI_DSI_MODE_VIDEO_BURST. Other patches are also affected by this. > + delay = (((mode->htotal - mode->hdisplay) * 150) / > + ((mode->clock / 1000) * 8)) - 50; > + else > + delay = 50 - 1; > > regmap_write(dsi->regs, SUN6I_DSI_INST_LOOP_NUM_REG(0), > SUN6I_DSI_INST_LOOP_NUM_N0(50 - 1) | > -- > 2.18.0.321.gffc6fa0e3 > > -- > You received this message because you are subscribed to the Google Groups "linux-sunxi" group. > To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/d/optout.
On Sat, Nov 03, 2018 at 03:38:51PM +0530, Jagan Teki wrote: > Loop N1 instruction delay for burst mode lcd panel are > computed as per BSP code. > > Reference code is available in BSP > (in drivers/video/sunxi/disp2/disp/de/lowlevel_sun50iw1/de_dsi.c) > dsi_dev[sel]->dsi_inst_loop_num.bits.loop_n1= > (panel->lcd_ht-panel->lcd_x)*(150)/(panel->lcd_dclk_freq*8) - 50; > => (((mode->htotal - mode->hdisplay) * 150) / ((mode->clock / 1000) * 8)) - 50; > > So use the similar computation for loop N1 delay. > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > --- > drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > index 86430efd9054..da152c21ec62 100644 > --- a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > +++ b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > @@ -394,7 +394,14 @@ static void sun6i_dsi_setup_burst(struct sun6i_dsi *dsi, > static void sun6i_dsi_setup_inst_loop(struct sun6i_dsi *dsi, > struct drm_display_mode *mode) > { > - u16 delay = 50 - 1; > + struct mipi_dsi_device *device = dsi->device; > + u16 delay; > + > + if (device->mode_flags == MIPI_DSI_MODE_VIDEO_BURST) > + delay = (((mode->htotal - mode->hdisplay) * 150) / > + ((mode->clock / 1000) * 8)) - 50; > + else > + delay = 50 - 1; Apart from the other comments, I'd really prefer to have a function here that would take the mipi_dsi_device and compute the delay. Maxime
diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c index 86430efd9054..da152c21ec62 100644 --- a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c +++ b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c @@ -394,7 +394,14 @@ static void sun6i_dsi_setup_burst(struct sun6i_dsi *dsi, static void sun6i_dsi_setup_inst_loop(struct sun6i_dsi *dsi, struct drm_display_mode *mode) { - u16 delay = 50 - 1; + struct mipi_dsi_device *device = dsi->device; + u16 delay; + + if (device->mode_flags == MIPI_DSI_MODE_VIDEO_BURST) + delay = (((mode->htotal - mode->hdisplay) * 150) / + ((mode->clock / 1000) * 8)) - 50; + else + delay = 50 - 1; regmap_write(dsi->regs, SUN6I_DSI_INST_LOOP_NUM_REG(0), SUN6I_DSI_INST_LOOP_NUM_N0(50 - 1) |
Loop N1 instruction delay for burst mode lcd panel are computed as per BSP code. Reference code is available in BSP (in drivers/video/sunxi/disp2/disp/de/lowlevel_sun50iw1/de_dsi.c) dsi_dev[sel]->dsi_inst_loop_num.bits.loop_n1= (panel->lcd_ht-panel->lcd_x)*(150)/(panel->lcd_dclk_freq*8) - 50; => (((mode->htotal - mode->hdisplay) * 150) / ((mode->clock / 1000) * 8)) - 50; So use the similar computation for loop N1 delay. Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> --- drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)