| Message ID | 20181105161913.27538-1-agust@denx.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add support for ARRI FPGA configuration | expand |
On Mon, Nov 5, 2018 at 10:19 AM Anatolij Gustschin <agust@denx.de> wrote: Hi Anatolij, > > This series adds drivers and FPGA manager support required > for FT232H based ARRI FPGA configuration adapters. Is this a repost or a new version of this patchset? If it's a repost, you could note that. If there are changes since the previous posting, version info helps reviewers know what's new. Thanks, Alan > > Patch 1/3 adds FT232H interface driver (for ARRI USB PIDs) > implementing commonly used FTDI USB transfer operations and > ACBUS/MPSSE GPIO controllers. Depending on USB PIDs it creates > platform devices for MPSSE SPI bus with attached SPI slaves > or platform devices for ARRI FPP FPGA manager. > > Patch 2/3 adds MPSSE SPI controller driver which registers > an FTDI USB-SPI bus with attached SPI slaves from description > in platform data, so existing SPI protocol drivers can be > used for these slave devices (in our case altera-ps-spi). > Via interface driver in patch 1/3 it is easily possible to add > support for other slave devices using custom USB PIDs (e.g. > spi-nor flash W25Q32 with m25p80 driver has beed used for > testing MPSSE SPI controller driver). > > Patch 3/3 adds FPGA manager driver for ARRI FPP adapters for > FPGA configuration via Altera fast passive parallel interface. > > Anatolij Gustschin (3): > usb: misc: add driver for FT232H based FPGA configuration devices > spi: add FTDI MPSSE SPI controller driver > fpga: Add fpga manager driver for ARRI Altera FPP > > drivers/fpga/Kconfig | 7 + > drivers/fpga/Makefile | 1 + > drivers/fpga/ftdi-fifo-fpp.c | 594 +++++++++++++ > drivers/spi/Kconfig | 7 + > drivers/spi/Makefile | 1 + > drivers/spi/spi-ftdi-mpsse.c | 671 ++++++++++++++ > drivers/usb/misc/Kconfig | 9 + > drivers/usb/misc/Makefile | 1 + > drivers/usb/misc/ft232h-intf.c | 1468 +++++++++++++++++++++++++++++++ > include/linux/usb/ft232h-intf.h | 198 +++++ > 10 files changed, 2957 insertions(+) > create mode 100644 drivers/fpga/ftdi-fifo-fpp.c > create mode 100644 drivers/spi/spi-ftdi-mpsse.c > create mode 100644 drivers/usb/misc/ft232h-intf.c > create mode 100644 include/linux/usb/ft232h-intf.h > > -- > 2.17.1 >
Hi Alan, On Mon, 5 Nov 2018 12:52:03 -0600 Alan Tull atull@kernel.org wrote: >On Mon, Nov 5, 2018 at 10:19 AM Anatolij Gustschin <agust@denx.de> wrote: > >Hi Anatolij, > >> >> This series adds drivers and FPGA manager support required >> for FT232H based ARRI FPGA configuration adapters. > >Is this a repost or a new version of this patchset? If it's a repost, >you could note that. If there are changes since the previous posting, >version info helps reviewers know what's new. This is a new version. Or it is very different compared to my first attempt to add driver support for this adapter hardware. The initial series ([1],[2],[3]) didn't include MPSSE SPI driver, it didn't use vendor specific USB PIDs for FTDI device and had fundamental design issues. This new version implements the new driver design as summarized here [4]. Changes in this new version: - don't use MFD framework - don't use original FT232H USB PID (it is too generic and collides with existing ftdi_sio driver) - don't add separate CBUS GPIO driver based on FT232H MFD device - redesign/rework the drivers as described under [4] - add basic FT232H interface driver under drivers/usb/misc/ - use custom reserved USB PIDs in the USB driver for adapter devices - add notes about borrowed protocol code from libftdi to commit log and header file - add MPSSE SPI controller driver supporting USB-SPI bus with dynamically added SPI slaves from description in platform data (the initial attempt didn't include USB SPI bus support for PS- SPI FPGA configuration via USB) - rework FPP fpga manager driver based on new FT232H interface driver and extend it according to CPLD changes for additional support of new hardware revision B. [1] https://patchwork.kernel.org/patch/9828985/ [2] https://patchwork.kernel.org/patch/9828981/ [3] https://patchwork.kernel.org/patch/9828983/ [4] https://www.spinics.net/lists/linux-usb/msg163441.html Thanks, Anatolij