mbox series

[v2,0/7] PBLK Bugfixes and cleanups

Message ID 20181105122610.1555-1-hans.ml.holmberg@owltronix.com (mailing list archive)
Headers show
Series PBLK Bugfixes and cleanups | expand

Message

Hans Holmberg Nov. 5, 2018, 12:26 p.m. UTC
From: Hans Holmberg <hans.holmberg@cnexlabs.com>

This series is a slew of bugfixes and cleanups for PBLK, mostly
fixing issues found during corner-case testing in QEMU.

Changes since v1:
	Messed up from:, now the patches apply with the correct author
	Pardon the mess.

Hans Holmberg (7):
  lightnvm: pblk: fix resubmission of overwritten write err lbas
  lightnvm: pblk: account for write error sectors in emeta
  lightnvm: pblk: stop writes gracefully when running out of lines
  lightnvm: pblk: set conservative threshold for user writes
  lightnvm: pblk: remove unused macro
  lightnvm: pblk: fix pblk_lines_init error handling path
  lightnvm: pblk: remove dead code in pblk_recov_l2p

 drivers/lightnvm/pblk-init.c     | 48 +++++++++++++++++-----------
 drivers/lightnvm/pblk-map.c      | 47 ++++++++++++++++-----------
 drivers/lightnvm/pblk-recovery.c |  1 -
 drivers/lightnvm/pblk-rl.c       |  5 ++-
 drivers/lightnvm/pblk-write.c    | 55 +++++++++++++++++++++++---------
 drivers/lightnvm/pblk.h          | 16 ++++++++--
 6 files changed, 114 insertions(+), 58 deletions(-)

Comments

Javier Gonzalez Nov. 6, 2018, 9:18 a.m. UTC | #1
> On 5 Nov 2018, at 13.26, Hans Holmberg <hans.ml.holmberg@owltronix.com> wrote:
> 
> From: Hans Holmberg <hans.holmberg@cnexlabs.com>
> 
> This series is a slew of bugfixes and cleanups for PBLK, mostly
> fixing issues found during corner-case testing in QEMU.
> 
> Changes since v1:
> 	Messed up from:, now the patches apply with the correct author
> 	Pardon the mess.
> 
> Hans Holmberg (7):
>  lightnvm: pblk: fix resubmission of overwritten write err lbas
>  lightnvm: pblk: account for write error sectors in emeta
>  lightnvm: pblk: stop writes gracefully when running out of lines
>  lightnvm: pblk: set conservative threshold for user writes
>  lightnvm: pblk: remove unused macro
>  lightnvm: pblk: fix pblk_lines_init error handling path
>  lightnvm: pblk: remove dead code in pblk_recov_l2p
> 
> drivers/lightnvm/pblk-init.c     | 48 +++++++++++++++++-----------
> drivers/lightnvm/pblk-map.c      | 47 ++++++++++++++++-----------
> drivers/lightnvm/pblk-recovery.c |  1 -
> drivers/lightnvm/pblk-rl.c       |  5 ++-
> drivers/lightnvm/pblk-write.c    | 55 +++++++++++++++++++++++---------
> drivers/lightnvm/pblk.h          | 16 ++++++++--
> 6 files changed, 114 insertions(+), 58 deletions(-)
> 
> --
> 2.17.1


Apart from the nipticks pointed out in V2, the series look good to me.

Reviewed-by: Javier González <javier@javigon.com>