| Message ID | 20181102124535.24331-1-tiny.windzz@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] i2c: rk3x: fix some typo | expand |
On 2018-11-02 13:45, Yangtao Li wrote: > Fix multiple instances of a misspelled "Calculates". Yes, it sure is hard to spell "Calcluated," it's almost impossible to get it completely right and not introduce another typo somewhere... :-) Cheers, Peter > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > Reviewed-by: Heiko Stuebner <heiko@sntech.de> > --- > Changes in v2: > -add commit message > --- > drivers/i2c/busses/i2c-rk3x.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c > index b8a2728dd4b6..fe347e8e2a23 100644 > --- a/drivers/i2c/busses/i2c-rk3x.c > +++ b/drivers/i2c/busses/i2c-rk3x.c > @@ -555,7 +555,7 @@ static const struct i2c_spec_values *rk3x_i2c_get_spec(unsigned int speed) > * > * @clk_rate: I2C input clock rate > * @t: Known I2C timing information > - * @t_calc: Caculated rk3x private timings that would be written into regs > + * @t_calc: Calculated rk3x private timings that would be written into regs > * > * Returns: 0 on success, -EINVAL if the goal SCL rate is too slow. In that case > * a best-effort divider value is returned in divs. If the target rate is > @@ -716,7 +716,7 @@ static int rk3x_i2c_v0_calc_timings(unsigned long clk_rate, > * > * @clk_rate: I2C input clock rate > * @t: Known I2C timing information > - * @t_calc: Caculated rk3x private timings that would be written into regs > + * @t_calc: Calculated rk3x private timings that would be written into regs > * > * Returns: 0 on success, -EINVAL if the goal SCL rate is too slow. In that case > * a best-effort divider value is returned in divs. If the target rate is >
I am sorry. -- Yangtao On Fri, Nov 2, 2018 at 8:58 PM Peter Rosin <peda@axentia.se> wrote: > > On 2018-11-02 13:45, Yangtao Li wrote: > > Fix multiple instances of a misspelled "Calculates". > > Yes, it sure is hard to spell "Calcluated," it's almost impossible to > get it completely right and not introduce another typo somewhere... :-) > > Cheers, > Peter > > > > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > > Reviewed-by: Heiko Stuebner <heiko@sntech.de> > > --- > > Changes in v2: > > -add commit message > > --- > > drivers/i2c/busses/i2c-rk3x.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c > > index b8a2728dd4b6..fe347e8e2a23 100644 > > --- a/drivers/i2c/busses/i2c-rk3x.c > > +++ b/drivers/i2c/busses/i2c-rk3x.c > > @@ -555,7 +555,7 @@ static const struct i2c_spec_values *rk3x_i2c_get_spec(unsigned int speed) > > * > > * @clk_rate: I2C input clock rate > > * @t: Known I2C timing information > > - * @t_calc: Caculated rk3x private timings that would be written into regs > > + * @t_calc: Calculated rk3x private timings that would be written into regs > > * > > * Returns: 0 on success, -EINVAL if the goal SCL rate is too slow. In that case > > * a best-effort divider value is returned in divs. If the target rate is > > @@ -716,7 +716,7 @@ static int rk3x_i2c_v0_calc_timings(unsigned long clk_rate, > > * > > * @clk_rate: I2C input clock rate > > * @t: Known I2C timing information > > - * @t_calc: Caculated rk3x private timings that would be written into regs > > + * @t_calc: Calculated rk3x private timings that would be written into regs > > * > > * Returns: 0 on success, -EINVAL if the goal SCL rate is too slow. In that case > > * a best-effort divider value is returned in divs. If the target rate is > > >
Hi Yangtao, Peter, Am Montag, 5. November 2018, 16:59:58 CET schrieb Frank Lee: > I am sorry. > -- Yangtao If anything, it is me that should be sorry, as I did suggest the patch description, including the new spelling error. And it took me like the whole weekend to actually realize where the Calculated / Calculates error was hiding ;-) . Heiko > On Fri, Nov 2, 2018 at 8:58 PM Peter Rosin <peda@axentia.se> wrote: > > > > On 2018-11-02 13:45, Yangtao Li wrote: > > > Fix multiple instances of a misspelled "Calculates". > > > > Yes, it sure is hard to spell "Calcluated," it's almost impossible to > > get it completely right and not introduce another typo somewhere... :-) > > > > Cheers, > > Peter > > > > > > > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > > > Reviewed-by: Heiko Stuebner <heiko@sntech.de> > > > --- > > > Changes in v2: > > > -add commit message > > > --- > > > drivers/i2c/busses/i2c-rk3x.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c > > > index b8a2728dd4b6..fe347e8e2a23 100644 > > > --- a/drivers/i2c/busses/i2c-rk3x.c > > > +++ b/drivers/i2c/busses/i2c-rk3x.c > > > @@ -555,7 +555,7 @@ static const struct i2c_spec_values *rk3x_i2c_get_spec(unsigned int speed) > > > * > > > * @clk_rate: I2C input clock rate > > > * @t: Known I2C timing information > > > - * @t_calc: Caculated rk3x private timings that would be written into regs > > > + * @t_calc: Calculated rk3x private timings that would be written into regs > > > * > > > * Returns: 0 on success, -EINVAL if the goal SCL rate is too slow. In that case > > > * a best-effort divider value is returned in divs. If the target rate is > > > @@ -716,7 +716,7 @@ static int rk3x_i2c_v0_calc_timings(unsigned long clk_rate, > > > * > > > * @clk_rate: I2C input clock rate > > > * @t: Known I2C timing information > > > - * @t_calc: Caculated rk3x private timings that would be written into regs > > > + * @t_calc: Calculated rk3x private timings that would be written into regs > > > * > > > * Returns: 0 on success, -EINVAL if the goal SCL rate is too slow. In that case > > > * a best-effort divider value is returned in divs. If the target rate is > > > > > >
Hi Heiko： please，correct it in the cimmit message. --Yangtao On Tue, Nov 6, 2018 at 8:01 PM Heiko Stuebner <heiko@sntech.de> wrote: > > Hi Yangtao, Peter, > > Am Montag, 5. November 2018, 16:59:58 CET schrieb Frank Lee: > > I am sorry. > > -- Yangtao > > If anything, it is me that should be sorry, as I did suggest the > patch description, including the new spelling error. > > And it took me like the whole weekend to actually realize where the > Calculated / Calculates error was hiding ;-) . > > > Heiko > > > On Fri, Nov 2, 2018 at 8:58 PM Peter Rosin <peda@axentia.se> wrote: > > > > > > On 2018-11-02 13:45, Yangtao Li wrote: > > > > Fix multiple instances of a misspelled "Calculates". > > > > > > Yes, it sure is hard to spell "Calcluated," it's almost impossible to > > > get it completely right and not introduce another typo somewhere... :-) > > > > > > Cheers, > > > Peter > > > > > > > > > > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > > > > Reviewed-by: Heiko Stuebner <heiko@sntech.de> > > > > --- > > > > Changes in v2: > > > > -add commit message > > > > --- > > > > drivers/i2c/busses/i2c-rk3x.c | 4 ++-- > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c > > > > index b8a2728dd4b6..fe347e8e2a23 100644 > > > > --- a/drivers/i2c/busses/i2c-rk3x.c > > > > +++ b/drivers/i2c/busses/i2c-rk3x.c > > > > @@ -555,7 +555,7 @@ static const struct i2c_spec_values *rk3x_i2c_get_spec(unsigned int speed) > > > > * > > > > * @clk_rate: I2C input clock rate > > > > * @t: Known I2C timing information > > > > - * @t_calc: Caculated rk3x private timings that would be written into regs > > > > + * @t_calc: Calculated rk3x private timings that would be written into regs > > > > * > > > > * Returns: 0 on success, -EINVAL if the goal SCL rate is too slow. In that case > > > > * a best-effort divider value is returned in divs. If the target rate is > > > > @@ -716,7 +716,7 @@ static int rk3x_i2c_v0_calc_timings(unsigned long clk_rate, > > > > * > > > > * @clk_rate: I2C input clock rate > > > > * @t: Known I2C timing information > > > > - * @t_calc: Caculated rk3x private timings that would be written into regs > > > > + * @t_calc: Calculated rk3x private timings that would be written into regs > > > > * > > > > * Returns: 0 on success, -EINVAL if the goal SCL rate is too slow. In that case > > > > * a best-effort divider value is returned in divs. If the target rate is > > > > > > > > > > > > >
add myself. On Tue, Nov 6, 2018 at 9:01 PM Frank Lee <tiny.windzz@gmail.com> wrote: > > Hi Heiko： > > please，correct it in the cimmit message. > > --Yangtao > On Tue, Nov 6, 2018 at 8:01 PM Heiko Stuebner <heiko@sntech.de> wrote: > > > > Hi Yangtao, Peter, > > > > Am Montag, 5. November 2018, 16:59:58 CET schrieb Frank Lee: > > > I am sorry. > > > -- Yangtao > > > > If anything, it is me that should be sorry, as I did suggest the > > patch description, including the new spelling error. > > > > And it took me like the whole weekend to actually realize where the > > Calculated / Calculates error was hiding ;-) . > > > > > > Heiko > > > > > On Fri, Nov 2, 2018 at 8:58 PM Peter Rosin <peda@axentia.se> wrote: > > > > > > > > On 2018-11-02 13:45, Yangtao Li wrote: > > > > > Fix multiple instances of a misspelled "Calculates". > > > > > > > > Yes, it sure is hard to spell "Calcluated," it's almost impossible to > > > > get it completely right and not introduce another typo somewhere... :-) > > > > > > > > Cheers, > > > > Peter > > > > > > > > > > > > > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > > > > > Reviewed-by: Heiko Stuebner <heiko@sntech.de> > > > > > --- > > > > > Changes in v2: > > > > > -add commit message > > > > > --- > > > > > drivers/i2c/busses/i2c-rk3x.c | 4 ++-- > > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > > > diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c > > > > > index b8a2728dd4b6..fe347e8e2a23 100644 > > > > > --- a/drivers/i2c/busses/i2c-rk3x.c > > > > > +++ b/drivers/i2c/busses/i2c-rk3x.c > > > > > @@ -555,7 +555,7 @@ static const struct i2c_spec_values *rk3x_i2c_get_spec(unsigned int speed) > > > > > * > > > > > * @clk_rate: I2C input clock rate > > > > > * @t: Known I2C timing information > > > > > - * @t_calc: Caculated rk3x private timings that would be written into regs > > > > > + * @t_calc: Calculated rk3x private timings that would be written into regs > > > > > * > > > > > * Returns: 0 on success, -EINVAL if the goal SCL rate is too slow. In that case > > > > > * a best-effort divider value is returned in divs. If the target rate is > > > > > @@ -716,7 +716,7 @@ static int rk3x_i2c_v0_calc_timings(unsigned long clk_rate, > > > > > * > > > > > * @clk_rate: I2C input clock rate > > > > > * @t: Known I2C timing information > > > > > - * @t_calc: Caculated rk3x private timings that would be written into regs > > > > > + * @t_calc: Calculated rk3x private timings that would be written into regs > > > > > * > > > > > * Returns: 0 on success, -EINVAL if the goal SCL rate is too slow. In that case > > > > > * a best-effort divider value is returned in divs. If the target rate is > > > > > > > > > > > > > > > > > > > >
On Tue, Nov 06, 2018 at 01:01:33PM +0100, Heiko Stuebner wrote: > Hi Yangtao, Peter, > > Am Montag, 5. November 2018, 16:59:58 CET schrieb Frank Lee: > > I am sorry. > > -- Yangtao > > If anything, it is me that should be sorry, as I did suggest the > patch description, including the new spelling error. > > And it took me like the whole weekend to actually realize where the > Calculated / Calculates error was hiding ;-) . You guys are fun :) Anyhow, $subject is way too generic, that is the real culprit here. I don't mind empty descriptions, so you can basically move the message into the header.
diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c index b8a2728dd4b6..fe347e8e2a23 100644 --- a/drivers/i2c/busses/i2c-rk3x.c +++ b/drivers/i2c/busses/i2c-rk3x.c @@ -555,7 +555,7 @@ static const struct i2c_spec_values *rk3x_i2c_get_spec(unsigned int speed) * * @clk_rate: I2C input clock rate * @t: Known I2C timing information - * @t_calc: Caculated rk3x private timings that would be written into regs + * @t_calc: Calculated rk3x private timings that would be written into regs * * Returns: 0 on success, -EINVAL if the goal SCL rate is too slow. In that case * a best-effort divider value is returned in divs. If the target rate is @@ -716,7 +716,7 @@ static int rk3x_i2c_v0_calc_timings(unsigned long clk_rate, * * @clk_rate: I2C input clock rate * @t: Known I2C timing information - * @t_calc: Caculated rk3x private timings that would be written into regs + * @t_calc: Calculated rk3x private timings that would be written into regs * * Returns: 0 on success, -EINVAL if the goal SCL rate is too slow. In that case * a best-effort divider value is returned in divs. If the target rate is