[v2,0/7] spi: spi-mem: Add a direct mapping API

Message

Boris Brezillon Oct. 30, 2018, 1:36 p.m. UTC

Hello,

I didn't have much review on the RFC, so I'm resending this series
without "RFC" in the subject. Maybe I'll get more reviews this time.

A few things have changed since I submitted the RFC
- The spi-nand framework has been merged, and I can thus patch this
  driver to use the dirmap API
- The MXIC controller has been submitted, and since I did my tests
  with this controller, I can also add a patch showing how to
  implement the dirmap hooks

Other changes are addressing the comments I received from Miquel.

I'd still like to get feedback on the API and controller interface if
anyone is interested in reviewing it.

Thanks,

Boris

Boris Brezillon (7):
  spi: spi-mem: Add missing word in the SPI_MEM_DATA_OUT description
  spi: spi-mem: Add SPI_MEM_NO_DATA to the spi_mem_data_dir enum
  spi: spi-mem: Split spi_mem_exec_op() code
  spi: spi-mem: Add a new API to support direct mapping
  mtd: devices: m25p80: Use the spi-mem dirmap API
  mtd: spinand: Use the spi-mem dirmap API
  spi: mxic: Add support for direct mapping

 drivers/mtd/devices/m25p80.c | 142 +++++++++++-------
 drivers/mtd/nand/spi/core.c  | 231 +++++++++++++++++-------------
 drivers/spi/spi-mem.c        | 269 ++++++++++++++++++++++++++++++++---
 drivers/spi/spi-mxic.c       | 140 ++++++++++++++----
 include/linux/mtd/spinand.h  |   7 +
 include/linux/spi/spi-mem.h  |  84 ++++++++++-
 6 files changed, 670 insertions(+), 203 deletions(-)

Comments

Miquel Raynal Nov. 6, 2018, 1:21 p.m. UTC | #1

Hi Boris,

Boris Brezillon <[e-mail]> wrote on Tue, 30 Oct 2018
14:36:31 +0100:

> Hello,
> 
> I didn't have much review on the RFC, so I'm resending this series
> without "RFC" in the subject. Maybe I'll get more reviews this time.
> 
> A few things have changed since I submitted the RFC
> - The spi-nand framework has been merged, and I can thus patch this
>   driver to use the dirmap API
> - The MXIC controller has been submitted, and since I did my tests
>   with this controller, I can also add a patch showing how to
>   implement the dirmap hooks
> 
> Other changes are addressing the comments I received from Miquel.
> 
> I'd still like to get feedback on the API and controller interface if
> anyone is interested in reviewing it.
> 
> Thanks,
> 
> Boris
> 
> Boris Brezillon (7):
>   spi: spi-mem: Add missing word in the SPI_MEM_DATA_OUT description
>   spi: spi-mem: Add SPI_MEM_NO_DATA to the spi_mem_data_dir enum
>   spi: spi-mem: Split spi_mem_exec_op() code
>   spi: spi-mem: Add a new API to support direct mapping
>   mtd: devices: m25p80: Use the spi-mem dirmap API
>   mtd: spinand: Use the spi-mem dirmap API
>   spi: mxic: Add support for direct mapping
> 
>  drivers/mtd/devices/m25p80.c | 142 +++++++++++-------
>  drivers/mtd/nand/spi/core.c  | 231 +++++++++++++++++-------------
>  drivers/spi/spi-mem.c        | 269 ++++++++++++++++++++++++++++++++---
>  drivers/spi/spi-mxic.c       | 140 ++++++++++++++----
>  include/linux/mtd/spinand.h  |   7 +
>  include/linux/spi/spi-mem.h  |  84 ++++++++++-
>  6 files changed, 670 insertions(+), 203 deletions(-)
> 

For the whole series:

Reviewed-by: Miquel Raynal <[e-mail]>


Thanks,
Miquèl