diff mbox series

[v3] clk: qoriq: add more chips support

Message ID 20181031074616.24412-1-andy.tang@nxp.com (mailing list archive)
State Accepted, archived
Headers show
Series [v3] clk: qoriq: add more chips support | expand

Commit Message

Andy Tang Oct. 31, 2018, 7:46 a.m. UTC 
Add more chip-specific compatible strings to support more Socs.

Signed-off-by: Yuantian Tang <andy.tang@nxp.com>
---
v3:
  - undo deleting old bindings
  - split dts and driver code to different patchset
v2:
  - remove all legacy code

 drivers/clk/clk-qoriq.c |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)

Comments

Stephen Boyd Nov. 6, 2018, 5:24 p.m. UTC | #1 
Quoting Yuantian Tang (2018-10-31 00:46:16)
> diff --git a/drivers/clk/clk-qoriq.c b/drivers/clk/clk-qoriq.c
> index 4c30b6e..5baa9e0 100644
> --- a/drivers/clk/clk-qoriq.c
> +++ b/drivers/clk/clk-qoriq.c
> @@ -1418,12 +1418,23 @@ static void __init clockgen_init(struct device_node *np)
>  
>  CLK_OF_DECLARE(qoriq_clockgen_1, "fsl,qoriq-clockgen-1.0", clockgen_init);
>  CLK_OF_DECLARE(qoriq_clockgen_2, "fsl,qoriq-clockgen-2.0", clockgen_init);
> +CLK_OF_DECLARE(qoriq_clockgen_b4420, "fsl,b4420-clockgen", clockgen_init);
> +CLK_OF_DECLARE(qoriq_clockgen_b4860, "fsl,b4860-clockgen", clockgen_init);
>  CLK_OF_DECLARE(qoriq_clockgen_ls1012a, "fsl,ls1012a-clockgen", clockgen_init);
>  CLK_OF_DECLARE(qoriq_clockgen_ls1021a, "fsl,ls1021a-clockgen", clockgen_init);
>  CLK_OF_DECLARE(qoriq_clockgen_ls1043a, "fsl,ls1043a-clockgen", clockgen_init);
>  CLK_OF_DECLARE(qoriq_clockgen_ls1046a, "fsl,ls1046a-clockgen", clockgen_init);
>  CLK_OF_DECLARE(qoriq_clockgen_ls1088a, "fsl,ls1088a-clockgen", clockgen_init);
>  CLK_OF_DECLARE(qoriq_clockgen_ls2080a, "fsl,ls2080a-clockgen", clockgen_init);
> +CLK_OF_DECLARE(qoriq_clockgen_p2041, "fsl,p2041-clockgen", clockgen_init);
> +CLK_OF_DECLARE(qoriq_clockgen_p3041, "fsl,p3041-clockgen", clockgen_init);
> +CLK_OF_DECLARE(qoriq_clockgen_p4080, "fsl,p4080-clockgen", clockgen_init);
> +CLK_OF_DECLARE(qoriq_clockgen_p5020, "fsl,p5020-clockgen", clockgen_init);
> +CLK_OF_DECLARE(qoriq_clockgen_p5040, "fsl,p5040-clockgen", clockgen_init);
> +CLK_OF_DECLARE(qoriq_clockgen_t1023, "fsl,t1023-clockgen", clockgen_init);
> +CLK_OF_DECLARE(qoriq_clockgen_t1040, "fsl,t1040-clockgen", clockgen_init);
> +CLK_OF_DECLARE(qoriq_clockgen_t2080, "fsl,t2080-clockgen", clockgen_init);
> +CLK_OF_DECLARE(qoriq_clockgen_t4240, "fsl,t4240-clockgen", clockgen_init);

Some of these compatibles aren't documented. What happened to the
binding patch to add more compatible strings?
Andy Tang Nov. 7, 2018, 12:52 a.m. UTC | #2 
Hi Stephen,

> -----Original Message-----
> From: Stephen Boyd <sboyd@kernel.org>
> Sent: 2018年11月7日 1:25
> To: Andy Tang <andy.tang@nxp.com>; mturquette@baylibre.com
> Cc: linux-clk@vger.kernel.org; linux-kernel@vger.kernel.org; Andy Tang
> <andy.tang@nxp.com>
> Subject: Re: [PATCH v3] clk: qoriq: add more chips support
> 
> Quoting Yuantian Tang (2018-10-31 00:46:16)
> > diff --git a/drivers/clk/clk-qoriq.c b/drivers/clk/clk-qoriq.c index
> > 4c30b6e..5baa9e0 100644
> > --- a/drivers/clk/clk-qoriq.c
> > +++ b/drivers/clk/clk-qoriq.c
> > @@ -1418,12 +1418,23 @@ static void __init clockgen_init(struct
> > device_node *np)
> >
> >  CLK_OF_DECLARE(qoriq_clockgen_1, "fsl,qoriq-clockgen-1.0",
> > clockgen_init);  CLK_OF_DECLARE(qoriq_clockgen_2,
> > "fsl,qoriq-clockgen-2.0", clockgen_init);
> > +CLK_OF_DECLARE(qoriq_clockgen_b4420, "fsl,b4420-clockgen",
> > +clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_b4860,
> > +"fsl,b4860-clockgen", clockgen_init);
> >  CLK_OF_DECLARE(qoriq_clockgen_ls1012a, "fsl,ls1012a-clockgen",
> > clockgen_init);  CLK_OF_DECLARE(qoriq_clockgen_ls1021a,
> > "fsl,ls1021a-clockgen", clockgen_init);
> > CLK_OF_DECLARE(qoriq_clockgen_ls1043a, "fsl,ls1043a-clockgen",
> > clockgen_init);  CLK_OF_DECLARE(qoriq_clockgen_ls1046a,
> > "fsl,ls1046a-clockgen", clockgen_init);
> > CLK_OF_DECLARE(qoriq_clockgen_ls1088a, "fsl,ls1088a-clockgen",
> > clockgen_init);  CLK_OF_DECLARE(qoriq_clockgen_ls2080a,
> > "fsl,ls2080a-clockgen", clockgen_init);
> > +CLK_OF_DECLARE(qoriq_clockgen_p2041, "fsl,p2041-clockgen",
> > +clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_p3041,
> > +"fsl,p3041-clockgen", clockgen_init);
> > +CLK_OF_DECLARE(qoriq_clockgen_p4080, "fsl,p4080-clockgen",
> > +clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_p5020,
> > +"fsl,p5020-clockgen", clockgen_init);
> > +CLK_OF_DECLARE(qoriq_clockgen_p5040, "fsl,p5040-clockgen",
> > +clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_t1023,
> > +"fsl,t1023-clockgen", clockgen_init);
> > +CLK_OF_DECLARE(qoriq_clockgen_t1040, "fsl,t1040-clockgen",
> > +clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_t2080,
> > +"fsl,t2080-clockgen", clockgen_init);
> > +CLK_OF_DECLARE(qoriq_clockgen_t4240, "fsl,t4240-clockgen",
> > +clockgen_init);
> 
> Some of these compatibles aren't documented. What happened to the
> binding patch to add more compatible strings?
Nothing happened. Binding patch will be merged to PowerPC tree soon. But it will take time to
get to mainline tree or your tree.

BR,
Andy
Stephen Boyd Nov. 7, 2018, 11:26 p.m. UTC | #3 
Quoting Andy Tang (2018-11-06 16:52:19)
> Hi Stephen,
> 
> > -----Original Message-----
> > From: Stephen Boyd <sboyd@kernel.org>
> > Sent: 2018年11月7日 1:25
> > To: Andy Tang <andy.tang@nxp.com>; mturquette@baylibre.com
> > Cc: linux-clk@vger.kernel.org; linux-kernel@vger.kernel.org; Andy Tang
> > <andy.tang@nxp.com>
> > Subject: Re: [PATCH v3] clk: qoriq: add more chips support
> > 
> > Quoting Yuantian Tang (2018-10-31 00:46:16)
> > > diff --git a/drivers/clk/clk-qoriq.c b/drivers/clk/clk-qoriq.c index
> > > 4c30b6e..5baa9e0 100644
> > > --- a/drivers/clk/clk-qoriq.c
> > > +++ b/drivers/clk/clk-qoriq.c
> > > @@ -1418,12 +1418,23 @@ static void __init clockgen_init(struct
> > > device_node *np)
> > >
> > >  CLK_OF_DECLARE(qoriq_clockgen_1, "fsl,qoriq-clockgen-1.0",
> > > clockgen_init);  CLK_OF_DECLARE(qoriq_clockgen_2,
> > > "fsl,qoriq-clockgen-2.0", clockgen_init);
> > > +CLK_OF_DECLARE(qoriq_clockgen_b4420, "fsl,b4420-clockgen",
> > > +clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_b4860,
> > > +"fsl,b4860-clockgen", clockgen_init);
> > >  CLK_OF_DECLARE(qoriq_clockgen_ls1012a, "fsl,ls1012a-clockgen",
> > > clockgen_init);  CLK_OF_DECLARE(qoriq_clockgen_ls1021a,
> > > "fsl,ls1021a-clockgen", clockgen_init);
> > > CLK_OF_DECLARE(qoriq_clockgen_ls1043a, "fsl,ls1043a-clockgen",
> > > clockgen_init);  CLK_OF_DECLARE(qoriq_clockgen_ls1046a,
> > > "fsl,ls1046a-clockgen", clockgen_init);
> > > CLK_OF_DECLARE(qoriq_clockgen_ls1088a, "fsl,ls1088a-clockgen",
> > > clockgen_init);  CLK_OF_DECLARE(qoriq_clockgen_ls2080a,
> > > "fsl,ls2080a-clockgen", clockgen_init);
> > > +CLK_OF_DECLARE(qoriq_clockgen_p2041, "fsl,p2041-clockgen",
> > > +clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_p3041,
> > > +"fsl,p3041-clockgen", clockgen_init);
> > > +CLK_OF_DECLARE(qoriq_clockgen_p4080, "fsl,p4080-clockgen",
> > > +clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_p5020,
> > > +"fsl,p5020-clockgen", clockgen_init);
> > > +CLK_OF_DECLARE(qoriq_clockgen_p5040, "fsl,p5040-clockgen",
> > > +clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_t1023,
> > > +"fsl,t1023-clockgen", clockgen_init);
> > > +CLK_OF_DECLARE(qoriq_clockgen_t1040, "fsl,t1040-clockgen",
> > > +clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_t2080,
> > > +"fsl,t2080-clockgen", clockgen_init);
> > > +CLK_OF_DECLARE(qoriq_clockgen_t4240, "fsl,t4240-clockgen",
> > > +clockgen_init);
> > 
> > Some of these compatibles aren't documented. What happened to the
> > binding patch to add more compatible strings?
> Nothing happened. Binding patch will be merged to PowerPC tree soon. But it will take time to
> get to mainline tree or your tree.
> 

Ok. So I'll just merge this patch into clk-next then. Thanks!
diff mbox series

Patch

diff --git a/drivers/clk/clk-qoriq.c b/drivers/clk/clk-qoriq.c
index 4c30b6e..5baa9e0 100644
--- a/drivers/clk/clk-qoriq.c
+++ b/drivers/clk/clk-qoriq.c
@@ -1418,12 +1418,23 @@  static void __init clockgen_init(struct device_node *np)
 
 CLK_OF_DECLARE(qoriq_clockgen_1, "fsl,qoriq-clockgen-1.0", clockgen_init);
 CLK_OF_DECLARE(qoriq_clockgen_2, "fsl,qoriq-clockgen-2.0", clockgen_init);
+CLK_OF_DECLARE(qoriq_clockgen_b4420, "fsl,b4420-clockgen", clockgen_init);
+CLK_OF_DECLARE(qoriq_clockgen_b4860, "fsl,b4860-clockgen", clockgen_init);
 CLK_OF_DECLARE(qoriq_clockgen_ls1012a, "fsl,ls1012a-clockgen", clockgen_init);
 CLK_OF_DECLARE(qoriq_clockgen_ls1021a, "fsl,ls1021a-clockgen", clockgen_init);
 CLK_OF_DECLARE(qoriq_clockgen_ls1043a, "fsl,ls1043a-clockgen", clockgen_init);
 CLK_OF_DECLARE(qoriq_clockgen_ls1046a, "fsl,ls1046a-clockgen", clockgen_init);
 CLK_OF_DECLARE(qoriq_clockgen_ls1088a, "fsl,ls1088a-clockgen", clockgen_init);
 CLK_OF_DECLARE(qoriq_clockgen_ls2080a, "fsl,ls2080a-clockgen", clockgen_init);
+CLK_OF_DECLARE(qoriq_clockgen_p2041, "fsl,p2041-clockgen", clockgen_init);
+CLK_OF_DECLARE(qoriq_clockgen_p3041, "fsl,p3041-clockgen", clockgen_init);
+CLK_OF_DECLARE(qoriq_clockgen_p4080, "fsl,p4080-clockgen", clockgen_init);
+CLK_OF_DECLARE(qoriq_clockgen_p5020, "fsl,p5020-clockgen", clockgen_init);
+CLK_OF_DECLARE(qoriq_clockgen_p5040, "fsl,p5040-clockgen", clockgen_init);
+CLK_OF_DECLARE(qoriq_clockgen_t1023, "fsl,t1023-clockgen", clockgen_init);
+CLK_OF_DECLARE(qoriq_clockgen_t1040, "fsl,t1040-clockgen", clockgen_init);
+CLK_OF_DECLARE(qoriq_clockgen_t2080, "fsl,t2080-clockgen", clockgen_init);
+CLK_OF_DECLARE(qoriq_clockgen_t4240, "fsl,t4240-clockgen", clockgen_init);
 
 /* Legacy nodes */
 CLK_OF_DECLARE(qoriq_sysclk_1, "fsl,qoriq-sysclk-1.0", sysclk_init);