Message ID | 20181031215622.27690-1-kwolf@redhat.com (mailing list archive) |
---|---|
Headers | show |
Series | file-posix: Simplify delegation to worker thread | expand |
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20181031215622.27690-1-kwolf@redhat.com Subject: [Qemu-devel] [PATCH 00/12] file-posix: Simplify delegation to worker thread === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' f3d24f259d file-posix: Avoid aio_worker() for QEMU_AIO_IOCTL a20af5e7d5 file-posix: Switch to .bdrv_co_ioctl 86c8cd0ca9 file-posix: Remove paio_submit_co() a6798de879 file-posix: Avoid aio_worker() for QEMU_AIO_READ/WRITE f667c83e70 file-posix: Move read/write operation logic out of aio_worker() 028fa45b36 file-posix: Avoid aio_worker() for QEMU_AIO_FLUSH 992060b92c file-posix: Avoid aio_worker() for QEMU_AIO_DISCARD b27306c38f file-posix: Avoid aio_worker() for QEMU_AIO_WRITE_ZEROES 934194f753 file-posix: Avoid aio_worker() for QEMU_AIO_COPY_RANGE ab3479aa9e file-posix: Avoid aio_worker() for QEMU_AIO_TRUNCATE 055cea24a4 file-posix: Factor out raw_thread_pool_submit() 91834b3fb8 file-posix: Reorganise RawPosixAIOData === OUTPUT BEGIN === Checking PATCH 1/12: file-posix: Reorganise RawPosixAIOData... ERROR: suspect code indent for conditional statements (8, 13) #96: FILE: block/file-posix.c:1278: + if (aiocb->io.niov == 1) { + return handle_aiocb_rw_linear(aiocb, aiocb->io.iov->iov_base); total: 1 errors, 0 warnings, 203 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 2/12: file-posix: Factor out raw_thread_pool_submit()... Checking PATCH 3/12: file-posix: Avoid aio_worker() for QEMU_AIO_TRUNCATE... Checking PATCH 4/12: file-posix: Avoid aio_worker() for QEMU_AIO_COPY_RANGE... Checking PATCH 5/12: file-posix: Avoid aio_worker() for QEMU_AIO_WRITE_ZEROES... Checking PATCH 6/12: file-posix: Avoid aio_worker() for QEMU_AIO_DISCARD... Checking PATCH 7/12: file-posix: Avoid aio_worker() for QEMU_AIO_FLUSH... Checking PATCH 8/12: file-posix: Move read/write operation logic out of aio_worker()... ERROR: suspect code indent for conditional statements (8, 13) #25: FILE: block/file-posix.c:1279: if (aiocb->io.niov == 1) { + nbytes = handle_aiocb_rw_linear(aiocb, aiocb->io.iov->iov_base); total: 1 errors, 0 warnings, 73 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 9/12: file-posix: Avoid aio_worker() for QEMU_AIO_READ/WRITE... Checking PATCH 10/12: file-posix: Remove paio_submit_co()... Checking PATCH 11/12: file-posix: Switch to .bdrv_co_ioctl... Checking PATCH 12/12: file-posix: Avoid aio_worker() for QEMU_AIO_IOCTL... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Am 31.10.2018 um 22:56 hat Kevin Wolf geschrieben: > This series cleans up and simplifies the code that calls worker thread > functions for the various operations in the file-posix driver. This > results in less indirection and better readability as well as reduced > heap allocations because we can store ACBs on the coroutine stack now. ping?
Am 12.11.2018 um 17:50 hat Kevin Wolf geschrieben: > Am 31.10.2018 um 22:56 hat Kevin Wolf geschrieben: > > This series cleans up and simplifies the code that calls worker thread > > functions for the various operations in the file-posix driver. This > > results in less indirection and better readability as well as reduced > > heap allocations because we can store ACBs on the coroutine stack now. > > ping? Seems nobody has objections, so applied to block-next. Kevin