| Message ID | 1532010590-475-1-git-send-email-bpothuno@codeaurora.org (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Johannes Berg |
| Headers | show |
Hi Johannes, Now that corresponding driver patches are merged, could you please let me know if anything is left from our end for merging this patch? Regards, Balaji. On 2018-07-19 19:59, Balaji Pothunoori wrote: > This patch is to display the average ack signal, > last ack signal of tx ack packets. > > Signed-off-by: Balaji Pothunoori <bpothuno@codeaurora.org> > --- > v5: > * Rebased, No changes > v4: > * Changed the subject > * Added last ack signal support and renamed avg ack signal macro > v3: > * Added version no > v2: > * Removed nl80211.h changes and modified the commit log > > station.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/station.c b/station.c > index 38c5f91..fd38043 100644 > --- a/station.c > +++ b/station.c > @@ -308,6 +308,8 @@ static int print_sta_handler(struct nl_msg *msg, > void *arg) > [NL80211_STA_INFO_TID_STATS] = { .type = NLA_NESTED }, > [NL80211_STA_INFO_BSS_PARAM] = { .type = NLA_NESTED }, > [NL80211_STA_INFO_RX_DURATION] = { .type = NLA_U64 }, > + [NL80211_STA_INFO_ACK_SIGNAL] = {.type = NLA_U8 }, > + [NL80211_STA_INFO_ACK_SIGNAL_AVG] = { .type = NLA_U8 }, > }; > char *chain; > > @@ -409,6 +411,14 @@ static int print_sta_handler(struct nl_msg *msg, > void *arg) > printf("\n\trx duration:\t%lld us", > (unsigned long > long)nla_get_u64(sinfo[NL80211_STA_INFO_RX_DURATION])); > > + if (sinfo[NL80211_STA_INFO_ACK_SIGNAL]) > + printf("\n\tlast ack signal:%d dBm", > + (int8_t)nla_get_u8(sinfo[NL80211_STA_INFO_ACK_SIGNAL])); > + > + if (sinfo[NL80211_STA_INFO_ACK_SIGNAL_AVG]) > + printf("\n\tavg ack signal:\t%d dBm", > + (int8_t)nla_get_u8(sinfo[NL80211_STA_INFO_ACK_SIGNAL_AVG])); > + > if (sinfo[NL80211_STA_INFO_EXPECTED_THROUGHPUT]) { > uint32_t thr;
On Mon, 2018-11-12 at 21:56 +0530, Balaji Pothunoori wrote: > Hi Johannes, > > Now that corresponding driver patches are merged, could you please let > me know if anything is left from our end for merging this patch? Oh, I marked this as "changes requested" since I thought the updates we discussed on the kernel side would require changes here (IIRC we talked about changing some names?) If it applies and compiles as is, I guess best if you just resend, since I no longer have it in patchwork and am on vacation this week. johannes
Hi Johannes, Seems to be v5 patch is applied on "Jul 19 19:59:50 2018" but i couldn't get acknowledgement for it. commit id "d227267148275c63041aca62f4da5d5f07354a82" kindly ignore my earlier comments. Regards, Balaji. On 2018-11-13 00:32, Johannes Berg wrote: > On Mon, 2018-11-12 at 21:56 +0530, Balaji Pothunoori wrote: >> Hi Johannes, >> >> Now that corresponding driver patches are merged, could you please let >> me know if anything is left from our end for merging this patch? > > Oh, I marked this as "changes requested" since I thought the updates we > discussed on the kernel side would require changes here (IIRC we talked > about changing some names?) > > If it applies and compiles as is, I guess best if you just resend, > since > I no longer have it in patchwork and am on vacation this week. > > johannes
diff --git a/station.c b/station.c index 38c5f91..fd38043 100644 --- a/station.c +++ b/station.c @@ -308,6 +308,8 @@ static int print_sta_handler(struct nl_msg *msg, void *arg) [NL80211_STA_INFO_TID_STATS] = { .type = NLA_NESTED }, [NL80211_STA_INFO_BSS_PARAM] = { .type = NLA_NESTED }, [NL80211_STA_INFO_RX_DURATION] = { .type = NLA_U64 }, + [NL80211_STA_INFO_ACK_SIGNAL] = {.type = NLA_U8 }, + [NL80211_STA_INFO_ACK_SIGNAL_AVG] = { .type = NLA_U8 }, }; char *chain; @@ -409,6 +411,14 @@ static int print_sta_handler(struct nl_msg *msg, void *arg) printf("\n\trx duration:\t%lld us", (unsigned long long)nla_get_u64(sinfo[NL80211_STA_INFO_RX_DURATION])); + if (sinfo[NL80211_STA_INFO_ACK_SIGNAL]) + printf("\n\tlast ack signal:%d dBm", + (int8_t)nla_get_u8(sinfo[NL80211_STA_INFO_ACK_SIGNAL])); + + if (sinfo[NL80211_STA_INFO_ACK_SIGNAL_AVG]) + printf("\n\tavg ack signal:\t%d dBm", + (int8_t)nla_get_u8(sinfo[NL80211_STA_INFO_ACK_SIGNAL_AVG])); + if (sinfo[NL80211_STA_INFO_EXPECTED_THROUGHPUT]) { uint32_t thr;
This patch is to display the average ack signal, last ack signal of tx ack packets. Signed-off-by: Balaji Pothunoori <bpothuno@codeaurora.org> --- v5: * Rebased, No changes v4: * Changed the subject * Added last ack signal support and renamed avg ack signal macro v3: * Added version no v2: * Removed nl80211.h changes and modified the commit log station.c | 10 ++++++++++ 1 file changed, 10 insertions(+)