| Message ID | 1537826946-18942-1-git-send-email-thor.thayer@linux.intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add SOCFPGA System Manager | expand |
Hi On 09/24/2018 05:09 PM, thor.thayer@linux.intel.com wrote: > From: Thor Thayer <thor.thayer@linux.intel.com> > > Add MFD driver for ARM64 SOCFPGA System Manager to steer > System Manager calls appropriately. > The SOCFPGA System Manager includes registers from several > SOC peripherals. > > On ARM32, syscon handles this aggregated register grouping. > Redirect System Manager calls to syscon for ARM32 SOCFPGA > systems. > > The ARM64 System Manager can only be accessed from priority > level EL3 so this new MFD driver handles the calls to EL3. > > Thor Thayer (4): > mfd: altera-sysmgr: Add SOCFPGA System Manager abstraction > ARM: socfpga_defconfig: Enable CONFIG_MTD_ALTERA_SYSMGR > arm64: defconfig: Enable CONFIG_MTD_ALTERA_SYSMGR > net: stmmac: socfpga: Convert to shared System Manager driver > > MAINTAINERS | 6 + > arch/arm/configs/socfpga_defconfig | 1 + > arch/arm64/configs/defconfig | 1 + > drivers/mfd/Kconfig | 9 + > drivers/mfd/Makefile | 1 + > drivers/mfd/altera-sysmgr.c | 310 +++++++++++++++++++++ > .../net/ethernet/stmicro/stmmac/dwmac-socfpga.c | 4 +- > include/linux/mfd/altera-sysmgr.h | 113 ++++++++ > 8 files changed, 444 insertions(+), 1 deletion(-) > create mode 100644 drivers/mfd/altera-sysmgr.c > create mode 100644 include/linux/mfd/altera-sysmgr.h > Gentle ping. Thor
Gentle ping again... Any comments on this patch series? On 10/10/2018 09:42 AM, Thor Thayer wrote: > Hi > On 09/24/2018 05:09 PM, thor.thayer@linux.intel.com wrote: >> From: Thor Thayer <thor.thayer@linux.intel.com> >> >> Add MFD driver for ARM64 SOCFPGA System Manager to steer >> System Manager calls appropriately. >> The SOCFPGA System Manager includes registers from several >> SOC peripherals. >> >> On ARM32, syscon handles this aggregated register grouping. >> Redirect System Manager calls to syscon for ARM32 SOCFPGA >> systems. >> >> The ARM64 System Manager can only be accessed from priority >> level EL3 so this new MFD driver handles the calls to EL3. >> >> Thor Thayer (4): >> mfd: altera-sysmgr: Add SOCFPGA System Manager abstraction >> ARM: socfpga_defconfig: Enable CONFIG_MTD_ALTERA_SYSMGR >> arm64: defconfig: Enable CONFIG_MTD_ALTERA_SYSMGR >> net: stmmac: socfpga: Convert to shared System Manager driver >> >> MAINTAINERS | 6 + >> arch/arm/configs/socfpga_defconfig | 1 + >> arch/arm64/configs/defconfig | 1 + >> drivers/mfd/Kconfig | 9 + >> drivers/mfd/Makefile | 1 + >> drivers/mfd/altera-sysmgr.c | 310 >> +++++++++++++++++++++ >> .../net/ethernet/stmicro/stmmac/dwmac-socfpga.c | 4 +- >> include/linux/mfd/altera-sysmgr.h | 113 ++++++++ >> 8 files changed, 444 insertions(+), 1 deletion(-) >> create mode 100644 drivers/mfd/altera-sysmgr.c >> create mode 100644 include/linux/mfd/altera-sysmgr.h >> > Gentle ping. > > Thor
On Wed, 17 Oct 2018, Thor Thayer wrote: > On 10/10/2018 09:42 AM, Thor Thayer wrote: > > Hi > > On 09/24/2018 05:09 PM, thor.thayer@linux.intel.com wrote: > > > From: Thor Thayer <thor.thayer@linux.intel.com> > > > > > > Add MFD driver for ARM64 SOCFPGA System Manager to steer > > > System Manager calls appropriately. > > > The SOCFPGA System Manager includes registers from several > > > SOC peripherals. > > > > > > On ARM32, syscon handles this aggregated register grouping. > > > Redirect System Manager calls to syscon for ARM32 SOCFPGA > > > systems. > > > > > > The ARM64 System Manager can only be accessed from priority > > > level EL3 so this new MFD driver handles the calls to EL3. > > > > > > Thor Thayer (4): > > > mfd: altera-sysmgr: Add SOCFPGA System Manager abstraction > > > ARM: socfpga_defconfig: Enable CONFIG_MTD_ALTERA_SYSMGR > > > arm64: defconfig: Enable CONFIG_MTD_ALTERA_SYSMGR > > > net: stmmac: socfpga: Convert to shared System Manager driver > > > > > > MAINTAINERS | 6 + > > > arch/arm/configs/socfpga_defconfig | 1 + > > > arch/arm64/configs/defconfig | 1 + > > > drivers/mfd/Kconfig | 9 + > > > drivers/mfd/Makefile | 1 + > > > drivers/mfd/altera-sysmgr.c | 310 > > > +++++++++++++++++++++ > > > .../net/ethernet/stmicro/stmmac/dwmac-socfpga.c | 4 +- > > > include/linux/mfd/altera-sysmgr.h | 113 ++++++++ > > > 8 files changed, 444 insertions(+), 1 deletion(-) > > > create mode 100644 drivers/mfd/altera-sysmgr.c > > > create mode 100644 include/linux/mfd/altera-sysmgr.h > > > > > Gentle ping. > > Gentle ping again... > > Any comments on this patch series? "Please don't send content free pings and please allow a reasonable time for review. People get busy, go on holiday, attend conferences and so on so unless there is some reason for urgency (like critical bug fixes) please allow at least a couple of weeks for review. If there have been review comments then people may be waiting for those to be addressed. Sending content free pings just adds to the mail volume (if they are seen at all) and if something has gone wrong you'll have to resend the patches anyway so resending with any comments addressed is generally a much better approach." In this case, the we are too late in the series to have these applied. Maintainers are generally preparing their submissions for the merge-window. The MFD component of this set is marked as "To Review" and I will get around to it when time is more abundant.
Hi On 10/19/18 1:16 AM, Lee Jones wrote: > On Wed, 17 Oct 2018, Thor Thayer wrote: > > >> On 10/10/2018 09:42 AM, Thor Thayer wrote: >>> Hi >>> On 09/24/2018 05:09 PM, thor.thayer@linux.intel.com wrote: >>>> From: Thor Thayer <thor.thayer@linux.intel.com> >>>> >>>> Add MFD driver for ARM64 SOCFPGA System Manager to steer >>>> System Manager calls appropriately. >>>> The SOCFPGA System Manager includes registers from several >>>> SOC peripherals. >>>> >>>> On ARM32, syscon handles this aggregated register grouping. >>>> Redirect System Manager calls to syscon for ARM32 SOCFPGA >>>> systems. >>>> >>>> The ARM64 System Manager can only be accessed from priority >>>> level EL3 so this new MFD driver handles the calls to EL3. >>>> >>>> Thor Thayer (4): >>>> mfd: altera-sysmgr: Add SOCFPGA System Manager abstraction >>>> ARM: socfpga_defconfig: Enable CONFIG_MTD_ALTERA_SYSMGR >>>> arm64: defconfig: Enable CONFIG_MTD_ALTERA_SYSMGR >>>> net: stmmac: socfpga: Convert to shared System Manager driver >>>> >>>> MAINTAINERS | 6 + >>>> arch/arm/configs/socfpga_defconfig | 1 + >>>> arch/arm64/configs/defconfig | 1 + >>>> drivers/mfd/Kconfig | 9 + >>>> drivers/mfd/Makefile | 1 + >>>> drivers/mfd/altera-sysmgr.c | 310 >>>> +++++++++++++++++++++ >>>> .../net/ethernet/stmicro/stmmac/dwmac-socfpga.c | 4 +- >>>> include/linux/mfd/altera-sysmgr.h | 113 ++++++++ >>>> 8 files changed, 444 insertions(+), 1 deletion(-) >>>> create mode 100644 drivers/mfd/altera-sysmgr.c >>>> create mode 100644 include/linux/mfd/altera-sysmgr.h >>>> >>> Gentle ping. >> >> Gentle ping again... >> >> Any comments on this patch series? > > "Please don't send content free pings and please allow a reasonable time > for review. People get busy, go on holiday, attend conferences and so > on so unless there is some reason for urgency (like critical bug fixes) > please allow at least a couple of weeks for review. If there have been > review comments then people may be waiting for those to be addressed. > Sending content free pings just adds to the mail volume (if they are > seen at all) and if something has gone wrong you'll have to resend the > patches anyway so resending with any comments addressed is generally a > much better approach." > > In this case, the we are too late in the series to have these > applied. Maintainers are generally preparing their submissions for > the merge-window. The MFD component of this set is marked as "To > Review" and I will get around to it when time is more abundant. > Gentle ping now that the merge window is over. I'm not clear on the scolding for content free pings. Other pings I've seen just reference the patch series summary instead of each patch individually. It seems like pings for each patch would add more to the mail volume than the summary but perhaps I'm misunderstanding something. I'm happy to ping each patch separately if that is preferable. Series can be found here: https://patchwork.kernel.org/cover/10612891/ [PATCH 1/4] mfd: altera-sysmgr: Add SOCFPGA System Manager [PATCH 2/4] ARM: socfpga_defconfig: Enable CONFIG_MTD_ALTERA_SYSMGR [PATCH 3/4] arm64: defconfig: Enable CONFIG_MTD_ALTERA_SYSMGR [PATCH 4/4] net: stmmac: socfpga: Use shared System Manager driver Thanks, Thor
On Fri, 09 Nov 2018, Thor Thayer wrote: > Hi > > On 10/19/18 1:16 AM, Lee Jones wrote: > > On Wed, 17 Oct 2018, Thor Thayer wrote: > > > > > > > On 10/10/2018 09:42 AM, Thor Thayer wrote: > > > > Hi > > > > On 09/24/2018 05:09 PM, thor.thayer@linux.intel.com wrote: > > > > > From: Thor Thayer <thor.thayer@linux.intel.com> > > > > > > > > > > Add MFD driver for ARM64 SOCFPGA System Manager to steer > > > > > System Manager calls appropriately. > > > > > The SOCFPGA System Manager includes registers from several > > > > > SOC peripherals. > > > > > > > > > > On ARM32, syscon handles this aggregated register grouping. > > > > > Redirect System Manager calls to syscon for ARM32 SOCFPGA > > > > > systems. > > > > > > > > > > The ARM64 System Manager can only be accessed from priority > > > > > level EL3 so this new MFD driver handles the calls to EL3. > > > > > > > > > > Thor Thayer (4): > > > > > mfd: altera-sysmgr: Add SOCFPGA System Manager abstraction > > > > > ARM: socfpga_defconfig: Enable CONFIG_MTD_ALTERA_SYSMGR > > > > > arm64: defconfig: Enable CONFIG_MTD_ALTERA_SYSMGR > > > > > net: stmmac: socfpga: Convert to shared System Manager driver > > > > > > > > > > MAINTAINERS | 6 + > > > > > arch/arm/configs/socfpga_defconfig | 1 + > > > > > arch/arm64/configs/defconfig | 1 + > > > > > drivers/mfd/Kconfig | 9 + > > > > > drivers/mfd/Makefile | 1 + > > > > > drivers/mfd/altera-sysmgr.c | 310 > > > > > +++++++++++++++++++++ > > > > > .../net/ethernet/stmicro/stmmac/dwmac-socfpga.c | 4 +- > > > > > include/linux/mfd/altera-sysmgr.h | 113 ++++++++ > > > > > 8 files changed, 444 insertions(+), 1 deletion(-) > > > > > create mode 100644 drivers/mfd/altera-sysmgr.c > > > > > create mode 100644 include/linux/mfd/altera-sysmgr.h > > > > > > > > > Gentle ping. > > > > > > Gentle ping again... > > > > > > Any comments on this patch series? > > > > "Please don't send content free pings and please allow a reasonable time > > for review. People get busy, go on holiday, attend conferences and so > > on so unless there is some reason for urgency (like critical bug fixes) > > please allow at least a couple of weeks for review. If there have been > > review comments then people may be waiting for those to be addressed. > > Sending content free pings just adds to the mail volume (if they are > > seen at all) and if something has gone wrong you'll have to resend the > > patches anyway so resending with any comments addressed is generally a > > much better approach." > > > > In this case, the we are too late in the series to have these > > applied. Maintainers are generally preparing their submissions for > > the merge-window. The MFD component of this set is marked as "To > > Review" and I will get around to it when time is more abundant. > > > > Gentle ping now that the merge window is over. > > I'm not clear on the scolding for content free pings. > > Other pings I've seen just reference the patch series summary instead of > each patch individually. It seems like pings for each patch would add more > to the mail volume than the summary but perhaps I'm misunderstanding > something. I'm happy to ping each patch separately if that is preferable. Please don't ping at all. If you would like to attract attention, please resend your patch-set with s/[PATCH]/[RESEND]/. > Series can be found here: > https://patchwork.kernel.org/cover/10612891/ > > [PATCH 1/4] mfd: altera-sysmgr: Add SOCFPGA System Manager > [PATCH 2/4] ARM: socfpga_defconfig: Enable CONFIG_MTD_ALTERA_SYSMGR > [PATCH 3/4] arm64: defconfig: Enable CONFIG_MTD_ALTERA_SYSMGR > [PATCH 4/4] net: stmmac: socfpga: Use shared System Manager driver > > Thanks, > > Thor
From: Thor Thayer <thor.thayer@linux.intel.com> Add MFD driver for ARM64 SOCFPGA System Manager to steer System Manager calls appropriately. The SOCFPGA System Manager includes registers from several SOC peripherals. On ARM32, syscon handles this aggregated register grouping. Redirect System Manager calls to syscon for ARM32 SOCFPGA systems. The ARM64 System Manager can only be accessed from priority level EL3 so this new MFD driver handles the calls to EL3. Thor Thayer (4): mfd: altera-sysmgr: Add SOCFPGA System Manager abstraction ARM: socfpga_defconfig: Enable CONFIG_MTD_ALTERA_SYSMGR arm64: defconfig: Enable CONFIG_MTD_ALTERA_SYSMGR net: stmmac: socfpga: Convert to shared System Manager driver MAINTAINERS | 6 + arch/arm/configs/socfpga_defconfig | 1 + arch/arm64/configs/defconfig | 1 + drivers/mfd/Kconfig | 9 + drivers/mfd/Makefile | 1 + drivers/mfd/altera-sysmgr.c | 310 +++++++++++++++++++++ .../net/ethernet/stmicro/stmmac/dwmac-socfpga.c | 4 +- include/linux/mfd/altera-sysmgr.h | 113 ++++++++ 8 files changed, 444 insertions(+), 1 deletion(-) create mode 100644 drivers/mfd/altera-sysmgr.c create mode 100644 include/linux/mfd/altera-sysmgr.h