Message ID | 1540886988-27696-1-git-send-email-yong.deng@magewell.com (mailing list archive) |
---|---|
Headers | show |
Series | Initial Allwinner V3s CSI Support | expand |
Hi Yong, On Tue, Oct 30, 2018 at 04:09:48PM +0800, Yong Deng wrote: > I can't make v4l2-compliance always happy. > The V3s CSI support many pixformats. But they are not always available. > It's dependent on the input bus format (MEDIA_BUS_FMT_*). > Example: > V4L2_PIX_FMT_SBGGR8: MEDIA_BUS_FMT_SBGGR8_1X8 > V4L2_PIX_FMT_YUYV: MEDIA_BUS_FMT_YUYV8_2X8 > But I can't get the subdev's format code before starting stream as the > subdev may change it. So I can't know which pixformats are available. > So I exports all the pixformats supported by SoC. > The result is the app (v4l2-compliance) is likely to fail on streamon. > > This patchset add initial support for Allwinner V3s CSI. > > Allwinner V3s SoC features a CSI module with parallel interface. > > This patchset implement a v4l2 framework driver and add a binding > documentation for it. I've tested this version today, and I needed this patch to make it work on top of v4.20: http://code.bulix.org/9o8fw5-503690?raw Once that patch applied, my tests were working as expected. If that make sense, could you resubmit a new version with these merged so that we can try to target 4.21? Thanks! Maxime
Hi Maxime, On Tue, 13 Nov 2018 14:35:18 +0100 Maxime Ripard <maxime.ripard@bootlin.com> wrote: > Hi Yong, > > On Tue, Oct 30, 2018 at 04:09:48PM +0800, Yong Deng wrote: > > I can't make v4l2-compliance always happy. > > The V3s CSI support many pixformats. But they are not always available. > > It's dependent on the input bus format (MEDIA_BUS_FMT_*). > > Example: > > V4L2_PIX_FMT_SBGGR8: MEDIA_BUS_FMT_SBGGR8_1X8 > > V4L2_PIX_FMT_YUYV: MEDIA_BUS_FMT_YUYV8_2X8 > > But I can't get the subdev's format code before starting stream as the > > subdev may change it. So I can't know which pixformats are available. > > So I exports all the pixformats supported by SoC. > > The result is the app (v4l2-compliance) is likely to fail on streamon. > > > > This patchset add initial support for Allwinner V3s CSI. > > > > Allwinner V3s SoC features a CSI module with parallel interface. > > > > This patchset implement a v4l2 framework driver and add a binding > > documentation for it. > > I've tested this version today, and I needed this patch to make it > work on top of v4.20: > http://code.bulix.org/9o8fw5-503690?raw > > Once that patch applied, my tests were working as expected. > > If that make sense, could you resubmit a new version with these merged > so that we can try to target 4.21? OK. I will check it. Thanks, Yong
On Tue, Oct 30, 2018 at 04:09:48PM +0800, Yong Deng wrote: > I can't make v4l2-compliance always happy. > The V3s CSI support many pixformats. But they are not always available. > It's dependent on the input bus format (MEDIA_BUS_FMT_*). > Example: > V4L2_PIX_FMT_SBGGR8: MEDIA_BUS_FMT_SBGGR8_1X8 > V4L2_PIX_FMT_YUYV: MEDIA_BUS_FMT_YUYV8_2X8 > But I can't get the subdev's format code before starting stream as the > subdev may change it. So I can't know which pixformats are available. > So I exports all the pixformats supported by SoC. > The result is the app (v4l2-compliance) is likely to fail on streamon. > > This patchset add initial support for Allwinner V3s CSI. > > Allwinner V3s SoC features a CSI module with parallel interface. > > This patchset implement a v4l2 framework driver and add a binding > documentation for it. Applied with this diff from Maxime: <URL:http://code.bulix.org/vf7b6g-504515?raw> The MAINTAINERS entry was also moved to the first patch. Thanks!
Hello, On Tue, Oct 30, 2018 at 04:09:48PM +0800, Yong Deng wrote: > I can't make v4l2-compliance always happy. > The V3s CSI support many pixformats. But they are not always available. > It's dependent on the input bus format (MEDIA_BUS_FMT_*). > Example: > V4L2_PIX_FMT_SBGGR8: MEDIA_BUS_FMT_SBGGR8_1X8 > V4L2_PIX_FMT_YUYV: MEDIA_BUS_FMT_YUYV8_2X8 > But I can't get the subdev's format code before starting stream as the > subdev may change it. So I can't know which pixformats are available. > So I exports all the pixformats supported by SoC. > The result is the app (v4l2-compliance) is likely to fail on streamon. > > This patchset add initial support for Allwinner V3s CSI. I've tested your patches on A83T and CSI works on that SoC too. I'll send DTS patches later. One thing I noticed is that, when you cat the regmap registers file in debugfs while streaming, the kernel locks up hard. I was not able to extract any logs. regards, Ondrej
Hi, On Wed, 26 Dec 2018 11:29:36 +0100 'Ondřej Jirman' via linux-sunxi <linux-sunxi@googlegroups.com> wrote: > Hello, > > On Tue, Oct 30, 2018 at 04:09:48PM +0800, Yong Deng wrote: > > I can't make v4l2-compliance always happy. > > The V3s CSI support many pixformats. But they are not always available. > > It's dependent on the input bus format (MEDIA_BUS_FMT_*). > > Example: > > V4L2_PIX_FMT_SBGGR8: MEDIA_BUS_FMT_SBGGR8_1X8 > > V4L2_PIX_FMT_YUYV: MEDIA_BUS_FMT_YUYV8_2X8 > > But I can't get the subdev's format code before starting stream as the > > subdev may change it. So I can't know which pixformats are available. > > So I exports all the pixformats supported by SoC. > > The result is the app (v4l2-compliance) is likely to fail on streamon. > > > > This patchset add initial support for Allwinner V3s CSI. > > I've tested your patches on A83T and CSI works on that SoC too. I'll send > DTS patches later. > > One thing I noticed is that, when you cat the regmap registers file in debugfs > while streaming, the kernel locks up hard. I was not able to extract any logs. May be some registers can't be read when streaming ? Like read-clear regs ? Or multi CPU core access regs at the same time may cause the bus lock up? Thanks, Yong