| Message ID | 20181114125942.25163-1-nsaenzjulienne@suse.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | staging: vchiq: dead code removal & misc fixes | expand |
Hi Nicolas, > Nicolas Saenz Julienne <nsaenzjulienne@suse.de> hat am 14. November 2018 um 13:59 geschrieben: > > > Hi All, > > This series was written in parallel with reading and understanding the > vchiq code. So excuse me for the lack of logic in the sequence of > patches. > > The main focus was to delete as much code as possible, I've counted > around 550 lines, which is not bad. Apart from that there are some > patches enforcing proper kernel APIs usage. > > The only patch that really changes code is the > vchiq_ioc_copy_element_data() rewrite. > > The last commit updates the TODO list with some of my observations, I > realise some of the might be a little opinionated. If anything it's > going to force a discussion on the topic, which is nice. > > It was developed on top of the latest linux-next, and was tested on a > RPIv3B+ with audio, video and running vchiq_test. > > Regards, > Nicolas > without a changelog i won't start a review. Regards Stefan
On Sun, Nov 18, 2018 at 04:55:49PM +0100, Stefan Wahren wrote: > Hi Nicolas, > > > Nicolas Saenz Julienne <nsaenzjulienne@suse.de> hat am 14. November 2018 um 13:59 geschrieben: > > > > > > Hi All, > > > > This series was written in parallel with reading and understanding the > > vchiq code. So excuse me for the lack of logic in the sequence of > > patches. > > > > The main focus was to delete as much code as possible, I've counted > > around 550 lines, which is not bad. Apart from that there are some > > patches enforcing proper kernel APIs usage. > > > > The only patch that really changes code is the > > vchiq_ioc_copy_element_data() rewrite. > > > > The last commit updates the TODO list with some of my observations, I > > realise some of the might be a little opinionated. If anything it's > > going to force a discussion on the topic, which is nice. > > > > It was developed on top of the latest linux-next, and was tested on a > > RPIv3B+ with audio, video and running vchiq_test. > > > > Regards, > > Nicolas > > > > without a changelog i won't start a review. What do you mean by this? The individual patches have a "changelog" in them, this is just a summary of the overall changes. What do you feel is missing here? thanks, greg k-h
On Tue, 2018-11-20 at 10:57 +0100, Greg KH wrote: > On Sun, Nov 18, 2018 at 04:55:49PM +0100, Stefan Wahren wrote: > > Hi Nicolas, > > > > > Nicolas Saenz Julienne <nsaenzjulienne@suse.de> hat am 14. > > > November 2018 um 13:59 geschrieben: > > > > > > > > > Hi All, > > > > > > This series was written in parallel with reading and > > > understanding the > > > vchiq code. So excuse me for the lack of logic in the sequence of > > > patches. > > > > > > The main focus was to delete as much code as possible, I've > > > counted > > > around 550 lines, which is not bad. Apart from that there are > > > some > > > patches enforcing proper kernel APIs usage. > > > > > > The only patch that really changes code is the > > > vchiq_ioc_copy_element_data() rewrite. > > > > > > The last commit updates the TODO list with some of my > > > observations, I > > > realise some of the might be a little opinionated. If anything > > > it's > > > going to force a discussion on the topic, which is nice. > > > > > > It was developed on top of the latest linux-next, and was tested > > > on a > > > RPIv3B+ with audio, video and running vchiq_test. > > > > > > Regards, > > > Nicolas > > > > > > > without a changelog i won't start a review. > > What do you mean by this? The individual patches have a "changelog" > in > them, this is just a summary of the overall changes. > > What do you feel is missing here? Hi Greg, I did send an RFC version of this, to which Stephan made several comments. I should have added the changelog to the proper series submission. I've been busy with work, but I'll send the updated version during the day. Regards, Nicolas > > thanks, > > greg k-h
Am 20.11.18 um 11:04 schrieb Nicolas Saenz Julienne: > On Tue, 2018-11-20 at 10:57 +0100, Greg KH wrote: >> On Sun, Nov 18, 2018 at 04:55:49PM +0100, Stefan Wahren wrote: >>> Hi Nicolas, >>> >>> >>> without a changelog i won't start a review. >> What do you mean by this? The individual patches have a "changelog" >> in >> them, this is just a summary of the overall changes. >> >> What do you feel is missing here? > Hi Greg, > I did send an RFC version of this, to which Stephan made several > comments. I should have added the changelog to the proper series > submission. I've been busy with work, but I'll send the updated version > during the day. Thanks Stefan > > Regards, > Nicolas > >> thanks, >> >> greg k-h
Hi All, This series was written in parallel with reading and understanding the vchiq code. So excuse me for the lack of logic in the sequence of patches. The main focus was to delete as much code as possible, I've counted around 550 lines, which is not bad. Apart from that there are some patches enforcing proper kernel APIs usage. The only patch that really changes code is the vchiq_ioc_copy_element_data() rewrite. The last commit updates the TODO list with some of my observations, I realise some of the might be a little opinionated. If anything it's going to force a discussion on the topic, which is nice. It was developed on top of the latest linux-next, and was tested on a RPIv3B+ with audio, video and running vchiq_test. Regards, Nicolas === Nicolas Saenz Julienne (16): staging: vchiq_core: rework vchiq_get_config staging: vchiq_arm: rework close/remove_service IOCTLS staging: vchiq_shim: delete vchi_service_create staging: vchiq_arm: use list_for_each_entry when accessing bulk_waiter_list staging: vchiq_arm: get rid of vchi_mh.h staging: vchiq_arm: rework vchiq_ioc_copy_element_data staging: vchiq-core: get rid of is_master distinction staging: vchiq_core: remove unnecessary safety checks in vchiq_init_state staging: vchiq_core: do not initialize semaphores twice staging: vchiq_core: don't add a wmb() before remote_event_signal() staging: vchiq: use completions instead of semaphores staging: vchiq_util: get rid of unneeded memory barriers staging: vchiq_core: fix logic redundancy in parse_open staging: vchiq_arm: rework probe and init functions staging: vchiq_arm: fix open/release cdev functions staging: vchiq: add more tasks to the TODO list .../staging/vc04_services/interface/vchi/TODO | 42 ++ .../vc04_services/interface/vchi/vchi.h | 8 - .../vc04_services/interface/vchi/vchi_mh.h | 42 -- .../interface/vchiq_arm/vchiq_2835_arm.c | 18 +- .../interface/vchiq_arm/vchiq_arm.c | 598 ++++++++---------- .../interface/vchiq_arm/vchiq_core.c | 523 ++++----------- .../interface/vchiq_arm/vchiq_core.h | 47 +- .../interface/vchiq_arm/vchiq_if.h | 11 +- .../interface/vchiq_arm/vchiq_shim.c | 32 - .../interface/vchiq_arm/vchiq_util.c | 48 +- .../interface/vchiq_arm/vchiq_util.h | 6 +- 11 files changed, 435 insertions(+), 940 deletions(-) delete mode 100644 drivers/staging/vc04_services/interface/vchi/vchi_mh.h