| Message ID | 1542633978-22064-1-git-send-email-fabrizio.castro@bp.renesas.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v3] drm/bridge/sii902x: Add missing dependency on I2C_MUX | expand |
Hello Boris, > From: Boris Brezillon <boris.brezillon@bootlin.com> > Sent: 19 November 2018 16:55 > Subject: Re: [PATCH v3] drm/bridge/sii902x: Add missing dependency on I2C_MUX > > Hi Fabrizio, > > On Mon, 19 Nov 2018 13:26:18 +0000 > Fabrizio Castro <fabrizio.castro@bp.renesas.com> wrote: > > > kbuild test robot reports: > > > > >> ERROR: "i2c_mux_add_adapter" [drivers/gpu/drm/bridge/sii902x.ko] > > undefined! > > >> ERROR: "i2c_mux_alloc" [drivers/gpu/drm/bridge/sii902x.ko] > > undefined! > > >> ERROR: "i2c_mux_del_adapters" [drivers/gpu/drm/bridge/sii902x.ko] > > undefined! > > > > Quite obviously the driver depends on I2C_MUX, but adding a "depends on" > > introduces a recursive dependency, therefore this patch selects I2C_MUX > > instead. > > > > Fixes: 21d808405fe4 ("drm/bridge/sii902x: Fix EDID readback") > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > Link: https://lists.01.org/pipermail/kbuild-all/2018-November/054924.html > > I don't see the patch on the dri-devel ML, and it does not appear in > patchwork either :-/. Mmm, my email address may have been blocked somehow by the dri-devel ML, I can't think of anything else that could get in the way, as the dri-devel ML was in copy in every email. Maybe that's because I am not subscribed? I have started the subscription process, once I am subscribed I'll try and repost. Thanks, Fab > > > --- > > v2->v3: > > * Changed the title > > > > v1->v2: > > * Added "Fixes" tag > > > > drivers/gpu/drm/bridge/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig > > index 9eeb8ef..2fee47b 100644 > > --- a/drivers/gpu/drm/bridge/Kconfig > > +++ b/drivers/gpu/drm/bridge/Kconfig > > @@ -95,6 +95,7 @@ config DRM_SII902X > > depends on OF > > select DRM_KMS_HELPER > > select REGMAP_I2C > > +select I2C_MUX > > ---help--- > > Silicon Image sii902x bridge chip driver. > > Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
Hello Boris, > From: Boris Brezillon <boris.brezillon@bootlin.com> > Sent: 19 November 2018 19:07 > Subject: Re: [PATCH v3] drm/bridge/sii902x: Add missing dependency on I2C_MUX > > On Mon, 19 Nov 2018 18:59:04 +0000 > Fabrizio Castro <fabrizio.castro@bp.renesas.com> wrote: > > > Hello Boris, > > > > > From: Boris Brezillon <boris.brezillon@bootlin.com> > > > Sent: 19 November 2018 16:55 > > > Subject: Re: [PATCH v3] drm/bridge/sii902x: Add missing dependency on I2C_MUX > > > > > > Hi Fabrizio, > > > > > > On Mon, 19 Nov 2018 13:26:18 +0000 > > > Fabrizio Castro <fabrizio.castro@bp.renesas.com> wrote: > > > > > > > kbuild test robot reports: > > > > > > > > >> ERROR: "i2c_mux_add_adapter" [drivers/gpu/drm/bridge/sii902x.ko] > > > > undefined! > > > > >> ERROR: "i2c_mux_alloc" [drivers/gpu/drm/bridge/sii902x.ko] > > > > undefined! > > > > >> ERROR: "i2c_mux_del_adapters" [drivers/gpu/drm/bridge/sii902x.ko] > > > > undefined! > > > > > > > > Quite obviously the driver depends on I2C_MUX, but adding a "depends on" > > > > introduces a recursive dependency, therefore this patch selects I2C_MUX > > > > instead. > > > > > > > > Fixes: 21d808405fe4 ("drm/bridge/sii902x: Fix EDID readback") > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > > > Link: https://lists.01.org/pipermail/kbuild-all/2018-November/054924.html > > > > > > I don't see the patch on the dri-devel ML, and it does not appear in > > > patchwork either :-/. > > > > Mmm, my email address may have been blocked somehow by the dri-devel ML, > > I can't think of anything else that could get in the way, as the dri-devel ML was > > in copy in every email. Maybe that's because I am not subscribed? I have started > > the subscription process, once I am subscribed I'll try and repost. > > That's weird. Your previous were visible on the dri-devel patchwork [1]. It is, let's see if my subscription makes things better. Thank you for your patience! Fab > > [1]https://patchwork.freedesktop.org/patch/260693/ Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
On 2018-11-19 14:26, Fabrizio Castro wrote: > kbuild test robot reports: > >>> ERROR: "i2c_mux_add_adapter" [drivers/gpu/drm/bridge/sii902x.ko] > undefined! >>> ERROR: "i2c_mux_alloc" [drivers/gpu/drm/bridge/sii902x.ko] > undefined! >>> ERROR: "i2c_mux_del_adapters" [drivers/gpu/drm/bridge/sii902x.ko] > undefined! Hi! My preference would be to not wrap the quoted text. To hell with warnings about long lines for cases like this. However, I'm not going to require a new iteration for that detail, but keep that in mind for the next patch or if you end up resending for some unrelated reason. > > Quite obviously the driver depends on I2C_MUX, but adding a "depends on" > introduces a recursive dependency, therefore this patch selects I2C_MUX > instead. This driver will not be the first to select I2C_MUX. So, even if it it is a bit untidy to select stuff that is also selectable by the user... Acked-by: Peter Rosin <peda@axentia.se> > > Fixes: 21d808405fe4 ("drm/bridge/sii902x: Fix EDID readback") > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > Link: https://lists.01.org/pipermail/kbuild-all/2018-November/054924.html > --- > v2->v3: > * Changed the title > > v1->v2: > * Added "Fixes" tag > > drivers/gpu/drm/bridge/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig > index 9eeb8ef..2fee47b 100644 > --- a/drivers/gpu/drm/bridge/Kconfig > +++ b/drivers/gpu/drm/bridge/Kconfig > @@ -95,6 +95,7 @@ config DRM_SII902X > depends on OF > select DRM_KMS_HELPER > select REGMAP_I2C > + select I2C_MUX > ---help--- > Silicon Image sii902x bridge chip driver. > >
On Tue, 20 Nov 2018 09:00:47 +0100 Boris Brezillon <boris.brezillon@bootlin.com> wrote: > On Mon, 19 Nov 2018 19:09:33 +0000 > Fabrizio Castro <fabrizio.castro@bp.renesas.com> wrote: > > > Hello Boris, > > > > > From: Boris Brezillon <boris.brezillon@bootlin.com> > > > Sent: 19 November 2018 19:07 > > > Subject: Re: [PATCH v3] drm/bridge/sii902x: Add missing dependency on I2C_MUX > > > > > > On Mon, 19 Nov 2018 18:59:04 +0000 > > > Fabrizio Castro <fabrizio.castro@bp.renesas.com> wrote: > > > > > > > Hello Boris, > > > > > > > > > From: Boris Brezillon <boris.brezillon@bootlin.com> > > > > > Sent: 19 November 2018 16:55 > > > > > Subject: Re: [PATCH v3] drm/bridge/sii902x: Add missing dependency on I2C_MUX > > > > > > > > > > Hi Fabrizio, > > > > > > > > > > On Mon, 19 Nov 2018 13:26:18 +0000 > > > > > Fabrizio Castro <fabrizio.castro@bp.renesas.com> wrote: > > > > > > > > > > > kbuild test robot reports: > > > > > > > > > > > > >> ERROR: "i2c_mux_add_adapter" [drivers/gpu/drm/bridge/sii902x.ko] > > > > > > undefined! > > > > > > >> ERROR: "i2c_mux_alloc" [drivers/gpu/drm/bridge/sii902x.ko] > > > > > > undefined! > > > > > > >> ERROR: "i2c_mux_del_adapters" [drivers/gpu/drm/bridge/sii902x.ko] > > > > > > undefined! > > > > > > > > > > > > Quite obviously the driver depends on I2C_MUX, but adding a "depends on" > > > > > > introduces a recursive dependency, therefore this patch selects I2C_MUX > > > > > > instead. > > > > > > > > > > > > Fixes: 21d808405fe4 ("drm/bridge/sii902x: Fix EDID readback") > > > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > > > > > Link: https://lists.01.org/pipermail/kbuild-all/2018-November/054924.html > > > > > > > > > > I don't see the patch on the dri-devel ML, and it does not appear in > > > > > patchwork either :-/. > > > > > > > > Mmm, my email address may have been blocked somehow by the dri-devel ML, > > > > I can't think of anything else that could get in the way, as the dri-devel ML was > > > > in copy in every email. Maybe that's because I am not subscribed? I have started > > > > the subscription process, once I am subscribed I'll try and repost. > > > > > > That's weird. Your previous were visible on the dri-devel patchwork [1]. > > > > It is, let's see if my subscription makes things better. > > > > Thank you for your patience! > > Can you try to send a v4 addressing Peter's comments? If it still > doesn't appear on the ML, I'll apply it anyway. Nevermind, the patch appeared on the ML (and in patchwork) in the meantime. Queued to drm-misc-next after unwrapping the error lines as suggested by Peter. Thanks, Boris
diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig index 9eeb8ef..2fee47b 100644 --- a/drivers/gpu/drm/bridge/Kconfig +++ b/drivers/gpu/drm/bridge/Kconfig @@ -95,6 +95,7 @@ config DRM_SII902X depends on OF select DRM_KMS_HELPER select REGMAP_I2C + select I2C_MUX ---help--- Silicon Image sii902x bridge chip driver.