| Message ID | 1542626108-61344-2-git-send-email-biju.das@bp.renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | Add NXP pcf85263 real-time clock support | expand |
On Mon, Nov 19, 2018 at 11:15:05AM +0000, Biju Das wrote: > This patch adds binding for NXP pcf85263 real-time clock. pcf85263 rtc is > compatible with pcf85363 rtc except that pcf85363 has 64 bytes additional > RAM. How about this: This patch adds binding for the NXP pcf85263 real-time clock. The pcf85263 RTC is compatible with the pcf85363 RTC. The difference between the parts is except that the pcf85363 has 64 bytes more RAM. > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > --- > Documentation/devicetree/bindings/rtc/pcf85363.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/rtc/pcf85363.txt b/Documentation/devicetree/bindings/rtc/pcf85363.txt > index 76fdabc..94adc1c 100644 > --- a/Documentation/devicetree/bindings/rtc/pcf85363.txt > +++ b/Documentation/devicetree/bindings/rtc/pcf85363.txt > @@ -1,8 +1,8 @@ > -NXP PCF85363 Real Time Clock > +NXP PCF85263/PCF85363 Real Time Clock > ============================ > > Required properties: > -- compatible: Should contain "nxp,pcf85363". > +- compatible: Should contain "nxp,pcf85263" or "nxp,pcf85363". > - reg: I2C address for chip. > > Optional properties: > -- > 2.7.4 >
On Wed, Nov 21, 2018 at 11:04:52AM +0100, Simon Horman wrote: > On Mon, Nov 19, 2018 at 11:15:05AM +0000, Biju Das wrote: > > This patch adds binding for NXP pcf85263 real-time clock. pcf85263 rtc is > > compatible with pcf85363 rtc except that pcf85363 has 64 bytes additional > > RAM. > > How about this: > > This patch adds binding for the NXP pcf85263 real-time clock. > > The pcf85263 RTC is compatible with the pcf85363 RTC. The difference > between the parts is except that the pcf85363 has 64 bytes more RAM. The pcf85263 anRTC is compatible with the pcf85363 RTC. The difference between the pcf85263 and pcf85363 RTS is that the latter has 64 bytes more RAM. This renders them incompatible from a DT point of view. > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > --- > > Documentation/devicetree/bindings/rtc/pcf85363.txt | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/rtc/pcf85363.txt b/Documentation/devicetree/bindings/rtc/pcf85363.txt > > index 76fdabc..94adc1c 100644 > > --- a/Documentation/devicetree/bindings/rtc/pcf85363.txt > > +++ b/Documentation/devicetree/bindings/rtc/pcf85363.txt > > @@ -1,8 +1,8 @@ > > -NXP PCF85363 Real Time Clock > > +NXP PCF85263/PCF85363 Real Time Clock > > ============================ > > > > Required properties: > > -- compatible: Should contain "nxp,pcf85363". > > +- compatible: Should contain "nxp,pcf85263" or "nxp,pcf85363". > > - reg: I2C address for chip. > > > > Optional properties: > > -- > > 2.7.4 > > >
Hello Simon, Thanks for the feedback. > -----Original Message----- > From: Simon Horman <horms@verge.net.au> > Sent: 21 November 2018 10:10 > To: Biju Das <biju.das@bp.renesas.com> > Cc: Alessandro Zummo <a.zummo@towertech.it>; Alexandre Belloni > <alexandre.belloni@bootlin.com>; Rob Herring <robh+dt@kernel.org>; > Mark Rutland <mark.rutland@arm.com>; linux-rtc@vger.kernel.org; > devicetree@vger.kernel.org; Geert Uytterhoeven > <geert+renesas@glider.be>; Chris Paterson > <Chris.Paterson2@renesas.com>; Fabrizio Castro > <fabrizio.castro@bp.renesas.com>; linux-renesas-soc@vger.kernel.org > Subject: Re: [PATCH 1/4] dt-bindings: rtc: pcf85363: Document pcf85263 real- > time clock > > On Wed, Nov 21, 2018 at 11:04:52AM +0100, Simon Horman wrote: > > On Mon, Nov 19, 2018 at 11:15:05AM +0000, Biju Das wrote: > > > This patch adds binding for NXP pcf85263 real-time clock. pcf85263 > > > rtc is compatible with pcf85363 rtc except that pcf85363 has 64 > > > bytes additional RAM. > > > > How about this: > > > > This patch adds binding for the NXP pcf85263 real-time clock. > > > > The pcf85263 RTC is compatible with the pcf85363 RTC. The difference > > between the parts is except that the pcf85363 has 64 bytes more RAM. > > The pcf85263 anRTC is compatible with the pcf85363 RTC. > > The difference between the pcf85263 and pcf85363 RTS is that the latter has > 64 bytes more RAM. This renders them incompatible from a DT point of view. Will send V2 with the below changes. This patch adds binding for the NXP pcf85263 real-time clock. The pcf85263 RTC is compatible with the pcf85363 RTC. The difference between the parts is except that the pcf85363 has 64 bytes more RAM. The pcf85263 RTC is compatible with the pcf85363 RTC. The difference between the pcf85263 and pcf85363 RTC is that the latter has 64 bytes more RAM. This renders them incompatible from a DT point of view. Regards, Biju > > > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > > --- > > > Documentation/devicetree/bindings/rtc/pcf85363.txt | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/rtc/pcf85363.txt > > > b/Documentation/devicetree/bindings/rtc/pcf85363.txt > > > index 76fdabc..94adc1c 100644 > > > --- a/Documentation/devicetree/bindings/rtc/pcf85363.txt > > > +++ b/Documentation/devicetree/bindings/rtc/pcf85363.txt > > > @@ -1,8 +1,8 @@ > > > -NXP PCF85363 Real Time Clock > > > +NXP PCF85263/PCF85363 Real Time Clock > > > ============================ > > > > > > Required properties: > > > -- compatible: Should contain "nxp,pcf85363". > > > +- compatible: Should contain "nxp,pcf85263" or "nxp,pcf85363". > > > - reg: I2C address for chip. > > > > > > Optional properties: > > > -- > > > 2.7.4 > > > > > Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
diff --git a/Documentation/devicetree/bindings/rtc/pcf85363.txt b/Documentation/devicetree/bindings/rtc/pcf85363.txt index 76fdabc..94adc1c 100644 --- a/Documentation/devicetree/bindings/rtc/pcf85363.txt +++ b/Documentation/devicetree/bindings/rtc/pcf85363.txt @@ -1,8 +1,8 @@ -NXP PCF85363 Real Time Clock +NXP PCF85263/PCF85363 Real Time Clock ============================ Required properties: -- compatible: Should contain "nxp,pcf85363". +- compatible: Should contain "nxp,pcf85263" or "nxp,pcf85363". - reg: I2C address for chip. Optional properties:
This patch adds binding for NXP pcf85263 real-time clock. pcf85263 rtc is compatible with pcf85363 rtc except that pcf85363 has 64 bytes additional RAM. Signed-off-by: Biju Das <biju.das@bp.renesas.com> --- Documentation/devicetree/bindings/rtc/pcf85363.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)