| Message ID | 20181031005612.98684-1-jsg@jsg.id.au (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915: change i915_sw_fence license to MIT | expand |
Quoting Jonathan Gray (2018-10-31 00:56:12) > Chris Wilson said Intel is willing to change the license of these files > to MIT. > > Signed-off-by: Jonathan Gray <jsg@jsg.id.au> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> -Chris
On Wed, Oct 31, 2018 at 08:43:03AM +0000, Chris Wilson wrote: > Quoting Jonathan Gray (2018-10-31 00:56:12) > > Chris Wilson said Intel is willing to change the license of these files > > to MIT. > > > > Signed-off-by: Jonathan Gray <jsg@jsg.id.au> > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> > -Chris Still looking to get this merged/reviewed by one of the i915 maintainers.
On Sun, Nov 18, 2018 at 08:44:30PM +1100, Jonathan Gray wrote: > On Wed, Oct 31, 2018 at 08:43:03AM +0000, Chris Wilson wrote: > > Quoting Jonathan Gray (2018-10-31 00:56:12) > > > Chris Wilson said Intel is willing to change the license of these files > > > to MIT. > > > > > > Signed-off-by: Jonathan Gray <jsg@jsg.id.au> > > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> > > -Chris > > Still looking to get this merged/reviewed by one of the i915 maintainers. I believe this patch should have a better commit message. Also Jani was looking to this conversions. Jani, any comment here? Thanks, Rodrigo.
On Mon, Nov 19, 2018 at 10:09:33AM -0800, Rodrigo Vivi wrote: > On Sun, Nov 18, 2018 at 08:44:30PM +1100, Jonathan Gray wrote: > > On Wed, Oct 31, 2018 at 08:43:03AM +0000, Chris Wilson wrote: > > > Quoting Jonathan Gray (2018-10-31 00:56:12) > > > > Chris Wilson said Intel is willing to change the license of these files > > > > to MIT. > > > > > > > > Signed-off-by: Jonathan Gray <jsg@jsg.id.au> > > > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> > > > -Chris > > > > Still looking to get this merged/reviewed by one of the i915 maintainers. > > I believe this patch should have a better commit message. It isn't clear what should be changed, what do you have in mind?
Quoting Jonathan Gray (2018-11-20 00:31:22) > On Mon, Nov 19, 2018 at 10:09:33AM -0800, Rodrigo Vivi wrote: > > On Sun, Nov 18, 2018 at 08:44:30PM +1100, Jonathan Gray wrote: > > > On Wed, Oct 31, 2018 at 08:43:03AM +0000, Chris Wilson wrote: > > > > Quoting Jonathan Gray (2018-10-31 00:56:12) > > > > > Chris Wilson said Intel is willing to change the license of these files > > > > > to MIT. > > > > > > > > > > Signed-off-by: Jonathan Gray <jsg@jsg.id.au> > > > > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> > > > > -Chris > > > > > > Still looking to get this merged/reviewed by one of the i915 maintainers. > > > > I believe this patch should have a better commit message. > > It isn't clear what should be changed, what do you have in mind? It would make sense to state why you want to change the license to begin with. Anyway, I'll double check with our legal team and reply shortly. Regards, Joonas
On Fri, Nov 23, 2018 at 12:14:00PM +0200, Joonas Lahtinen wrote: > Quoting Jonathan Gray (2018-11-20 00:31:22) > > On Mon, Nov 19, 2018 at 10:09:33AM -0800, Rodrigo Vivi wrote: > > > On Sun, Nov 18, 2018 at 08:44:30PM +1100, Jonathan Gray wrote: > > > > On Wed, Oct 31, 2018 at 08:43:03AM +0000, Chris Wilson wrote: > > > > > Quoting Jonathan Gray (2018-10-31 00:56:12) > > > > > > Chris Wilson said Intel is willing to change the license of these files > > > > > > to MIT. > > > > > > > > > > > > Signed-off-by: Jonathan Gray <jsg@jsg.id.au> > > > > > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> > > > > > -Chris > > > > > > > > Still looking to get this merged/reviewed by one of the i915 maintainers. > > > > > > I believe this patch should have a better commit message. > > > > It isn't clear what should be changed, what do you have in mind? > > It would make sense to state why you want to change the license to begin > with. > > Anyway, I'll double check with our legal team and reply shortly. > > Regards, Joonas I am porting the i915 code to OpenBSD again. These files are the last remaining GPL parts in my development tree. If they can't have the same license as the rest of the i915 code I will have to reimplement them.
Quoting Jonathan Gray (2018-11-23 14:28:37) > On Fri, Nov 23, 2018 at 12:14:00PM +0200, Joonas Lahtinen wrote: > > Quoting Jonathan Gray (2018-11-20 00:31:22) > > > On Mon, Nov 19, 2018 at 10:09:33AM -0800, Rodrigo Vivi wrote: > > > > On Sun, Nov 18, 2018 at 08:44:30PM +1100, Jonathan Gray wrote: > > > > > On Wed, Oct 31, 2018 at 08:43:03AM +0000, Chris Wilson wrote: > > > > > > Quoting Jonathan Gray (2018-10-31 00:56:12) > > > > > > > Chris Wilson said Intel is willing to change the license of these files > > > > > > > to MIT. > > > > > > > > > > > > > > Signed-off-by: Jonathan Gray <jsg@jsg.id.au> > > > > > > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> > > > > > > -Chris > > > > > > > > > > Still looking to get this merged/reviewed by one of the i915 maintainers. > > > > > > > > I believe this patch should have a better commit message. > > > > > > It isn't clear what should be changed, what do you have in mind? > > > > It would make sense to state why you want to change the license to begin > > with. > > > > Anyway, I'll double check with our legal team and reply shortly. > > > > Regards, Joonas > > I am porting the i915 code to OpenBSD again. These files are the last > remaining GPL parts in my development tree. If they can't have the same > license as the rest of the i915 code I will have to reimplement them. Yes, that's a reasonable reason, which should be recorded in the commit message. It's maybe also worthy mentioning that the files are only touched by tree-wide changes in addition to Chris, so he's the sole author of the file. Documenting these two saves somebody a lot of digging when they come across the commit. Pretty much everybody seems to be on their Thanksgiving holidays, so I'll expect a reply early next week from our legal. Regards, Joonas
On Fri, Nov 23, 2018 at 03:01:06PM +0200, Joonas Lahtinen wrote: > Quoting Jonathan Gray (2018-11-23 14:28:37) > > On Fri, Nov 23, 2018 at 12:14:00PM +0200, Joonas Lahtinen wrote: > > > Quoting Jonathan Gray (2018-11-20 00:31:22) > > > > On Mon, Nov 19, 2018 at 10:09:33AM -0800, Rodrigo Vivi wrote: > > > > > On Sun, Nov 18, 2018 at 08:44:30PM +1100, Jonathan Gray wrote: > > > > > > On Wed, Oct 31, 2018 at 08:43:03AM +0000, Chris Wilson wrote: > > > > > > > Quoting Jonathan Gray (2018-10-31 00:56:12) > > > > > > > > Chris Wilson said Intel is willing to change the license of these files > > > > > > > > to MIT. > > > > > > > > > > > > > > > > Signed-off-by: Jonathan Gray <jsg@jsg.id.au> > > > > > > > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> > > > > > > > -Chris > > > > > > > > > > > > Still looking to get this merged/reviewed by one of the i915 maintainers. > > > > > > > > > > I believe this patch should have a better commit message. > > > > > > > > It isn't clear what should be changed, what do you have in mind? > > > > > > It would make sense to state why you want to change the license to begin > > > with. > > > > > > Anyway, I'll double check with our legal team and reply shortly. > > > > > > Regards, Joonas > > > > I am porting the i915 code to OpenBSD again. These files are the last > > remaining GPL parts in my development tree. If they can't have the same > > license as the rest of the i915 code I will have to reimplement them. > > Yes, that's a reasonable reason, which should be recorded in the commit > message. It's maybe also worthy mentioning that the files are only > touched by tree-wide changes in addition to Chris, so he's the sole > author of the file. Documenting these two saves somebody a lot of > digging when they come across the commit. > > Pretty much everybody seems to be on their Thanksgiving holidays, so > I'll expect a reply early next week from our legal. > > Regards, Joonas Thanks, I can send a v2 with that context if you like assuming they agree.
Quoting Jonathan Gray (2018-11-23 16:53:46) > On Fri, Nov 23, 2018 at 03:01:06PM +0200, Joonas Lahtinen wrote: > > Quoting Jonathan Gray (2018-11-23 14:28:37) > > > On Fri, Nov 23, 2018 at 12:14:00PM +0200, Joonas Lahtinen wrote: > > > > Quoting Jonathan Gray (2018-11-20 00:31:22) > > > > > On Mon, Nov 19, 2018 at 10:09:33AM -0800, Rodrigo Vivi wrote: > > > > > > On Sun, Nov 18, 2018 at 08:44:30PM +1100, Jonathan Gray wrote: > > > > > > > On Wed, Oct 31, 2018 at 08:43:03AM +0000, Chris Wilson wrote: > > > > > > > > Quoting Jonathan Gray (2018-10-31 00:56:12) > > > > > > > > > Chris Wilson said Intel is willing to change the license of these files > > > > > > > > > to MIT. > > > > > > > > > > > > > > > > > > Signed-off-by: Jonathan Gray <jsg@jsg.id.au> > > > > > > > > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> > > > > > > > > -Chris > > > > > > > > > > > > > > Still looking to get this merged/reviewed by one of the i915 maintainers. > > > > > > > > > > > > I believe this patch should have a better commit message. > > > > > > > > > > It isn't clear what should be changed, what do you have in mind? > > > > > > > > It would make sense to state why you want to change the license to begin > > > > with. > > > > > > > > Anyway, I'll double check with our legal team and reply shortly. > > > > > > > > Regards, Joonas > > > > > > I am porting the i915 code to OpenBSD again. These files are the last > > > remaining GPL parts in my development tree. If they can't have the same > > > license as the rest of the i915 code I will have to reimplement them. > > > > Yes, that's a reasonable reason, which should be recorded in the commit > > message. It's maybe also worthy mentioning that the files are only > > touched by tree-wide changes in addition to Chris, so he's the sole > > author of the file. Documenting these two saves somebody a lot of > > digging when they come across the commit. > > > > Pretty much everybody seems to be on their Thanksgiving holidays, so > > I'll expect a reply early next week from our legal. > > > > Regards, Joonas > > Thanks, I can send a v2 with that context if you like assuming they agree. Hi, Please do send a v2, we got a permission to change the license. Regards, Joonas
diff --git a/drivers/gpu/drm/i915/i915_sw_fence.c b/drivers/gpu/drm/i915/i915_sw_fence.c index 6dbeed079ae5..fc2eeab823b7 100644 --- a/drivers/gpu/drm/i915/i915_sw_fence.c +++ b/drivers/gpu/drm/i915/i915_sw_fence.c @@ -1,10 +1,7 @@ /* - * (C) Copyright 2016 Intel Corporation + * SPDX-License-Identifier: MIT * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU General Public License - * as published by the Free Software Foundation; version 2 - * of the License. + * (C) Copyright 2016 Intel Corporation */ #include <linux/slab.h> diff --git a/drivers/gpu/drm/i915/i915_sw_fence.h b/drivers/gpu/drm/i915/i915_sw_fence.h index fe2ef4dadfc6..0e055ea0179f 100644 --- a/drivers/gpu/drm/i915/i915_sw_fence.h +++ b/drivers/gpu/drm/i915/i915_sw_fence.h @@ -1,10 +1,9 @@ /* + * SPDX-License-Identifier: MIT + * * i915_sw_fence.h - library routines for N:M synchronisation points * * Copyright (C) 2016 Intel Corporation - * - * This file is released under the GPLv2. - * */ #ifndef _I915_SW_FENCE_H_
Chris Wilson said Intel is willing to change the license of these files to MIT. Signed-off-by: Jonathan Gray <jsg@jsg.id.au> --- drivers/gpu/drm/i915/i915_sw_fence.c | 7 ++----- drivers/gpu/drm/i915/i915_sw_fence.h | 5 ++--- 2 files changed, 4 insertions(+), 8 deletions(-)