| Message ID | 1543226303-5260-1-git-send-email-liq3ea@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | target: hax: fix a typo | expand |
Li Qiang <liq3ea@gmail.com> writes: > Cc: qemu-trivial@nongnu.org > > Signed-off-by: Li Qiang <liq3ea@gmail.com> Reviewed-by: Alex Bennée <alex.bennee@linaro.org> > --- > target/i386/hax-all.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/i386/hax-all.c b/target/i386/hax-all.c > index 502ce6f0af..464744a406 100644 > --- a/target/i386/hax-all.c > +++ b/target/i386/hax-all.c > @@ -205,7 +205,7 @@ int hax_vcpu_destroy(CPUState *cpu) > } > > /* > - * 1. The hax_tunnel is also destroied when vcpu destroy > + * 1. The hax_tunnel is also destroyed when vcpu destroy > * 2. close fd will cause hax module vcpu be cleaned > */ > hax_close_fd(vcpu->fd); -- Alex Bennée
Hi Li, Alex. On 26/11/18 12:51, Alex Bennée wrote: > > Li Qiang <liq3ea@gmail.com> writes: > >> Cc: qemu-trivial@nongnu.org >> >> Signed-off-by: Li Qiang <liq3ea@gmail.com> > > Reviewed-by: Alex Bennée <alex.bennee@linaro.org> > >> --- >> target/i386/hax-all.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/target/i386/hax-all.c b/target/i386/hax-all.c >> index 502ce6f0af..464744a406 100644 >> --- a/target/i386/hax-all.c >> +++ b/target/i386/hax-all.c >> @@ -205,7 +205,7 @@ int hax_vcpu_destroy(CPUState *cpu) >> } >> >> /* >> - * 1. The hax_tunnel is also destroied when vcpu destroy >> + * 1. The hax_tunnel is also destroyed when vcpu destroy I'm not native english speaker. Isn't it: 'The hax_tunnel is also destroyed at vcpu destroy' or 'The hax_tunnel is also destroyed when vcpu is destroyed'? >> * 2. close fd will cause hax module vcpu be cleaned >> */ >> hax_close_fd(vcpu->fd); > > > -- > Alex Bennée >
On 11/26/18 1:25 PM, Philippe Mathieu-Daudé wrote: >>> - * 1. The hax_tunnel is also destroied when vcpu destroy >>> + * 1. The hax_tunnel is also destroyed when vcpu destroy > I'm not native english speaker. Isn't it: > > 'The hax_tunnel is also destroyed at vcpu destroy' > > or > > 'The hax_tunnel is also destroyed when vcpu is destroyed'? This second option is best, fwiw. r~
On 26/11/18 10:58, Li Qiang wrote: > Cc: qemu-trivial@nongnu.org > > Signed-off-by: Li Qiang <liq3ea@gmail.com> > --- > target/i386/hax-all.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/i386/hax-all.c b/target/i386/hax-all.c > index 502ce6f0af..464744a406 100644 > --- a/target/i386/hax-all.c > +++ b/target/i386/hax-all.c > @@ -205,7 +205,7 @@ int hax_vcpu_destroy(CPUState *cpu) > } > > /* > - * 1. The hax_tunnel is also destroied when vcpu destroy > + * 1. The hax_tunnel is also destroyed when vcpu destroy > * 2. close fd will cause hax module vcpu be cleaned > */ > hax_close_fd(vcpu->fd); > Queued, thanks. Paolo
Le 28/11/2018 à 13:43, Paolo Bonzini a écrit : > On 26/11/18 10:58, Li Qiang wrote: >> Cc: qemu-trivial@nongnu.org >> >> Signed-off-by: Li Qiang <liq3ea@gmail.com> >> --- >> target/i386/hax-all.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/target/i386/hax-all.c b/target/i386/hax-all.c >> index 502ce6f0af..464744a406 100644 >> --- a/target/i386/hax-all.c >> +++ b/target/i386/hax-all.c >> @@ -205,7 +205,7 @@ int hax_vcpu_destroy(CPUState *cpu) >> } >> >> /* >> - * 1. The hax_tunnel is also destroied when vcpu destroy >> + * 1. The hax_tunnel is also destroyed when vcpu destroy >> * 2. close fd will cause hax module vcpu be cleaned >> */ >> hax_close_fd(vcpu->fd); >> > > Queued, thanks. > There is a v2: "target: hax: fix errors in comment" with "vcpu is destroyed" rather than "vcpu destroy". Thanks, Laurent
On 28/11/18 13:47, Laurent Vivier wrote: > Le 28/11/2018 à 13:43, Paolo Bonzini a écrit : >> On 26/11/18 10:58, Li Qiang wrote: >>> Cc: qemu-trivial@nongnu.org >>> >>> Signed-off-by: Li Qiang <liq3ea@gmail.com> >>> --- >>> target/i386/hax-all.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/target/i386/hax-all.c b/target/i386/hax-all.c >>> index 502ce6f0af..464744a406 100644 >>> --- a/target/i386/hax-all.c >>> +++ b/target/i386/hax-all.c >>> @@ -205,7 +205,7 @@ int hax_vcpu_destroy(CPUState *cpu) >>> } >>> >>> /* >>> - * 1. The hax_tunnel is also destroied when vcpu destroy >>> + * 1. The hax_tunnel is also destroyed when vcpu destroy >>> * 2. close fd will cause hax module vcpu be cleaned >>> */ >>> hax_close_fd(vcpu->fd); >>> >> >> Queued, thanks. >> > > There is a v2: "target: hax: fix errors in comment" with "vcpu is > destroyed" rather than "vcpu destroy". > > Thanks, > Laurent > Got it---I'll adjust my filter to hide qemu-trivial patches. :) Paolo
diff --git a/target/i386/hax-all.c b/target/i386/hax-all.c index 502ce6f0af..464744a406 100644 --- a/target/i386/hax-all.c +++ b/target/i386/hax-all.c @@ -205,7 +205,7 @@ int hax_vcpu_destroy(CPUState *cpu) } /* - * 1. The hax_tunnel is also destroied when vcpu destroy + * 1. The hax_tunnel is also destroyed when vcpu destroy * 2. close fd will cause hax module vcpu be cleaned */ hax_close_fd(vcpu->fd);
Cc: qemu-trivial@nongnu.org Signed-off-by: Li Qiang <liq3ea@gmail.com> --- target/i386/hax-all.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)