| Message ID | 20181128161829.27266-1-niklas.soderlund+renesas@ragnatech.se (mailing list archive) |
|---|---|
| Headers | show |
| Series | mmc: renesas_sdhi: extend quirk selection to handle ES revisions | expand |
Hi Niklas, thanks for the updates! Do you happen to have a branch ready for testing? Thanks, Wolfram
Hi Wolfram, On 2018-11-28 22:56:20 +0100, Wolfram Sang wrote: > Hi Niklas, > > thanks for the updates! Do you happen to have a branch ready for > testing? I will push a new branch once I'm done updating the clock patch so all changes can be tested in one go. Will let you know once that is available. Hopefully later tonight.
Hi Wolfram, On 2018-11-28 23:06:37 +0100, Niklas Söderlund wrote: > Hi Wolfram, > > On 2018-11-28 22:56:20 +0100, Wolfram Sang wrote: > > Hi Niklas, > > > > thanks for the updates! Do you happen to have a branch ready for > > testing? > > I will push a new branch once I'm done updating the clock patch so all > changes can be tested in one go. Will let you know once that is > available. Hopefully later tonight. I have pushed the latest and greatest to [1]. I tested this on H3 ES1, H3 ES2.0 and M3-N and it looks good. Speeds for both MMC and SD cards match what we saw in Edinburgh. I still have to post the clock patches to the mailing list but in case you wish to test right away I thought I send this mail out before I do that :-) 1. git://git.ragnatech.se/linux mmc/hackfest
On Wed, Nov 28, 2018 at 05:18:26PM +0100, Niklas Söderlund wrote: > Hi, > > Recent datasheet updates have made it clear that some quirks are not SoC > specific but SoC + ES version specific. Currently the quirks are > selected using compatibility values but whit this new information that > is not enough. > > Patch 1/3 adds support to select quirks based on SoC + ES revision using > soc_device_match() and converts the only existing quirk. Patch 2/3 > Removes the old method to select quirk based on compatibility string. > While Patch 3/3 adds a new quirk from the BSP which blacklists some > known problematic ES versions for HS400. HS400 is not yet enabled > upstream so blacklisting these ES versions is not a regression of > functionality. > > Based on mmc/next and tested on H3 and M3-N. For the record: Tested with H3 ES2.0 and M3N where HS400 was sucesfully detected. Tested with H3 ES1.0 and M3-W ES1.0 where HS400 was rightfully discarded and HS200 was used.
On Wed, 28 Nov 2018 at 17:19, Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> wrote: > > Hi, > > Recent datasheet updates have made it clear that some quirks are not SoC > specific but SoC + ES version specific. Currently the quirks are > selected using compatibility values but whit this new information that > is not enough. > > Patch 1/3 adds support to select quirks based on SoC + ES revision using > soc_device_match() and converts the only existing quirk. Patch 2/3 > Removes the old method to select quirk based on compatibility string. > While Patch 3/3 adds a new quirk from the BSP which blacklists some > known problematic ES versions for HS400. HS400 is not yet enabled > upstream so blacklisting these ES versions is not a regression of > functionality. > > Based on mmc/next and tested on H3 and M3-N. > > Niklas Söderlund (3): > mmc: renesas_sdhi: handle 4tap hs400 mode quirk based on SoC revision > mmc: renesas_sdhi: align compatibility properties for H3 and M3-W > mmc: renesas_sdhi: disable HS400 on H3 ES1.x and M3-W ES1.[012] > > drivers/mmc/host/renesas_sdhi_core.c | 36 +++++++++++++++++++ > drivers/mmc/host/renesas_sdhi_internal_dmac.c | 20 ++--------- > drivers/mmc/host/renesas_sdhi_sys_dmac.c | 20 ++--------- > 3 files changed, 41 insertions(+), 35 deletions(-) > > -- > 2.19.1 > Applied for next, thanks! Kind regards Uffe