mbox series

[0/2] Two refactoring patches for the qla2xxx driver

Message ID 20181127230455.259829-1-bvanassche@acm.org (mailing list archive)
Headers show
Series Two refactoring patches for the qla2xxx driver | expand

Message

Bart Van Assche Nov. 27, 2018, 11:04 p.m. UTC 
Hi Martin,

The two patches in this series make the qla2xxx driver source code easier
to read without changing the driver functionality. Please consider these
patches for kernel v4.21.

Thanks,

Bart.

Bart Van Assche (2):
  qla2xxx: Introduce a switch/case statement in qlt_xmit_tm_rsp()
  qla2xxx: Split the __qla2x00_abort_all_cmds() function

 drivers/scsi/qla2xxx/qla_os.c     | 89 +++++++++++++++----------------
 drivers/scsi/qla2xxx/qla_target.c | 14 ++---
 2 files changed, 51 insertions(+), 52 deletions(-)

Comments

Laurence Oberman Nov. 27, 2018, 11:48 p.m. UTC | #1 
On Tue, 2018-11-27 at 15:04 -0800, Bart Van Assche wrote:
> Hi Martin,
> 
> The two patches in this series make the qla2xxx driver source code
> easier
> to read without changing the driver functionality. Please consider
> these
> patches for kernel v4.21.
> 
> Thanks,
> 
> Bart.
> 
> Bart Van Assche (2):
>   qla2xxx: Introduce a switch/case statement in qlt_xmit_tm_rsp()
>   qla2xxx: Split the __qla2x00_abort_all_cmds() function
> 
>  drivers/scsi/qla2xxx/qla_os.c     | 89 +++++++++++++++------------
> ----
>  drivers/scsi/qla2xxx/qla_target.c | 14 ++---
>  2 files changed, 51 insertions(+), 52 deletions(-)
> 

These look fine to me and the switch change makes it much cleaner.
Reviewed-by: Laurence Oberman <loberman@redhat.com>
Martin K. Petersen Nov. 29, 2018, 2:50 a.m. UTC | #2 
Bart,

> The two patches in this series make the qla2xxx driver source code
> easier to read without changing the driver functionality. Please
> consider these patches for kernel v4.21.

I applied patch #1. #2 had conflicts, please rebase.

Thanks!