[V8,0/7] clk: imx: add imx8qxp clock support

Message

Aisheng Dong Nov. 21, 2018, 2:12 p.m. UTC

This patch series adds i.MX8QXP clock support which is based
on the clock service provided by SCU firmware.

Note: It depends on SCU driver which has already been merged by Shawn.
So this patch series could go through Shawn's tree as well.

ChangeLog:
v7->v8:
 * add more kernel doc for lpcg and scu clock structures
 * remove one unneccessry reg checking
v6->v7:
 * use struct_size()
 * remove MODULE_ macros
 * add more kernel docs/code comments
 * other small improvements
 * update reviewed-by tags
 * add the missing PATCH 1 in V6
v5->v6:
 * simply the driver a lot by re-orgnizing the driver into a few clock types:
   scu clock (merge scu divider/gate/mux) and scu gpr lock which accessing is
   through SCU protocol and LPCG clock which is directly accessible by CPU.
 * LPCG clock is separate from SCU clock, gpr clock is still not used
   and will be added later.
 * remove old year license as the code is totally rewritten
 * scu mux support will be added later as it's also still not used.
v4->v5:
 Address all Stephen and Sascha's review comments, see details in each patch
v3->v4:
 * scu headfile path update
 * no functionality change
v2->v3:
 * structures/enums name update with imx_sc prefix
 * no functionality change
v1->v2:
 * structure and enums name update
 * api usage update due to api change
 * no functionality change

Dong Aisheng (7):
  clk: imx: add configuration option for mmio clks
  clk: imx: add scu clock common part
  dt-bindings: clock: imx8qxp: add SCU clock IDs
  clk: imx: add imx8qxp clk driver
  dt-bindings: clock: add imx8qxp lpcg clock binding
  clk: imx: add lpcg clock support
  clk: imx: add imx8qxp lpcg driver

 .../devicetree/bindings/clock/imx8qxp-lpcg.txt     |  51 ++++
 arch/arm/mach-imx/Kconfig                          |  11 +
 drivers/clk/Kconfig                                |   1 +
 drivers/clk/imx/Kconfig                            |   9 +
 drivers/clk/imx/Makefile                           |   8 +-
 drivers/clk/imx/clk-imx8qxp-lpcg.c                 | 216 +++++++++++++++
 drivers/clk/imx/clk-imx8qxp-lpcg.h                 | 102 ++++++++
 drivers/clk/imx/clk-imx8qxp.c                      | 153 +++++++++++
 drivers/clk/imx/clk-lpcg-scu.c                     | 113 ++++++++
 drivers/clk/imx/clk-scu.c                          | 267 +++++++++++++++++++
 drivers/clk/imx/clk-scu.h                          |  24 ++
 include/dt-bindings/clock/imx8qxp-clock.h          | 289 +++++++++++++++++++++
 12 files changed, 1243 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/devicetree/bindings/clock/imx8qxp-lpcg.txt
 create mode 100644 drivers/clk/imx/Kconfig
 create mode 100644 drivers/clk/imx/clk-imx8qxp-lpcg.c
 create mode 100644 drivers/clk/imx/clk-imx8qxp-lpcg.h
 create mode 100644 drivers/clk/imx/clk-imx8qxp.c
 create mode 100644 drivers/clk/imx/clk-lpcg-scu.c
 create mode 100644 drivers/clk/imx/clk-scu.c
 create mode 100644 drivers/clk/imx/clk-scu.h
 create mode 100644 include/dt-bindings/clock/imx8qxp-clock.h

Comments

Aisheng Dong Nov. 28, 2018, 5:18 p.m. UTC | #1

Gently Ping...

> -----Original Message-----
> From: Aisheng DONG
> Sent: Wednesday, November 21, 2018 10:12 PM
> To: [e-mail]
> Cc: [e-mail]; [e-mail];
> [e-mail]; [e-mail]; Fabio Estevam
> <[e-mail]>; dl-linux-imx <[e-mail]>;
> [e-mail]; Aisheng DONG <[e-mail]>
> Subject: [PATCH V8 0/7] clk: imx: add imx8qxp clock support
> 
> This patch series adds i.MX8QXP clock support which is based on the clock
> service provided by SCU firmware.
> 
> Note: It depends on SCU driver which has already been merged by Shawn.
> So this patch series could go through Shawn's tree as well.
> 
> ChangeLog:
> v7->v8:
>  * add more kernel doc for lpcg and scu clock structures
>  * remove one unneccessry reg checking
> v6->v7:
>  * use struct_size()
>  * remove MODULE_ macros
>  * add more kernel docs/code comments
>  * other small improvements
>  * update reviewed-by tags
>  * add the missing PATCH 1 in V6
> v5->v6:
>  * simply the driver a lot by re-orgnizing the driver into a few clock types:
>    scu clock (merge scu divider/gate/mux) and scu gpr lock which accessing is
>    through SCU protocol and LPCG clock which is directly accessible by CPU.
>  * LPCG clock is separate from SCU clock, gpr clock is still not used
>    and will be added later.
>  * remove old year license as the code is totally rewritten
>  * scu mux support will be added later as it's also still not used.
> v4->v5:
>  Address all Stephen and Sascha's review comments, see details in each patch
> v3->v4:
>  * scu headfile path update
>  * no functionality change
> v2->v3:
>  * structures/enums name update with imx_sc prefix
>  * no functionality change
> v1->v2:
>  * structure and enums name update
>  * api usage update due to api change
>  * no functionality change
> 
> Dong Aisheng (7):
>   clk: imx: add configuration option for mmio clks
>   clk: imx: add scu clock common part
>   dt-bindings: clock: imx8qxp: add SCU clock IDs
>   clk: imx: add imx8qxp clk driver
>   dt-bindings: clock: add imx8qxp lpcg clock binding
>   clk: imx: add lpcg clock support
>   clk: imx: add imx8qxp lpcg driver
> 
>  .../devicetree/bindings/clock/imx8qxp-lpcg.txt     |  51 ++++
>  arch/arm/mach-imx/Kconfig                          |  11 +
>  drivers/clk/Kconfig                                |   1 +
>  drivers/clk/imx/Kconfig                            |   9 +
>  drivers/clk/imx/Makefile                           |   8 +-
>  drivers/clk/imx/clk-imx8qxp-lpcg.c                 | 216
> +++++++++++++++
>  drivers/clk/imx/clk-imx8qxp-lpcg.h                 | 102 ++++++++
>  drivers/clk/imx/clk-imx8qxp.c                      | 153 +++++++++++
>  drivers/clk/imx/clk-lpcg-scu.c                     | 113 ++++++++
>  drivers/clk/imx/clk-scu.c                          | 267
> +++++++++++++++++++
>  drivers/clk/imx/clk-scu.h                          |  24 ++
>  include/dt-bindings/clock/imx8qxp-clock.h          | 289
> +++++++++++++++++++++
>  12 files changed, 1243 insertions(+), 1 deletion(-)  create mode 100644
> Documentation/devicetree/bindings/clock/imx8qxp-lpcg.txt
>  create mode 100644 drivers/clk/imx/Kconfig  create mode 100644
> drivers/clk/imx/clk-imx8qxp-lpcg.c
>  create mode 100644 drivers/clk/imx/clk-imx8qxp-lpcg.h
>  create mode 100644 drivers/clk/imx/clk-imx8qxp.c  create mode 100644
> drivers/clk/imx/clk-lpcg-scu.c  create mode 100644 drivers/clk/imx/clk-scu.c
> create mode 100644 drivers/clk/imx/clk-scu.h  create mode 100644
> include/dt-bindings/clock/imx8qxp-clock.h
> 
> --
> 2.7.4

Stephen Boyd Dec. 3, 2018, 6:38 p.m. UTC | #2

Quoting Aisheng DONG (2018-11-28 09:18:47)
> Gently Ping...
> 

FYI, when you ping the thread, it floats to the end of the queue for me,
and then I don't review it for some time. Sorry, this is how it mostly
works. The bigger topics come to the front queue and then I try to get
to those sooner and let the stuff churning as newest in the queue become
lower priority because "someone else is doing something". I do sweeps
over the new stuff every day or two to pick out the easy one liners and
simple things because they may be critical, etc.

Stephen Boyd Dec. 3, 2018, 7:45 p.m. UTC | #3

Quoting Aisheng DONG (2018-11-21 06:12:16)
> This patch series adds i.MX8QXP clock support which is based
> on the clock service provided by SCU firmware.
> 
> Note: It depends on SCU driver which has already been merged by Shawn.
> So this patch series could go through Shawn's tree as well.

Any patches I didn't make comments on look good to go. Only a few
comments to address and otherwise it looks good.

Aisheng Dong Dec. 4, 2018, 1:46 a.m. UTC | #4

> -----Original Message-----
> From: Stephen Boyd [mailto:[e-mail]]
> Sent: Tuesday, December 4, 2018 3:46 AM
> To: [e-mail]; Aisheng DONG <[e-mail]>
> Cc: [e-mail]; [e-mail];
> [e-mail]; Fabio Estevam <[e-mail]>; dl-linux-imx
> <[e-mail]>; [e-mail]; Aisheng DONG
> <[e-mail]>
> Subject: Re: [PATCH V8 0/7] clk: imx: add imx8qxp clock support
> 
> Quoting Aisheng DONG (2018-11-21 06:12:16)
> > This patch series adds i.MX8QXP clock support which is based on the
> > clock service provided by SCU firmware.
> >
> > Note: It depends on SCU driver which has already been merged by Shawn.
> > So this patch series could go through Shawn's tree as well.
> 
> Any patches I didn't make comments on look good to go. Only a few
> comments to address and otherwise it looks good.

Great, I will address all your comments and re-send soon.
Thanks for the carefully review.

Regards
Dong Aisheng

Aisheng Dong Dec. 4, 2018, 1:53 a.m. UTC | #5

> -----Original Message-----
> From: Stephen Boyd [mailto:[e-mail]]
> Sent: Tuesday, December 4, 2018 2:39 AM
> To: [e-mail]; Aisheng DONG <[e-mail]>
> Cc: [e-mail]; [e-mail];
> [e-mail]; Fabio Estevam <[e-mail]>; dl-linux-imx
> <[e-mail]>; [e-mail]
> Subject: RE: [PATCH V8 0/7] clk: imx: add imx8qxp clock support
> 
> Quoting Aisheng DONG (2018-11-28 09:18:47)
> > Gently Ping...
> >
> 
> FYI, when you ping the thread, it floats to the end of the queue for me, and
> then I don't review it for some time. Sorry, this is how it mostly works. The
> bigger topics come to the front queue and then I try to get to those sooner and
> let the stuff churning as newest in the queue become lower priority because
> "someone else is doing something". I do sweeps over the new stuff every day
> or two to pick out the easy one liners and simple things because they may be
> critical, etc.

I fully understood. Thanks for your effort and help.

Regards
Dong Aisheng