| Message ID | 20181129221357.67417-1-evgreen@chromium.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | phy: qcom-qmp: Fix clock-cells binding and provider | expand |
Hi Andy Gross, David Brown, Vivek, On 30/11/18 3:43 AM, Evan Green wrote: > This series fixes the QMP PHY bindings, which had specified #clock-cells > in the parent node, and had set it to 1. Putting it in the parent node is > wrong because the clock providers are the child nodes, so this change > moves it there. Having it set to 1 is also wrong, since nothing is ever > specified as to what should go in that cell. So this changes it to zero. > Finally, this change completes a little bit of code to actually allow these > exposed clocks to be pointed at in DT. > > I had no idea how to fix up ipq8074.dtsi. It seems to be completely wrong in > that it doesn't specify #clock-cells at all, has no child nodes, and > specifies clock-output-names in the parent node. As far as I can tell this > doesn't work at all. But I can't add the child nodes myself because I don't know > 1) how many there are, and 2) the registers in them. I also have no way to test it. > > Speaking of testing, I was able to test this on sdm845, but haven't tested msm8996. Can someone help test this series in msm8996? Thanks Kishon > > This patch sits atop the UFS device nodes series [1]. > > [1] https://lore.kernel.org/lkml/20181026173544.136037-1-evgreen@chromium.org/ > > > > Evan Green (4): > dt-bindings: phy-qcom-qmp: Move #clock-cells to child > arm64: dts: qcom: msm8996: Fix QMP PHY #clock-cells > arm64: dts: qcom: sdm845: Fix QMP PHY #clock-cells > phy: qcom-qmp: Expose provided clocks to DT > > .../devicetree/bindings/phy/qcom-qmp-phy.txt | 11 ++++----- > arch/arm64/boot/dts/qcom/msm8996.dtsi | 6 +++-- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 4 ++-- > drivers/phy/qualcomm/phy-qcom-qmp.c | 23 ++++++++++++++++++- > 4 files changed, 33 insertions(+), 11 deletions(-) >
Hi Kishon, On Tue, Dec 4, 2018 at 1:44 PM Kishon Vijay Abraham I <kishon@ti.com> wrote: > > Hi Andy Gross, David Brown, Vivek, > > On 30/11/18 3:43 AM, Evan Green wrote: > > This series fixes the QMP PHY bindings, which had specified #clock-cells > > in the parent node, and had set it to 1. Putting it in the parent node is > > wrong because the clock providers are the child nodes, so this change > > moves it there. Having it set to 1 is also wrong, since nothing is ever > > specified as to what should go in that cell. So this changes it to zero. > > Finally, this change completes a little bit of code to actually allow these > > exposed clocks to be pointed at in DT. > > > > I had no idea how to fix up ipq8074.dtsi. It seems to be completely wrong in > > that it doesn't specify #clock-cells at all, has no child nodes, and > > specifies clock-output-names in the parent node. As far as I can tell this > > doesn't work at all. But I can't add the child nodes myself because I don't know > > 1) how many there are, and 2) the registers in them. I also have no way to test it. > > > > Speaking of testing, I was able to test this on sdm845, but haven't tested msm8996. > > Can someone help test this series in msm8996? Sure, will give it a try tomorrow. Thanks Vivek > > Thanks > Kishon > > > > > This patch sits atop the UFS device nodes series [1]. > > > > [1] https://lore.kernel.org/lkml/20181026173544.136037-1-evgreen@chromium.org/ > > > > > > > > Evan Green (4): > > dt-bindings: phy-qcom-qmp: Move #clock-cells to child > > arm64: dts: qcom: msm8996: Fix QMP PHY #clock-cells > > arm64: dts: qcom: sdm845: Fix QMP PHY #clock-cells > > phy: qcom-qmp: Expose provided clocks to DT > > > > .../devicetree/bindings/phy/qcom-qmp-phy.txt | 11 ++++----- > > arch/arm64/boot/dts/qcom/msm8996.dtsi | 6 +++-- > > arch/arm64/boot/dts/qcom/sdm845.dtsi | 4 ++-- > > drivers/phy/qualcomm/phy-qcom-qmp.c | 23 ++++++++++++++++++- > > 4 files changed, 33 insertions(+), 11 deletions(-) > >
Vivek, On 04/12/18 6:07 PM, Vivek Gautam wrote: > Hi Kishon, > > On Tue, Dec 4, 2018 at 1:44 PM Kishon Vijay Abraham I <kishon@ti.com> wrote: >> >> Hi Andy Gross, David Brown, Vivek, >> >> On 30/11/18 3:43 AM, Evan Green wrote: >>> This series fixes the QMP PHY bindings, which had specified #clock-cells >>> in the parent node, and had set it to 1. Putting it in the parent node is >>> wrong because the clock providers are the child nodes, so this change >>> moves it there. Having it set to 1 is also wrong, since nothing is ever >>> specified as to what should go in that cell. So this changes it to zero. >>> Finally, this change completes a little bit of code to actually allow these >>> exposed clocks to be pointed at in DT. >>> >>> I had no idea how to fix up ipq8074.dtsi. It seems to be completely wrong in >>> that it doesn't specify #clock-cells at all, has no child nodes, and >>> specifies clock-output-names in the parent node. As far as I can tell this >>> doesn't work at all. But I can't add the child nodes myself because I don't know >>> 1) how many there are, and 2) the registers in them. I also have no way to test it. >>> >>> Speaking of testing, I was able to test this on sdm845, but haven't tested msm8996. >> >> Can someone help test this series in msm8996? > > Sure, will give it a try tomorrow. I'm planning to close the merge by today. Can you test this series please? Thanks Kishon > > Thanks > Vivek > >> >> Thanks >> Kishon >> >>> >>> This patch sits atop the UFS device nodes series [1]. >>> >>> [1] https://lore.kernel.org/lkml/20181026173544.136037-1-evgreen@chromium.org/ >>> >>> >>> >>> Evan Green (4): >>> dt-bindings: phy-qcom-qmp: Move #clock-cells to child >>> arm64: dts: qcom: msm8996: Fix QMP PHY #clock-cells >>> arm64: dts: qcom: sdm845: Fix QMP PHY #clock-cells >>> phy: qcom-qmp: Expose provided clocks to DT >>> >>> .../devicetree/bindings/phy/qcom-qmp-phy.txt | 11 ++++----- >>> arch/arm64/boot/dts/qcom/msm8996.dtsi | 6 +++-- >>> arch/arm64/boot/dts/qcom/sdm845.dtsi | 4 ++-- >>> drivers/phy/qualcomm/phy-qcom-qmp.c | 23 ++++++++++++++++++- >>> 4 files changed, 33 insertions(+), 11 deletions(-) >>> > > >
Hi, On Fri, Dec 7, 2018 at 10:15 AM Kishon Vijay Abraham I <kishon@ti.com> wrote: > > Vivek, > > On 04/12/18 6:07 PM, Vivek Gautam wrote: > > Hi Kishon, > > > > On Tue, Dec 4, 2018 at 1:44 PM Kishon Vijay Abraham I <kishon@ti.com> wrote: > >> > >> Hi Andy Gross, David Brown, Vivek, > >> > >> On 30/11/18 3:43 AM, Evan Green wrote: > >>> This series fixes the QMP PHY bindings, which had specified #clock-cells > >>> in the parent node, and had set it to 1. Putting it in the parent node is > >>> wrong because the clock providers are the child nodes, so this change > >>> moves it there. Having it set to 1 is also wrong, since nothing is ever > >>> specified as to what should go in that cell. So this changes it to zero. > >>> Finally, this change completes a little bit of code to actually allow these > >>> exposed clocks to be pointed at in DT. > >>> > >>> I had no idea how to fix up ipq8074.dtsi. It seems to be completely wrong in > >>> that it doesn't specify #clock-cells at all, has no child nodes, and > >>> specifies clock-output-names in the parent node. As far as I can tell this > >>> doesn't work at all. But I can't add the child nodes myself because I don't know > >>> 1) how many there are, and 2) the registers in them. I also have no way to test it. > >>> > >>> Speaking of testing, I was able to test this on sdm845, but haven't tested msm8996. > >> > >> Can someone help test this series in msm8996? > > > > Sure, will give it a try tomorrow. > > I'm planning to close the merge by today. Can you test this series please? Sorry, got held up with an issue yesterday. Will update you in couple of hours. Thanks Vivek [snip]