| Message ID | 20181130192737.15053-4-jarkko.sakkinen@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Zero ****s, hugload of hugs <3 | expand |
On Fri, Nov 30, 2018 at 5:30 PM Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> wrote: > > In order to comply with the CoC, replace **** with a hug. > > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> > --- > drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c | 2 +- > drivers/gpu/drm/nouveau/nvkm/subdev/pmu/fuc/macros.fuc | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c > index 9cc10e438b3d..55a0060881ea 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c > @@ -446,7 +446,7 @@ init_ram_restrict(struct nvbios_init *init) > { > /* This appears to be the behaviour of the VBIOS parser, and *is* > * important to cache the NV_PEXTDEV_BOOT0 on later chipsets to > - * avoid fucking up the memory controller (somehow) by reading it > + * avoid hugging up the memory controller (somehow) by reading it > * on every INIT_RAM_RESTRICT_ZM_GROUP opcode. > * > * Preserving the non-caching behaviour on earlier chipsets just > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/fuc/macros.fuc b/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/fuc/macros.fuc > index 3737bd27f74e..ee364c71cc2e 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/fuc/macros.fuc > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/fuc/macros.fuc > @@ -46,7 +46,7 @@ > #define NV_PPWR_INTR_EN_SET_SUBINTR 0x00000800 > #define NV_PPWR_INTR_EN_SET_WATCHDOG 0x00000002 > #define NV_PPWR_INTR_EN_CLR 0x0014 > -#define NV_PPWR_INTR_EN_CLR_MASK /* fuck i hate envyas */ -1 > +#define NV_PPWR_INTR_EN_CLR_MASK /* hug i hate envyas */ -1 Can you also capitalize the "i" please? Thanks, Diego
On Fri, Nov 30, 2018 at 06:13:50PM -0200, Diego Viola wrote: > On Fri, Nov 30, 2018 at 5:30 PM Jarkko Sakkinen > <jarkko.sakkinen@linux.intel.com> wrote: > > > > In order to comply with the CoC, replace **** with a hug. > > > > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> > > --- > > drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c | 2 +- > > drivers/gpu/drm/nouveau/nvkm/subdev/pmu/fuc/macros.fuc | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c > > index 9cc10e438b3d..55a0060881ea 100644 > > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c > > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c > > @@ -446,7 +446,7 @@ init_ram_restrict(struct nvbios_init *init) > > { > > /* This appears to be the behaviour of the VBIOS parser, and *is* > > * important to cache the NV_PEXTDEV_BOOT0 on later chipsets to > > - * avoid fucking up the memory controller (somehow) by reading it > > + * avoid hugging up the memory controller (somehow) by reading it > > * on every INIT_RAM_RESTRICT_ZM_GROUP opcode. > > * > > * Preserving the non-caching behaviour on earlier chipsets just > > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/fuc/macros.fuc b/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/fuc/macros.fuc > > index 3737bd27f74e..ee364c71cc2e 100644 > > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/fuc/macros.fuc > > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/fuc/macros.fuc > > @@ -46,7 +46,7 @@ > > #define NV_PPWR_INTR_EN_SET_SUBINTR 0x00000800 > > #define NV_PPWR_INTR_EN_SET_WATCHDOG 0x00000002 > > #define NV_PPWR_INTR_EN_CLR 0x0014 > > -#define NV_PPWR_INTR_EN_CLR_MASK /* fuck i hate envyas */ -1 > > +#define NV_PPWR_INTR_EN_CLR_MASK /* hug i hate envyas */ -1 > > Can you also capitalize the "i" please? Yeah, maybe I just change it as "/* I hate envyas */"? /Jarkko
On Fri, Nov 30, 2018 at 7:26 PM Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> wrote: > > On Fri, Nov 30, 2018 at 06:13:50PM -0200, Diego Viola wrote: > > On Fri, Nov 30, 2018 at 5:30 PM Jarkko Sakkinen > > <jarkko.sakkinen@linux.intel.com> wrote: > > > > > > In order to comply with the CoC, replace **** with a hug. > > > > > > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> > > > --- > > > drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c | 2 +- > > > drivers/gpu/drm/nouveau/nvkm/subdev/pmu/fuc/macros.fuc | 2 +- > > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c > > > index 9cc10e438b3d..55a0060881ea 100644 > > > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c > > > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c > > > @@ -446,7 +446,7 @@ init_ram_restrict(struct nvbios_init *init) > > > { > > > /* This appears to be the behaviour of the VBIOS parser, and *is* > > > * important to cache the NV_PEXTDEV_BOOT0 on later chipsets to > > > - * avoid fucking up the memory controller (somehow) by reading it > > > + * avoid hugging up the memory controller (somehow) by reading it > > > * on every INIT_RAM_RESTRICT_ZM_GROUP opcode. > > > * > > > * Preserving the non-caching behaviour on earlier chipsets just > > > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/fuc/macros.fuc b/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/fuc/macros.fuc > > > index 3737bd27f74e..ee364c71cc2e 100644 > > > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/fuc/macros.fuc > > > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/fuc/macros.fuc > > > @@ -46,7 +46,7 @@ > > > #define NV_PPWR_INTR_EN_SET_SUBINTR 0x00000800 > > > #define NV_PPWR_INTR_EN_SET_WATCHDOG 0x00000002 > > > #define NV_PPWR_INTR_EN_CLR 0x0014 > > > -#define NV_PPWR_INTR_EN_CLR_MASK /* fuck i hate envyas */ -1 > > > +#define NV_PPWR_INTR_EN_CLR_MASK /* hug i hate envyas */ -1 > > > > Can you also capitalize the "i" please? > > Yeah, maybe I just change it as "/* I hate envyas */"? > > /Jarkko Yes, that looks better. Thanks, Diego
Hi, I'm just a random user, and I don't really care about the CoC, but I do care about the code quality. And with that I think a good comment SHOULD be polite and anonymous. So why not change first one with "messing" or "corrupting", and remove the second one since it does not being any information but the author pov. My 2 cents, trying to avoid to feed the CoC troll. Cheers <div dir="auto">Hi,<div dir="auto"><br><div dir="auto">I'm just a random user, and I don't really care about the CoC, but I do care about the code quality. And with that I think a good comment SHOULD be polite and anonymous. So why not change first one with "messing" or "corrupting", and remove the second one since it does not being any information but the author pov.</div><div dir="auto"><br></div><div dir="auto">My 2 cents, trying to avoid to feed the CoC troll.</div><div dir="auto"><br></div><div dir="auto">Cheers</div></div></div>
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c index 9cc10e438b3d..55a0060881ea 100644 --- a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c @@ -446,7 +446,7 @@ init_ram_restrict(struct nvbios_init *init) { /* This appears to be the behaviour of the VBIOS parser, and *is* * important to cache the NV_PEXTDEV_BOOT0 on later chipsets to - * avoid fucking up the memory controller (somehow) by reading it + * avoid hugging up the memory controller (somehow) by reading it * on every INIT_RAM_RESTRICT_ZM_GROUP opcode. * * Preserving the non-caching behaviour on earlier chipsets just diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/fuc/macros.fuc b/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/fuc/macros.fuc index 3737bd27f74e..ee364c71cc2e 100644 --- a/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/fuc/macros.fuc +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/fuc/macros.fuc @@ -46,7 +46,7 @@ #define NV_PPWR_INTR_EN_SET_SUBINTR 0x00000800 #define NV_PPWR_INTR_EN_SET_WATCHDOG 0x00000002 #define NV_PPWR_INTR_EN_CLR 0x0014 -#define NV_PPWR_INTR_EN_CLR_MASK /* fuck i hate envyas */ -1 +#define NV_PPWR_INTR_EN_CLR_MASK /* hug i hate envyas */ -1 #define NV_PPWR_INTR_ROUTE 0x001c #define NV_PPWR_TIMER_LOW 0x002c #define NV_PPWR_WATCHDOG_TIME 0x0034
In order to comply with the CoC, replace **** with a hug. Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> --- drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c | 2 +- drivers/gpu/drm/nouveau/nvkm/subdev/pmu/fuc/macros.fuc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)