| Message ID | 1542535751-16079-4-git-send-email-pawell@cadence.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Introduced new Cadence USBSS DRD Driver | expand |
On 18/11/18 12:08, Pawel Laszczak wrote: > Thsi patch aim at documenting USB related dt-bindings for the s/Thsi/This > Cadence USBSS-DRD controller. > > Signed-off-by: Pawel Laszczak <pawell@cadence.com> > --- > .../devicetree/bindings/usb/cdns3-usb.txt | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/cdns3-usb.txt > > diff --git a/Documentation/devicetree/bindings/usb/cdns3-usb.txt b/Documentation/devicetree/bindings/usb/cdns3-usb.txt > new file mode 100644 > index 000000000000..f9e953f32d47 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/cdns3-usb.txt > @@ -0,0 +1,17 @@ > +Binding for the Cadence USBSS-DRD controller > + > +Required properties: > + - reg: Physical base address and size of the controller's register area. > + - compatible: Should contain: "cdns,usb3" > + - interrupts: Interrupt specifier. Refer to interrupt bindings. Do you also comply with USB generic bindings for dr_mode, speed, etc? i.e. Documentation/devicetree/bindings/usb/generic.txt If yes it must be mentioned in Optional properties: > + > + > +Example: > + cdns3@f3000000 { > + compatible = "cdns,usb3"; > + interrupts = <USB_IRQ 7 IRQ_TYPE_LEVEL_HIGH>; > + reg = <0xf3000000 0x10000 //memory area for OTG/DRD registers > + 0xf3010000 0x10000 //memory area for HOST registers > + 0xf3020000 0x10000>; //memory area for Device registers > + }; > + > cheers, -roger
Hi Roger >On 18/11/18 12:08, Pawel Laszczak wrote: >> Thsi patch aim at documenting USB related dt-bindings for the > >s/Thsi/This > >> Cadence USBSS-DRD controller. >> >> Signed-off-by: Pawel Laszczak <pawell@cadence.com> >> --- >> .../devicetree/bindings/usb/cdns3-usb.txt | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/usb/cdns3-usb.txt >> >> diff --git a/Documentation/devicetree/bindings/usb/cdns3-usb.txt b/Documentation/devicetree/bindings/usb/cdns3-usb.txt >> new file mode 100644 >> index 000000000000..f9e953f32d47 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/usb/cdns3-usb.txt >> @@ -0,0 +1,17 @@ >> +Binding for the Cadence USBSS-DRD controller >> + >> +Required properties: >> + - reg: Physical base address and size of the controller's register area. >> + - compatible: Should contain: "cdns,usb3" >> + - interrupts: Interrupt specifier. Refer to interrupt bindings. > >Do you also comply with USB generic bindings for dr_mode, speed, etc? >i.e. Documentation/devicetree/bindings/usb/generic.txt > >If yes it must be mentioned in Optional properties: I took a look at this document and I think that only dr_mode and maximum-speed make sense as optional parameters. I will add these two as optional. Thanks. > >> + >> + >> +Example: >> + cdns3@f3000000 { >> + compatible = "cdns,usb3"; >> + interrupts = <USB_IRQ 7 IRQ_TYPE_LEVEL_HIGH>; >> + reg = <0xf3000000 0x10000 //memory area for OTG/DRD registers >> + 0xf3010000 0x10000 //memory area for HOST registers >> + 0xf3020000 0x10000>; //memory area for Device registers >> + }; >> + >> > >cheers, >-roger >-- >Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. >Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki Cheers, Pawel
On Sun, Nov 18, 2018 at 10:08:59AM +0000, Pawel Laszczak wrote: > Thsi patch aim at documenting USB related dt-bindings for the typo > Cadence USBSS-DRD controller. > > Signed-off-by: Pawel Laszczak <pawell@cadence.com> > --- > .../devicetree/bindings/usb/cdns3-usb.txt | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/cdns3-usb.txt > > diff --git a/Documentation/devicetree/bindings/usb/cdns3-usb.txt b/Documentation/devicetree/bindings/usb/cdns3-usb.txt > new file mode 100644 > index 000000000000..f9e953f32d47 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/cdns3-usb.txt > @@ -0,0 +1,17 @@ > +Binding for the Cadence USBSS-DRD controller > + > +Required properties: > + - reg: Physical base address and size of the controller's register area. 1 or 3 regions? If 3, what is each one and the order? > + - compatible: Should contain: "cdns,usb3" Only one version and one set of bugs? > + - interrupts: Interrupt specifier. Refer to interrupt bindings. How many interrupts? > + > + > +Example: > + cdns3@f3000000 { usb@... > + compatible = "cdns,usb3"; > + interrupts = <USB_IRQ 7 IRQ_TYPE_LEVEL_HIGH>; > + reg = <0xf3000000 0x10000 //memory area for OTG/DRD registers > + 0xf3010000 0x10000 //memory area for HOST registers > + 0xf3020000 0x10000>; //memory area for Device registers > + }; > + > -- > 2.17.1 >
Hi, >On Sun, Nov 18, 2018 at 10:08:59AM +0000, Pawel Laszczak wrote: >> Thsi patch aim at documenting USB related dt-bindings for the > >typo > >> Cadence USBSS-DRD controller. >> >> Signed-off-by: Pawel Laszczak <pawell@cadence.com> >> --- >> .../devicetree/bindings/usb/cdns3-usb.txt | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/usb/cdns3-usb.txt >> >> diff --git a/Documentation/devicetree/bindings/usb/cdns3-usb.txt b/Documentation/devicetree/bindings/usb/cdns3-usb.txt >> new file mode 100644 >> index 000000000000..f9e953f32d47 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/usb/cdns3-usb.txt >> @@ -0,0 +1,17 @@ >> +Binding for the Cadence USBSS-DRD controller >> + >> +Required properties: >> + - reg: Physical base address and size of the controller's register area. > >1 or 3 regions? If 3, what is each one and the order? I will add extra description. > >> + - compatible: Should contain: "cdns,usb3" > >Only one version and one set of bugs? Yes, currently we have only one version. > >> + - interrupts: Interrupt specifier. Refer to interrupt bindings. > >How many interrupts? Single line for Device/Host/OTG I will add description > >> + >> + >> +Example: >> + cdns3@f3000000 { > >usb@... > Ok. >> + compatible = "cdns,usb3"; >> + interrupts = <USB_IRQ 7 IRQ_TYPE_LEVEL_HIGH>; >> + reg = <0xf3000000 0x10000 //memory area for OTG/DRD registers >> + 0xf3010000 0x10000 //memory area for HOST registers >> + 0xf3020000 0x10000>; //memory area for Device registers >> + }; >> + >> -- >> 2.17.1 >> Thanks, Cheers Pawel
diff --git a/Documentation/devicetree/bindings/usb/cdns3-usb.txt b/Documentation/devicetree/bindings/usb/cdns3-usb.txt new file mode 100644 index 000000000000..f9e953f32d47 --- /dev/null +++ b/Documentation/devicetree/bindings/usb/cdns3-usb.txt @@ -0,0 +1,17 @@ +Binding for the Cadence USBSS-DRD controller + +Required properties: + - reg: Physical base address and size of the controller's register area. + - compatible: Should contain: "cdns,usb3" + - interrupts: Interrupt specifier. Refer to interrupt bindings. + + +Example: + cdns3@f3000000 { + compatible = "cdns,usb3"; + interrupts = <USB_IRQ 7 IRQ_TYPE_LEVEL_HIGH>; + reg = <0xf3000000 0x10000 //memory area for OTG/DRD registers + 0xf3010000 0x10000 //memory area for HOST registers + 0xf3020000 0x10000>; //memory area for Device registers + }; +
Thsi patch aim at documenting USB related dt-bindings for the Cadence USBSS-DRD controller. Signed-off-by: Pawel Laszczak <pawell@cadence.com> --- .../devicetree/bindings/usb/cdns3-usb.txt | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 Documentation/devicetree/bindings/usb/cdns3-usb.txt