| Message ID | 1543925069-8838-8-git-send-email-galpress@amazon.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Elastic Fabric Adapter (EFA) driver | expand |
On Tue, Dec 04, 2018 at 02:04:23PM +0200, Gal Pressman wrote: > Add the EFA ABI file. > > Signed-off-by: Gal Pressman <galpress@amazon.com> > include/uapi/rdma/efa-abi.h | 89 +++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 89 insertions(+) > create mode 100644 include/uapi/rdma/efa-abi.h > > diff --git a/include/uapi/rdma/efa-abi.h b/include/uapi/rdma/efa-abi.h > new file mode 100644 > index 000000000000..0f97a0fba967 > +++ b/include/uapi/rdma/efa-abi.h > @@ -0,0 +1,89 @@ > +/* SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause */ > +/* > + * Copyright 2018 Amazon.com, Inc. or its affiliates. > + */ > + > +#ifndef _EFA_ABI_H_ > +#define _EFA_ABI_H_ > + > +enum efa_ibv_user_cmds_supp_udata { > + EFA_USER_CMDS_SUPP_UDATA_QUERY_DEVICE = 1 << 0, > + EFA_USER_CMDS_SUPP_UDATA_CREATE_AH = 1 << 1, > +}; > + > +enum efa_ibv_kernel_supp_mask { > + EFA_KERNEL_SUPP_QPT_SRD = 1 << 0, > +}; > + > +struct efa_ibv_alloc_ucontext_resp { > + __u32 comp_mask; > + __u32 cmds_supp_udata_mask; > + __u32 kernel_supp_mask; > + __u8 reserved_60[0x4]; The use of _60 is a bit non-conventional for these headers, the trailing reserved should usually just be reserved.. Jason
On 04-Dec-18 18:01, Jason Gunthorpe wrote: > On Tue, Dec 04, 2018 at 02:04:23PM +0200, Gal Pressman wrote: >> Add the EFA ABI file. >> >> Signed-off-by: Gal Pressman <galpress@amazon.com> >> include/uapi/rdma/efa-abi.h | 89 +++++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 89 insertions(+) >> create mode 100644 include/uapi/rdma/efa-abi.h >> >> diff --git a/include/uapi/rdma/efa-abi.h b/include/uapi/rdma/efa-abi.h >> new file mode 100644 >> index 000000000000..0f97a0fba967 >> +++ b/include/uapi/rdma/efa-abi.h >> @@ -0,0 +1,89 @@ >> +/* SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause */ >> +/* >> + * Copyright 2018 Amazon.com, Inc. or its affiliates. >> + */ >> + >> +#ifndef _EFA_ABI_H_ >> +#define _EFA_ABI_H_ >> + >> +enum efa_ibv_user_cmds_supp_udata { >> + EFA_USER_CMDS_SUPP_UDATA_QUERY_DEVICE = 1 << 0, >> + EFA_USER_CMDS_SUPP_UDATA_CREATE_AH = 1 << 1, >> +}; >> + >> +enum efa_ibv_kernel_supp_mask { >> + EFA_KERNEL_SUPP_QPT_SRD = 1 << 0, >> +}; >> + >> +struct efa_ibv_alloc_ucontext_resp { >> + __u32 comp_mask; >> + __u32 cmds_supp_udata_mask; >> + __u32 kernel_supp_mask; >> + __u8 reserved_60[0x4]; > > The use of _60 is a bit non-conventional for these headers, the > trailing reserved should usually just be reserved.. > > Jason > The _60 states the offset of the field inside the struct, makes it more readable than having a plain reserved.
Hi Gal,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on rdma/for-next]
[also build test WARNING on v4.20-rc5 next-20181204]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Gal-Pressman/Elastic-Fabric-Adapter-EFA-driver/20181205-064703
base: https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git for-next
config: riscv-tinyconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 8.1.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=8.1.0 make.cross ARCH=riscv
All warnings (new ones prefixed by >>):
>> ./usr/include/rdma/efa-abi.h:19: found __[us]{8,16,32,64} type without #include <linux/types.h>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
diff --git a/include/uapi/rdma/efa-abi.h b/include/uapi/rdma/efa-abi.h new file mode 100644 index 000000000000..0f97a0fba967 --- /dev/null +++ b/include/uapi/rdma/efa-abi.h @@ -0,0 +1,89 @@ +/* SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause */ +/* + * Copyright 2018 Amazon.com, Inc. or its affiliates. + */ + +#ifndef _EFA_ABI_H_ +#define _EFA_ABI_H_ + +enum efa_ibv_user_cmds_supp_udata { + EFA_USER_CMDS_SUPP_UDATA_QUERY_DEVICE = 1 << 0, + EFA_USER_CMDS_SUPP_UDATA_CREATE_AH = 1 << 1, +}; + +enum efa_ibv_kernel_supp_mask { + EFA_KERNEL_SUPP_QPT_SRD = 1 << 0, +}; + +struct efa_ibv_alloc_ucontext_resp { + __u32 comp_mask; + __u32 cmds_supp_udata_mask; + __u32 kernel_supp_mask; + __u8 reserved_60[0x4]; +}; + +struct efa_ibv_alloc_pd_resp { + __u32 comp_mask; + __u32 pdn; +}; + +struct efa_ibv_create_cq { + __u32 comp_mask; + __u32 cq_entry_size; + __u16 num_sub_cqs; + __u8 reserved_50[0x6]; +}; + +struct efa_ibv_create_cq_resp { + __u32 comp_mask; + __u8 reserved_20[0x4]; + __aligned_u64 q_mmap_key; + __aligned_u64 q_mmap_size; + __u16 cq_idx; + __u8 reserved_d0[0x6]; +}; + +struct efa_ibv_create_qp { + __u32 comp_mask; + __u32 rq_entries; + __u32 rq_entry_size; + __u32 sq_depth; + __u32 sq_ring_size; + __u32 srd_qp; +}; + +struct efa_ibv_create_qp_resp { + __u32 comp_mask; + /* the offset inside the page of the rq db */ + __u32 rq_db_offset; + /* the offset inside the page of the sq db */ + __u32 sq_db_offset; + /* the offset inside the page of descriptors buffer */ + __u32 llq_desc_offset; + __aligned_u64 rq_mmap_key; + __aligned_u64 rq_mmap_size; + __aligned_u64 rq_db_mmap_key; + __aligned_u64 sq_db_mmap_key; + __aligned_u64 llq_desc_mmap_key; + __u16 send_sub_cq_idx; + __u16 recv_sub_cq_idx; + __u8 reserved_1e0[0x4]; +}; + +struct efa_ibv_create_ah_resp { + __u32 comp_mask; + __u16 efa_address_handle; + __u8 reserved_30[0x2]; +}; + +struct efa_ibv_ex_query_device_resp { + __u32 comp_mask; + __u16 max_sq_sge; + __u16 max_rq_sge; + __u16 max_sq_wr; + __u16 max_rq_wr; + __u16 sub_cqs_per_cq; + __u16 max_inline_data; +}; + +#endif /* _EFA_ABI_H_ */
Add the EFA ABI file. Signed-off-by: Gal Pressman <galpress@amazon.com> --- include/uapi/rdma/efa-abi.h | 89 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 89 insertions(+) create mode 100644 include/uapi/rdma/efa-abi.h