mbox series

[0/3] Small improvements to the appledisplay driver

Message ID 20181204224337.29122-1-alex.theissen@me.com (mailing list archive)
Headers show
Series Small improvements to the appledisplay driver | expand

Message

alex.theissen@me.com Dec. 4, 2018, 10:43 p.m. UTC 
With the exception of the first patch I am not entirely sure if my changes are
correct and justified. This is my first contribution and I am equally satisfied
if someone could point out why my changes are not correct.

The added display is my own and works well with the driver.

drivers/usb/misc/appledisplay.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

Comments

Greg Kroah-Hartman Dec. 5, 2018, 9:42 a.m. UTC | #1 
On Tue, Dec 04, 2018 at 11:43:34PM +0100, alex.theissen@me.com wrote:
> With the exception of the first patch I am not entirely sure if my changes are
> correct and justified. This is my first contribution and I am equally satisfied
> if someone could point out why my changes are not correct.
> 
> The added display is my own and works well with the driver.

All looks good to me, thanks for the patches!

greg k-h
Mattias Jacobsson Dec. 7, 2018, 10:39 a.m. UTC | #2 
> On 5 Dec 2018, at 10:42, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
>> On Tue, Dec 04, 2018 at 11:43:34PM +0100, alex.theissen@me.com wrote:
>> With the exception of the first patch I am not entirely sure if my changes are
>> correct and justified. This is my first contribution and I am equally satisfied
>> if someone could point out why my changes are not correct.
>> 
>> The added display is my own and works well with the driver.
> 
> All looks good to me, thanks for the patches!
> 
> greg k-h

I've tested patch 2/3 and 3/3 applied together on top of the upstream appledisplay driver. They work well for me. I can offer a;

Tested-by: Mattias Jacobsson <2pi@mok.nu>

for them if it isn't too late.

Thanks,
Mattias