diff mbox series

[resend] dt-bindings: sound: Add documentation for pcm3060 property out-single-ended

Message ID 20181115071253.22558-1-kmarinushkin@birdec.tech (mailing list archive)
State Accepted
Headers show
Series [resend] dt-bindings: sound: Add documentation for pcm3060 property out-single-ended | expand

Commit Message

Kirill Marinushkin Nov. 15, 2018, 7:12 a.m. UTC
Output of pcm3060 codec may be configured as single-ended or differential

Signed-off-by: Kirill Marinushkin <kmarinushkin@birdec.tech>
Cc: devicetree@vger.kernel.org
---
Hello Mark,

yesterday there was a misunderstanding: when I wrote you

> I think you forgot one patch in the series

you accidently applied the already-applied patch instead of the forgotten
one. To avoid the confusion, in this e-mail I resend you the proper
forgotten patch in a separate mailing thread.

Please apply this patch for-next.

Best Regards,
Kirill
---
 Documentation/devicetree/bindings/sound/pcm3060.txt | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Rob Herring (Arm) Dec. 4, 2018, 9:43 p.m. UTC | #1
On Thu, 15 Nov 2018 08:12:53 +0100, Kirill Marinushkin wrote:
> Output of pcm3060 codec may be configured as single-ended or differential
> 
> Signed-off-by: Kirill Marinushkin <kmarinushkin@birdec.tech>
> Cc: devicetree@vger.kernel.org
> ---
> Hello Mark,
> 
> yesterday there was a misunderstanding: when I wrote you
> 
> > I think you forgot one patch in the series
> 
> you accidently applied the already-applied patch instead of the forgotten
> one. To avoid the confusion, in this e-mail I resend you the proper
> forgotten patch in a separate mailing thread.
> 
> Please apply this patch for-next.
> 
> Best Regards,
> Kirill
> ---
>  Documentation/devicetree/bindings/sound/pcm3060.txt | 6 ++++++
>  1 file changed, 6 insertions(+)
> 

Reviewed-by: Rob Herring <robh@kernel.org>
Kirill Marinushkin Dec. 5, 2018, 7:04 a.m. UTC | #2
Thank you Rob,

Mark already applied this patch, with a slightly modified subject:

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/commit/?h=for-next&id=fd7de6370cb62b147185834d60069568a21acacd

Best Regards,
Kirill

On 12/04/18 22:43, Rob Herring wrote:
> On Thu, 15 Nov 2018 08:12:53 +0100, Kirill Marinushkin wrote:
>> Output of pcm3060 codec may be configured as single-ended or differential
>>
>> Signed-off-by: Kirill Marinushkin <kmarinushkin@birdec.tech>
>> Cc: devicetree@vger.kernel.org
>> ---
>> Hello Mark,
>>
>> yesterday there was a misunderstanding: when I wrote you
>>
>>> I think you forgot one patch in the series
>>
>> you accidently applied the already-applied patch instead of the forgotten
>> one. To avoid the confusion, in this e-mail I resend you the proper
>> forgotten patch in a separate mailing thread.
>>
>> Please apply this patch for-next.
>>
>> Best Regards,
>> Kirill
>> ---
>>  Documentation/devicetree/bindings/sound/pcm3060.txt | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
> 
> Reviewed-by: Rob Herring <robh@kernel.org>
>
Rob Herring (Arm) Dec. 5, 2018, 3:28 p.m. UTC | #3
On Wed, Dec 5, 2018 at 1:02 AM Kirill Marinushkin
<kmarinushkin@birdec.tech> wrote:
>
> Thank you Rob,
>
> Mark already applied this patch, with a slightly modified subject:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/commit/?h=for-next&id=fd7de6370cb62b147185834d60069568a21acacd

Humm, I wonder why I didn't have Mark's "Applied ..." email for it?
Otherwise, my scripts rely on the subject matching which breaks when
maintainers edit subjects.

Rob
Mark Brown Dec. 5, 2018, 3:42 p.m. UTC | #4
On Wed, Dec 05, 2018 at 09:28:51AM -0600, Rob Herring wrote:
> On Wed, Dec 5, 2018 at 1:02 AM Kirill Marinushkin

> > Mark already applied this patch, with a slightly modified subject:
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/commit/?h=for-next&id=fd7de6370cb62b147185834d60069568a21acacd

> Humm, I wonder why I didn't have Mark's "Applied ..." email for it?
> Otherwise, my scripts rely on the subject matching which breaks when
> maintainers edit subjects.

Probably due to some problem contacting patchwork, the CC list comes
from patchwork so if that (or the network to it) is unstable then the
scripts can't get anything that's not in the actual commit.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/sound/pcm3060.txt b/Documentation/devicetree/bindings/sound/pcm3060.txt
index 90fcb8523099..97de66932d44 100644
--- a/Documentation/devicetree/bindings/sound/pcm3060.txt
+++ b/Documentation/devicetree/bindings/sound/pcm3060.txt
@@ -9,9 +9,15 @@  Required properties:
 - reg : the I2C address of the device for I2C, the chip select
         number for SPI.
 
+Optional properties:
+
+- ti,out-single-ended: "true" if output is single-ended;
+                       "false" or not specified if output is differential.
+
 Examples:
 
 	pcm3060: pcm3060@46 {
 		 compatible = "ti,pcm3060";
 		 reg = <0x46>;
+		 ti,out-single-ended = "true";
 	};