| Message ID | 20181205004228.10714-1-peter.hutterer@who-t.net (mailing list archive) |
|---|---|
| Headers | show |
| Series | HID: MS and Logitech high-resolution scroll wheel support | expand |
On Tue, 4 Dec 2018 at 16:42, Peter Hutterer <peter.hutterer@who-t.net> wrote: > > A full explanation of why and what is in the v1, v2 patch thread here: > https://lkml.org/lkml/2018/11/22/625 > > v3 adds a better commit messages, m560 REL_HWHEEL_HI_RES support and a patch > moved in the ordering. This is a full patch sequence because Benjamin's > magic scripts struggle with singular updates ;) I've retested with the same Logitech mice as before, except for the MX Anywhere 2S, which is currently not available to me. So, for reference, that's the MX Master 2S, Performance MX, M560, Anywhere MX, and the M325 (to check low-resolution scrolling). Verified-by: Harry Cutts <hcutts@chromium.org> Harry Cutts Chrome OS Touch/Input team
On Wed, Dec 5, 2018 at 10:57 PM Harry Cutts <hcutts@chromium.org> wrote: > > On Tue, 4 Dec 2018 at 16:42, Peter Hutterer <peter.hutterer@who-t.net> wrote: > > > > A full explanation of why and what is in the v1, v2 patch thread here: > > https://lkml.org/lkml/2018/11/22/625 > > > > v3 adds a better commit messages, m560 REL_HWHEEL_HI_RES support and a patch > > moved in the ordering. This is a full patch sequence because Benjamin's > > magic scripts struggle with singular updates ;) > > I've retested with the same Logitech mice as before, except for the MX > Anywhere 2S, which is currently not available to me. So, for > reference, that's the MX Master 2S, Performance MX, M560, Anywhere MX, > and the M325 (to check low-resolution scrolling). > > Verified-by: Harry Cutts <hcutts@chromium.org> Thanks everybody, especially Peter for respinning and re-writing the series, and writing the tests in hid-tools. I was a little bit afraid when I checked `libinput debug-gui` as the low res cursor was not moving if I were to scroll back and forth of just one notch. However, checking debug-events of a non high-res aware libinput showed that the low res wheel events were correctly emitted. So I guess this is a debug-gui issue. I have now queued this for 4.21. I do hope this will be smoother this time. Cheers, Benjamin
A full explanation of why and what is in the v1, v2 patch thread here: https://lkml.org/lkml/2018/11/22/625 v3 adds a better commit messages, m560 REL_HWHEEL_HI_RES support and a patch moved in the ordering. This is a full patch sequence because Benjamin's magic scripts struggle with singular updates ;) hid-tools patches to add the tests: https://gitlab.freedesktop.org/libevdev/hid-tools/merge_requests/12 libinput support (unmerged): https://gitlab.freedesktop.org/whot/libinput/tree/wip/hi-res-scrolling If you want to 'feel' how it works, run sudo ./builddir/libinput-debug-gui and watch the green/red scroll bars. On a device with hi-res scrolling the green bar (scroll fractions) will move smoother than the red bar (wheel clicks). Tested with: - Microsoft Comfort Optical Mouse 3000 - Microsoft Sculpt Ergonomic Mouse - Microsoft Wireless Mobile Mouse 4000 - Logitech MX Anywhere 2S And a few other mice that don't have that feature, so the testing was of limited excitement. Cheers, Peter Harry Cutts (3): HID: logitech: Add function to enable HID++ 1.0 "scrolling acceleration" HID: logitech: Enable high-resolution scrolling on Logitech mice HID: logitech: Use LDJ_DEVICE macro for existing Logitech mice Peter Hutterer (5): Input: add `REL_WHEEL_HI_RES` and `REL_HWHEEL_HI_RES` HID: core: store the collections as a basic tree HID: core: process the Resolution Multiplier HID: input: use the Resolution Multiplier for high-resolution scrolling HID: logitech-hidpp: fix typo, hiddpp to hidpp Documentation/input/event-codes.rst | 21 +++- drivers/hid/hid-core.c | 174 +++++++++++++++++++++++++++++++++ drivers/hid/hid-input.c | 108 +++++++++++++++++++- drivers/hid/hid-logitech-hidpp.c | 375 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------- include/linux/hid.h | 10 ++ include/uapi/linux/input-event-codes.h | 2 + 6 files changed, 651 insertions(+), 39 deletions(-)