| Message ID | 20181101052530.wcdusf5xc7l6pihz@kili.mountain (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 9ae4f8420ed7be4b13c96600e3568c144d101a23 |
| Headers | show |
| Series | scsi: bnx2fc: Fix NULL dereference in error handling | expand |
Dan, > If "interface" is NULL then we can't release it and trying to will > only lead to an Oops. Applied to 4.20/scsi-fixes, thanks!
diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c index cd160f2ec75d..bcd30e2374f1 100644 --- a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c +++ b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c @@ -2364,7 +2364,7 @@ static int _bnx2fc_create(struct net_device *netdev, if (!interface) { printk(KERN_ERR PFX "bnx2fc_interface_create failed\n"); rc = -ENOMEM; - goto ifput_err; + goto netdev_err; } if (is_vlan_dev(netdev)) {
If "interface" is NULL then we can't release it and trying to will only lead to an Oops. Fixes: aea71a024914 ("[SCSI] bnx2fc: Introduce interface structure for each vlan interface") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)