diff mbox series

USB: serial: option: add Fibocom NL668 series

Message ID CAMu45b9zqw_qu6+eKpiXbaXG4ZSDRYPUF_N7WMUQ=m0h+cZjvw@mail.gmail.com (mailing list archive)
State Superseded
Headers show
Series USB: serial: option: add Fibocom NL668 series | expand

Commit Message

Jörgen Storvist Dec. 9, 2018, 8:41 p.m. UTC
Added USB serial option driver support for Fibocom NL668 series cellular module.
Reserved USB endpoints 4 and 5 for network interfaces.

Signed-off-by: Jörgen Storvist <jorgen.storvist@gmail.com>

drivers/usb/serial/option.c | 5 +++++
1 file changed, 5 insertions(+)

+   .driver_info = RSVD(4) | RSVD(5) },
  { } /* Terminating entry */
 };
 MODULE_DEVICE_TABLE(usb, option_ids);

Comments

Greg KH Dec. 10, 2018, 7:16 a.m. UTC | #1
On Sun, Dec 09, 2018 at 09:41:13PM +0100, Jörgen Storvist wrote:
> Added USB serial option driver support for Fibocom NL668 series cellular module.
> Reserved USB endpoints 4 and 5 for network interfaces.
> 
> Signed-off-by: Jörgen Storvist <jorgen.storvist@gmail.com>
> 
> drivers/usb/serial/option.c | 5 +++++
> 1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index e24ff16..f2cc85c 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -552,6 +552,9 @@ static void option_instat_callback(struct urb *urb);
>  #define WETELECOM_PRODUCT_6802 0x6802
>  #define WETELECOM_PRODUCT_WMD300 0x6803
> 
> +/* Fibocom products */
> +#define FIBOCOM_VENDOR_ID    0x1508
> +#define FIBOCOM_PRODUCT_NL668    0x1001
> 
>  /* Device flags */
> 
> @@ -1941,6 +1944,8 @@ static const struct usb_device_id option_ids[] = {
>   { USB_DEVICE_AND_INTERFACE_INFO(WETELECOM_VENDOR_ID,
> WETELECOM_PRODUCT_6802, 0xff, 0xff, 0xff) },
>   { USB_DEVICE_AND_INTERFACE_INFO(WETELECOM_VENDOR_ID,
> WETELECOM_PRODUCT_WMD300, 0xff, 0xff, 0xff) },
>   { USB_DEVICE_AND_INTERFACE_INFO(0x03f0, 0x421d, 0xff, 0xff, 0xff) },
> /* HP lt2523 (Novatel E371) */
> + { USB_DEVICE(FIBOCOM_VENDOR_ID, FIBOCOM_PRODUCT_NL668), /* Fibocom
> NL668 series */
> +   .driver_info = RSVD(4) | RSVD(5) },
>   { } /* Terminating entry */
>  };
>  MODULE_DEVICE_TABLE(usb, option_ids);

Your email client corrupted the patch by eating the tabs and
line-wrapping the patch, making it impossible to apply :(

Please fix up and resend.

thanks,

greg k-h
diff mbox series

Patch

diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index e24ff16..f2cc85c 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -552,6 +552,9 @@  static void option_instat_callback(struct urb *urb);
 #define WETELECOM_PRODUCT_6802 0x6802
 #define WETELECOM_PRODUCT_WMD300 0x6803

+/* Fibocom products */
+#define FIBOCOM_VENDOR_ID    0x1508
+#define FIBOCOM_PRODUCT_NL668    0x1001

 /* Device flags */

@@ -1941,6 +1944,8 @@  static const struct usb_device_id option_ids[] = {
  { USB_DEVICE_AND_INTERFACE_INFO(WETELECOM_VENDOR_ID,
WETELECOM_PRODUCT_6802, 0xff, 0xff, 0xff) },
  { USB_DEVICE_AND_INTERFACE_INFO(WETELECOM_VENDOR_ID,
WETELECOM_PRODUCT_WMD300, 0xff, 0xff, 0xff) },
  { USB_DEVICE_AND_INTERFACE_INFO(0x03f0, 0x421d, 0xff, 0xff, 0xff) },
/* HP lt2523 (Novatel E371) */
+ { USB_DEVICE(FIBOCOM_VENDOR_ID, FIBOCOM_PRODUCT_NL668), /* Fibocom
NL668 series */