| Message ID | 20181207165103.3992-2-philmd@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Introduce the hw/firmware/ namespace | expand |
On 12/07/18 17:51, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > tests/acpi-utils.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/tests/acpi-utils.c b/tests/acpi-utils.c > index 41dc1ea9b4..297af55d39 100644 > --- a/tests/acpi-utils.c > +++ b/tests/acpi-utils.c > @@ -15,7 +15,6 @@ > #include "qemu/osdep.h" > #include <glib/gstdio.h> > #include "qemu-common.h" > -#include "hw/smbios/smbios.h" > #include "qemu/bitmap.h" > #include "acpi-utils.h" > #include "boot-sector.h" > Opinions vary whether empty commit message bodies are good style or not. Personally I prefer to put at least one sentence in there, even if it only repeats the subject line. Up to subsystem maintainers to decide I guess. With the commit message updated, or not: Reviewed-by: Laszlo Ersek <lersek@redhat.com>
On 12/10/18 3:55 PM, Laszlo Ersek wrote: > On 12/07/18 17:51, Philippe Mathieu-Daudé wrote: >> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> >> --- >> tests/acpi-utils.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/tests/acpi-utils.c b/tests/acpi-utils.c >> index 41dc1ea9b4..297af55d39 100644 >> --- a/tests/acpi-utils.c >> +++ b/tests/acpi-utils.c >> @@ -15,7 +15,6 @@ >> #include "qemu/osdep.h" >> #include <glib/gstdio.h> >> #include "qemu-common.h" >> -#include "hw/smbios/smbios.h" >> #include "qemu/bitmap.h" >> #include "acpi-utils.h" >> #include "boot-sector.h" >> > > Opinions vary whether empty commit message bodies are good style or not. > Personally I prefer to put at least one sentence in there, even if it > only repeats the subject line. Up to subsystem maintainers to decide I > guess. OK, understood. > > With the commit message updated, or not: > > Reviewed-by: Laszlo Ersek <lersek@redhat.com> Thanks!
diff --git a/tests/acpi-utils.c b/tests/acpi-utils.c index 41dc1ea9b4..297af55d39 100644 --- a/tests/acpi-utils.c +++ b/tests/acpi-utils.c @@ -15,7 +15,6 @@ #include "qemu/osdep.h" #include <glib/gstdio.h> #include "qemu-common.h" -#include "hw/smbios/smbios.h" #include "qemu/bitmap.h" #include "acpi-utils.h" #include "boot-sector.h"
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- tests/acpi-utils.c | 1 - 1 file changed, 1 deletion(-)